diff --git a/.cargo/config.toml b/.cargo/config.toml
index 115192e..ac2b23f 100644
--- a/.cargo/config.toml
+++ b/.cargo/config.toml
@@ -1,6 +1,2 @@
[target.x86_64-pc-windows-msvc]
rustflags = ["-C", "target-feature=+crt-static"]
-
-[target.x86_64-unknown-linux-gnu]
-linker = "clang"
-rustflags = ["-C", "link-arg=-fuse-ld=mold"]
diff --git a/.deepsource.toml b/.deepsource.toml
deleted file mode 100644
index 21d4940..0000000
--- a/.deepsource.toml
+++ /dev/null
@@ -1,13 +0,0 @@
-version = 1
-
-[[analyzers]]
-name = "rust"
-
- [analyzers.meta]
- msrv = "stable"
-
-[[analyzers]]
-name = "test-coverage"
-
-[[transformers]]
-name = "rustfmt"
\ No newline at end of file
diff --git a/.github/ISSUE_TEMPLATE/1-bug-report.yml b/.github/ISSUE_TEMPLATE/1-bug-report.yml
index 8246a4d..d00294e 100644
--- a/.github/ISSUE_TEMPLATE/1-bug-report.yml
+++ b/.github/ISSUE_TEMPLATE/1-bug-report.yml
@@ -62,15 +62,24 @@ body:
label: Desktop Environment
description: If relevant, please fill it
placeholder: GNOME 46, KDE Plasma 4, etc...
+- type: input
+ id: adb-v
+ attributes:
+ label: ADB version
+ description: If relevant, please fill it
+ placeholder: 1.0.41
- type: textarea
id: logfiles
attributes:
label: Provide logs
description: "Paste the relevant (notice the line timestamps) slice (contiguous range) of [the logfile generated by UAD-ng](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki/FAQ#where-are-the-logfiles)"
- render: "" # this should disable soft-wrap
- validations:
- required: true
+ value: |
+ Log
+ ```
+ Please replace this line by the log-file contents
+ ```
+
+
+
-
-**Check out the issues, and [feel free to contribute!](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki/How-to-contribute)**
-
-**For real-time communication, consider joining our Discord server:**
-
-[](https://discord.gg/YHujHzA57a)
-
-**In case you prefer using Matrix (using a Matrix bridge to Discord):**
-
-[
](https://matrix.to/#/#uad-ng:matrix.org)
-
-
-## Summary
-
-This is a detached fork of the [UAD project](https://github.com/0x192/universal-android-debloater), which aims to improve privacy and battery performance by removing unnecessary and obscure system apps.
-This can also contribute to improving security by reducing (but not eliminating) [the attack surface](https://en.wikipedia.org/wiki/Attack_surface). Read the [wiki](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki) for more details on getting started. Whilst UAD-ng can remove system apps, it cannot detect or remove potentially malicious system services or drivers baked into the firmware of your device by various vendors; some vendor-specific apps are only UI front-ends to vendor-provided system services, and as such disabling/uninstalling those apps will not stop a service from running. Additional information can be found in package descriptions inside the Universal Android Debloater Next Generation application.
+This is a detached fork of the [UAD project](https://github.com/0x192/universal-android-debloater). This aims to improve privacy and efficiency (energy, speed, memory) by removing unnecessary and obscure system apps.
+This can also improve security by reducing the [attack surface](https://en.wikipedia.org/wiki/Attack_surface). Read [the wiki](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki) for more details.
## Documentation
-For documentation regarding how to use UAD-ng, the FAQ, building from source and how to decompile/extract APKs, see [our Wiki](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki).
+Everything about UAD-ng (and related stuff) can be found on the Wiki, such as:
+
+- [Getting started](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki/Getting-started)
+- Features of this app
+- [Usage guide](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki/Usage)
+- Suggested Android app replacements
+- How to get the cutting-edge version by [building the source-code](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki/Building-from-source)
+- Weird things OEMs do
+- [Suggested apps for analyzing APKs](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki/How-to-contribute#useful-apps)
+
+## Privacy
+
+UAD-ng does not collect or transmit any user data. The only external connections are `GET` requests to GitHub for fetching the [package list](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/blob/main/resources/assets/uad_lists.json) ([src/core/uad_lists.rs](src/core/uad_lists.rs)) and checking for updates ([src/core/update.rs](src/core/update.rs)).
+
+## Contact
+
+**For real-time communication and support, consider joining our Discord guild:**
+
+[
](https://discord.gg/CzwbMCPEZa)
+
+**If you prefer using Matrix, we have a bridge to Discord:**
+
+[
](https://matrix.to/#/#uad-ng:matrix.org)
+
+## Friends
+
+Several projects integrate with or depend on UAD-ng's data and tools:
+
+- **[Canta](https://github.com/samolego/Canta)** — A mobile Android debloater that uses Shizuku for rootless privilege escalation. It integrates with UAD-ng's Universal Debloat List to provide safe package recommendations without requiring a PC.
+
+- **Projects by [Muntashir Akon](https://github.com/MuntashirAkon):**
+ - **[AppManager](https://github.com/MuntashirAkon/AppManager)** — An advanced Android app manager with powerful debloating features.
+ - **[android-debloat-list](https://github.com/MuntashirAkon/android-debloat-list)** — A comprehensive, community-driven list of Android packages to debloat, based on UAD-ng's list.
## Special thanks
- [@0x192](https://github.com/0x192) who created the original UAD project.
-- [@mawilms](https://github.com/mawilms) for his LotRO plugin manager ([Lembas](https://github.com/mawilms/lembas)) which helped a lot to understand how to use the [Iced](https://github.com/hecrj/iced) GUI library.
+- [@mawilms](https://github.com/mawilms) for his LotRO plugin manager ([Lembas](https://github.com/mawilms/lembas)) which helped a lot to understand how to use the [Iced](https://github.com/iced-rs/iced) GUI library.
- [@casperstorm](https://github.com/casperstorm) for the UI/UX inspiration.
diff --git a/RELEASE.md b/RELEASE.md
new file mode 100644
index 0000000..c029638
--- /dev/null
+++ b/RELEASE.md
@@ -0,0 +1,38 @@
+# Release management
+
+## Semantic versioning
+
+We're making use of [semantic versioning](https://semver.org/). We use semantic versioning for two things:
+
+1. GitHub Milestones
+1. UAD-ng releases
+
+Speaking of milestones: it could be that we have a bug-fix release (e.g. 1.0.3), but a contributor submits a PR that adds a new feature. What do we do? Merge after we released 1.0.3? Change the name of the milestone to for example 1.1.0? Or another approach?
+
+In that case, we should closely review the PR and 'compare' it with what semantic versioning has to say about the submitted feature. If the changes are significant enough, we're renaming the milestone to (for example) 1.1.0.
+
+## Checklist before releasing a new version
+
+- [ ] Make sure the Milestone is completed and if not, check what needs to be done to complete it.
+- [ ] Make sure all merged PRs regarding the application follow the Conventional Commit Messages style. This makes sure that when generating a changelog, the changes look consistent, which in turn improves readability.
+- [ ] Make sure all merged PRs have the correct labels assigned, as the changelog is generated based on labels.
+- [ ] Create a release preparation PR that bumps the UAD-ng version in `Cargo.toml` and `Cargo.lock`.
+
+When all the above has been checked, you can push a tag to `main` to trigger the GitHub Action that creates a release:
+
+- Create the tag: `git tag -s v1.2.3 -am '1.2.3'`
+- Push the tag: `git push origin v1.2.3`
+
+Change the version number to whatever version we're releasing.
+
+## Development process
+
+1. Update dependencies right after a new release, so that we start a new milestone with updated dependencies
+1. On-going development of bug-fixes and new features etc, along with fixing potential bugs, potentially due to the updated dependencies
+1. Release
+
+## Faulty releases
+
+If we publish a faulty release, for example containing a critical bug, this is how we should deal with it:
+
+We issue a hotfix and keep the faulty release but we'll add warnings to the faulty release in the changelog.
diff --git a/build.rs b/build.rs
index cc564fe..e2bbb62 100644
--- a/build.rs
+++ b/build.rs
@@ -1,9 +1,11 @@
-use std::{env, error::Error};
+const META: &str = "resources/assets/manifest.rc";
-fn main() -> Result<(), Box> {
- if env::var("CARGO_CFG_TARGET_FAMILY")? == "windows" {
- embed_resource::compile("resources/assets/manifest.rc", embed_resource::NONE);
+fn main() -> Result<(), Box> {
+ println!("cargo::rerun-if-changed={META}");
+ if std::env::var("CARGO_CFG_TARGET_FAMILY")? == "windows" {
+ embed_resource::compile(META, embed_resource::NONE)
+ .manifest_optional()
+ .unwrap();
}
-
Ok(())
}
diff --git a/clippy.toml b/clippy.toml
new file mode 100644
index 0000000..ea830ad
--- /dev/null
+++ b/clippy.toml
@@ -0,0 +1,7 @@
+disallowed-types = [
+ { path = "iced::widget::Text", reason = "Use [`crate::gui::widgets::text`] instead. For further details, see #523 and #858" },
+]
+
+disallowed-methods= [
+ { path = "iced::widget::text", reason = "Use [`crate::gui::widgets::text`] instead. For further details, see #523 and #858" },
+]
diff --git a/crates/uad-cli/Cargo.toml b/crates/uad-cli/Cargo.toml
new file mode 100644
index 0000000..6045f95
--- /dev/null
+++ b/crates/uad-cli/Cargo.toml
@@ -0,0 +1,52 @@
+[package]
+name = "uad-cli"
+version.workspace = true
+authors.workspace = true
+license.workspace = true
+homepage.workspace = true
+repository.workspace = true
+readme.workspace = true
+keywords.workspace = true
+categories = ["command-line-utilities"]
+edition.workspace = true
+
+[[bin]]
+name = "uad"
+path = "src/main.rs"
+
+[dependencies]
+uad-core = { path = "../uad-core" }
+clap.workspace = true
+clap_complete = "4.4"
+tokio.workspace = true
+serde.workspace = true
+serde_json.workspace = true
+log.workspace = true
+chrono.workspace = true
+toml.workspace = true
+dirs.workspace = true
+ureq.workspace = true
+retry.workspace = true
+csv.workspace = true
+rustyline = "14.0"
+
+[lints.rust]
+deprecated_safe = "warn"
+
+[lints.clippy]
+undocumented_unsafe_blocks = "deny"
+exit = "deny"
+panic_in_result_fn = "warn"
+infinite_loop = "warn"
+mem_forget = "warn"
+implicit_clone = "warn"
+format_push_string = "warn"
+large_include_file = "warn"
+shadow_unrelated = "warn"
+struct_field_names = "allow" # annoying
+
+disallowed_types = "deny"
+disallowed_methods = "deny"
+
+allow_attributes_without_reason = "warn"
+pedantic = { level = "warn", priority = -1 }
diff --git a/crates/uad-cli/examples/usage.sh b/crates/uad-cli/examples/usage.sh
new file mode 100755
index 0000000..ab3192e
--- /dev/null
+++ b/crates/uad-cli/examples/usage.sh
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+
+# Example usage script for UAD CLI
+
+# Check if uad-cli is available
+if ! command -v uad &> /dev/null; then
+ echo "uad command not found. Please build and install uad-cli first."
+ exit 1
+fi
+
+echo "=== UAD CLI Usage Examples ==="
+echo
+
+echo "1. List connected devices:"
+uad devices
+echo
+
+echo "2. List all enabled packages:"
+uad list --state enabled | head -20
+echo "... (showing first 20)"
+echo
+
+echo "3. Search for Google packages:"
+uad list --search google | head -10
+echo "... (showing first 10)"
+echo
+
+echo "4. Show info about a package (example):"
+echo "uad info com.google.android.gms"
+echo
+
+echo "5. Dry-run uninstall (safe to test):"
+echo "uad uninstall com.example.package --dry-run"
+echo
+
+echo "6. Start interactive mode:"
+echo "uad repl"
+echo
+
+echo "=== Generate shell completions ==="
+echo "For bash: uad completions bash > ~/.local/share/bash-completion/completions/uad"
+echo "For zsh: uad completions zsh > ~/.local/share/zsh/site-functions/_uad"
+echo "For fish: uad completions fish > ~/.config/fish/completions/uad.fish"
+
diff --git a/crates/uad-cli/src/commands.rs b/crates/uad-cli/src/commands.rs
new file mode 100644
index 0000000..62286bd
--- /dev/null
+++ b/crates/uad-cli/src/commands.rs
@@ -0,0 +1,470 @@
+use clap::CommandFactory;
+use clap_complete::{Shell, generate};
+use std::collections::{HashMap, HashSet};
+use std::io::Write;
+use uad_core::adb::{ACommand, PmListPacksFlag};
+use uad_core::sync::{
+ CorePackage, Phone, User, apply_pkg_state_commands, get_devices_list, get_package_state,
+ run_adb_shell_action,
+};
+use uad_core::uad_lists::{Package, PackageState, Removal, UadList, load_debloat_lists};
+use uad_core::utils::{matches_search, truncate_description};
+
+use crate::device::{NO_DEVICES_FOUND, get_target_device, get_user};
+use crate::filters::{ListFilter, RemovalFilter, StateFilter};
+use crate::{Cli, print_or_exit, println_or_exit};
+
+/// List all connected Android devices
+pub fn list_devices() -> Result<(), Box> {
+ println_or_exit!("Scanning for connected devices...");
+ let devices = get_devices_list();
+
+ if devices.is_empty() {
+ return Err(NO_DEVICES_FOUND.into());
+ }
+
+ println_or_exit!("\nFound {} device(s):\n", devices.len());
+ for device in &devices {
+ println_or_exit!(" Model: {}", device.model);
+ println_or_exit!(" Serial: {}", device.adb_id);
+ println_or_exit!(" Android SDK: {}", device.android_sdk);
+
+ if !device.user_list.is_empty() {
+ println_or_exit!(" Users: {} user(s)", device.user_list.len());
+ for user in &device.user_list {
+ let protected = if user.protected { " (protected)" } else { "" };
+ println_or_exit!(" - User ID: {}{}", user.id, protected);
+ }
+ }
+ println_or_exit!();
+ }
+
+ Ok(())
+}
+
+/// Context for package filtering and display
+pub struct PackageListContext {
+ pub state_filter: Option,
+ pub removal_filter: Option,
+ pub list_filter: Option,
+ pub search: Option,
+}
+
+impl PackageListContext {
+ /// Check if package passes all filters
+ pub fn filter_package(
+ &self,
+ pkg_name: &str,
+ pkg_info: Option<&Package>,
+ pkg_state: PackageState,
+ ) -> bool {
+ // Removal filter
+ if let Some(removal) = self.removal_filter {
+ if !removal.matches(pkg_info) {
+ return false;
+ }
+ }
+
+ // State filter
+ if let Some(state) = self.state_filter {
+ if !state.matches(pkg_state) {
+ return false;
+ }
+ }
+
+ // List filter
+ if let Some(list) = self.list_filter {
+ if !list.matches(pkg_info) {
+ return false;
+ }
+ }
+
+ // Search filter
+ if let Some(ref search_term) = self.search {
+ let description = pkg_info.map(|p| p.description.as_str());
+ if !matches_search(pkg_name, search_term, description) {
+ return false;
+ }
+ }
+
+ true
+ }
+
+ /// Determine what information to show based on active filters
+ pub fn display_config(&self) -> DisplayConfig {
+ DisplayConfig {
+ show_state: self.state_filter.is_none_or(|f| !f.is_specific()),
+ show_removal: self.removal_filter.is_none_or(|f| !f.is_specific()),
+ }
+ }
+}
+
+pub struct DisplayConfig {
+ pub show_state: bool,
+ pub show_removal: bool,
+}
+
+/// List packages on a device with filtering
+pub fn list_packages(
+ device: Option,
+ state_filter: Option,
+ removal_filter: Option,
+ list_filter: Option,
+ search: Option,
+ user_id: Option,
+) -> Result<(), Box> {
+ let target_device = get_target_device(device)?;
+ let uad_lists = load_debloat_lists(false).unwrap_or_else(|lists| lists);
+
+ println_or_exit!(
+ "Listing packages on: {} ({})\n",
+ target_device.model,
+ target_device.adb_id
+ );
+
+ let context = PackageListContext {
+ state_filter,
+ removal_filter,
+ list_filter,
+ search,
+ };
+
+ let pm_flag = state_filter.and_then(StateFilter::to_pm_flag);
+ let system_packages = ACommand::new()
+ .shell(&target_device.adb_id)
+ .pm()
+ .list_packages_sys(pm_flag, user_id)?;
+
+ let displayed_count = display_package_list(
+ &system_packages,
+ &uad_lists,
+ &target_device.adb_id,
+ user_id,
+ &context,
+ )?;
+
+ if displayed_count == 0 {
+ println_or_exit!(" No packages found matching the specified filters.");
+ } else {
+ println_or_exit!("\nTotal: {} package(s)", displayed_count);
+ }
+
+ Ok(())
+}
+
+/// Display a list of packages with their info
+pub fn display_package_list(
+ packages: &[String],
+ uad_lists: &HashMap,
+ device_serial: &str,
+ user_id: Option,
+ context: &PackageListContext,
+) -> Result> {
+ let config = context.display_config();
+ let mut displayed_count = 0;
+
+ let enabled_packages: HashSet = ACommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(Some(PmListPacksFlag::OnlyEnabled), user_id)
+ .unwrap_or_default()
+ .into_iter()
+ .collect();
+ let disabled_packages: HashSet = ACommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(Some(PmListPacksFlag::OnlyDisabled), user_id)
+ .unwrap_or_default()
+ .into_iter()
+ .collect();
+
+ for pkg_name in packages {
+ let pkg_info = uad_lists.get(pkg_name);
+
+ let pkg_state = if enabled_packages.contains(pkg_name) {
+ PackageState::Enabled
+ } else if disabled_packages.contains(pkg_name) {
+ PackageState::Disabled
+ } else {
+ PackageState::Uninstalled
+ };
+
+ if !context.filter_package(pkg_name, pkg_info, pkg_state) {
+ continue;
+ }
+
+ display_package_entry(pkg_name, pkg_info, pkg_state, &config);
+ displayed_count += 1;
+ }
+
+ Ok(displayed_count)
+}
+
+/// Display a single package entry
+pub fn display_package_entry(
+ pkg_name: &str,
+ pkg_info: Option<&Package>,
+ pkg_state: PackageState,
+ config: &DisplayConfig,
+) {
+ print_or_exit!("[");
+
+ if let Some(info) = pkg_info {
+ if config.show_removal {
+ print_or_exit!("{}", info.removal);
+ if config.show_state {
+ print_or_exit!(" - ");
+ }
+ }
+ if config.show_state {
+ print_or_exit!("{}", pkg_state);
+ }
+ print_or_exit!("] {}", pkg_name);
+ if !info.description.is_empty() {
+ print_or_exit!(" - {}", truncate_description(&info.description, 80));
+ }
+ } else {
+ if config.show_removal {
+ print_or_exit!("Unlisted");
+ if config.show_state {
+ print_or_exit!(" - ");
+ }
+ }
+ if config.show_state {
+ print_or_exit!("{}", pkg_state);
+ }
+ print_or_exit!("] {}", pkg_name);
+ }
+
+ println_or_exit!();
+}
+
+/// Change the state of one or more packages
+pub fn change_package_state(
+ packages: &[String],
+ device: Option,
+ user_id: Option,
+ dry_run: bool,
+ target_state: PackageState,
+ action_name: &str,
+) -> Result<(), Box> {
+ if packages.is_empty() {
+ return Err("No packages specified".into());
+ }
+
+ let target_device = get_target_device(device)?;
+ let user = get_user(&target_device, user_id)?;
+ let uad_lists = load_debloat_lists(false).unwrap_or_else(|lists| lists);
+
+ println!(
+ "{} {} package(s) on: {} ({})\n",
+ action_name,
+ packages.len(),
+ target_device.model,
+ target_device.adb_id
+ );
+
+ if dry_run {
+ println!("DRY RUN - No changes will be made\n");
+ }
+
+ for pkg_name in packages {
+ process_package_state_change(
+ pkg_name,
+ &target_device,
+ user,
+ target_state,
+ dry_run,
+ &uad_lists,
+ )?;
+ println!();
+ }
+
+ if dry_run {
+ println!("Dry run completed. No changes were made.");
+ } else {
+ println!("Operation completed successfully.");
+ }
+
+ Ok(())
+}
+
+/// Process state change for a single package
+fn process_package_state_change(
+ pkg_name: &str,
+ device: &Phone,
+ user: User,
+ target_state: PackageState,
+ dry_run: bool,
+ uad_lists: &HashMap,
+) -> Result<(), Box> {
+ let current_state = get_package_state(&device.adb_id, pkg_name, Some(user.id))
+ .ok_or("Package not found on device")?;
+
+ println!(" {} ({})", pkg_name, current_state);
+
+ if current_state == target_state {
+ println!(" → Already in target state, skipping");
+ return Ok(());
+ }
+
+ let pkg_info = uad_lists.get(pkg_name);
+ if let Some(info) = pkg_info {
+ if info.removal == Removal::Unsafe {
+ println!(" ⚠ WARNING: This package is marked as UNSAFE to remove!");
+ }
+ }
+
+ let core_pkg = CorePackage {
+ name: pkg_name.to_string(),
+ description: pkg_info.map(|p| p.description.clone()).unwrap_or_default(),
+ removal: pkg_info.map(|p| p.removal).unwrap_or(Removal::Unlisted),
+ state: current_state,
+ list: pkg_info.map(|p| p.list).unwrap_or(UadList::Unlisted),
+ };
+
+ let commands = apply_pkg_state_commands(&core_pkg, target_state, user, device);
+
+ if dry_run {
+ for cmd in &commands {
+ println!(" Would run: {}", cmd);
+ }
+ } else {
+ execute_with_fallback(
+ pkg_name,
+ target_state,
+ &core_pkg,
+ user,
+ device,
+ &commands,
+ " ",
+ )?;
+ }
+
+ Ok(())
+}
+
+/// Execute commands and verify package state with fallback
+pub fn execute_with_fallback(
+ package: &str,
+ target_state: PackageState,
+ core_pkg: &CorePackage,
+ user: User,
+ device: &Phone,
+ commands: &[String],
+ indent: &str,
+) -> Result<(), Box> {
+ // Capture the before-state of packages on other users for cross-user detection
+ let before_cross_user_states =
+ uad_core::sync::capture_cross_user_states(package, &device.adb_id, user.id, device);
+
+ // Execute commands
+ for cmd in commands {
+ match run_adb_shell_action(&device.adb_id, cmd.as_str()) {
+ Ok(_) => println!("{}✓ {}", indent, cmd),
+ Err(e) => {
+ return Err(format!("{indent}✗ Failed to execute `{cmd}`: {e:?}").into());
+ }
+ }
+ }
+
+ // Verify package state and attempt fallback if needed
+ let actual_state = match get_package_state(&device.adb_id, package, Some(user.id)) {
+ Some(state) => state,
+ None if target_state == PackageState::Uninstalled => PackageState::Uninstalled,
+ None => {
+ return Err(format!(
+ "Package '{package}' was not found on device for user {}",
+ user.id
+ )
+ .into());
+ }
+ };
+
+ if actual_state != target_state {
+ println!(
+ "{}⚠ Package state verification failed: expected {:?}, got {:?}",
+ indent, target_state, actual_state
+ );
+
+ // Attempt fallback
+ if let Ok(fallback_action) =
+ uad_core::sync::attempt_fallback(core_pkg, target_state, actual_state, user, device)
+ {
+ println!("{}↻ Fallback: {}", indent, fallback_action);
+ } else {
+ println!("{}✗ No fallback available", indent);
+ }
+ }
+
+ // Check for cross-user behavior if operation succeeded
+ if actual_state == target_state {
+ if let Some(notification) = uad_core::sync::detect_cross_user_behavior(
+ package,
+ device.adb_id.as_str(),
+ user.id,
+ target_state,
+ actual_state,
+ device,
+ &before_cross_user_states,
+ ) {
+ println!("{}ℹ {}", indent, notification);
+ }
+ }
+
+ Ok(())
+}
+
+/// Show detailed information about a package
+pub fn show_package_info(
+ package: &str,
+ device: Option,
+ user_id: Option,
+) -> Result<(), Box> {
+ println!("Package: {}\n", package);
+
+ let uad_lists = load_debloat_lists(false).unwrap_or_else(|lists| lists);
+
+ if let Some(pkg_info) = uad_lists.get(package) {
+ println!("UAD Information:");
+ println!(" List: {}", pkg_info.list);
+ println!(" Removal: {}", pkg_info.removal);
+ println!(" Description: {}", pkg_info.description);
+ println!();
+ } else {
+ println!(" Not found in UAD lists (unlisted package)\n");
+ }
+
+ if let Some(device_id) = device {
+ let target_device = get_target_device(Some(device_id))?;
+ let user = get_user(&target_device, user_id)?;
+ println!("Device: {} ({})", target_device.model, target_device.adb_id);
+ println!("User: {}", user.id);
+
+ let state = get_package_state(&target_device.adb_id, package, Some(user.id))
+ .ok_or("Package not found on device")?;
+ println!(" State: {}", state);
+ }
+
+ Ok(())
+}
+
+/// Update UAD package lists from remote repository
+pub fn update_lists() -> Result<(), Box> {
+ println!("Updating UAD package lists from remote repository...");
+
+ match load_debloat_lists(true) {
+ Ok(_lists) => {
+ println!("✓ Successfully updated package lists");
+ Ok(())
+ }
+ Err(_lists) => Err("Failed to update lists from remote, using cached version".into()),
+ }
+}
+
+/// Generate shell completion script
+pub fn generate_completions(shell: Shell) {
+ let mut cmd = Cli::command();
+ let name = cmd.get_name().to_string();
+ generate(shell, &mut cmd, name, &mut std::io::stdout());
+}
diff --git a/crates/uad-cli/src/device.rs b/crates/uad-cli/src/device.rs
new file mode 100644
index 0000000..54fee8c
--- /dev/null
+++ b/crates/uad-cli/src/device.rs
@@ -0,0 +1,47 @@
+use uad_core::sync::{Phone, User, get_devices_list};
+
+pub const NO_DEVICES_FOUND: &str =
+ "No devices found. Make sure ADB is installed and devices are connected.";
+
+/// Get target device, either by serial or first available
+pub fn get_target_device(device: Option) -> Result> {
+ let devices = get_devices_list();
+
+ if devices.is_empty() {
+ return Err(NO_DEVICES_FOUND.into());
+ }
+
+ let target_device = if let Some(device_id) = device {
+ devices
+ .iter()
+ .find(|d| d.adb_id == device_id)
+ .ok_or("Device not found")?
+ .clone()
+ } else {
+ if devices.len() > 1 {
+ eprintln!(
+ "Warning: Multiple devices found, using first one: {}",
+ devices[0].adb_id
+ );
+ }
+ devices[0].clone()
+ };
+
+ Ok(target_device)
+}
+
+/// Get user from device, creating a basic one if not found
+pub fn get_user(device: &Phone, user_id: Option) -> Result> {
+ let uid = user_id.unwrap_or(0);
+
+ if let Some(user) = device.user_list.iter().find(|u| u.id == uid) {
+ Ok(*user)
+ } else {
+ // Create a basic user if not found in list
+ Ok(User {
+ id: uid,
+ index: 0,
+ protected: false,
+ })
+ }
+}
diff --git a/crates/uad-cli/src/filters.rs b/crates/uad-cli/src/filters.rs
new file mode 100644
index 0000000..5ae156f
--- /dev/null
+++ b/crates/uad-cli/src/filters.rs
@@ -0,0 +1,98 @@
+use clap::ValueEnum;
+use uad_core::adb::PmListPacksFlag;
+use uad_core::uad_lists::{Package, PackageState, Removal, UadList};
+
+#[derive(Debug, Clone, Copy, ValueEnum)]
+pub enum StateFilter {
+ /// Show all packages regardless of state
+ All,
+ /// Show only enabled packages
+ Enabled,
+ /// Show only disabled packages
+ Disabled,
+ /// Show only uninstalled packages
+ Uninstalled,
+}
+
+#[derive(Debug, Clone, Copy, ValueEnum)]
+pub enum RemovalFilter {
+ All,
+ Recommended,
+ Advanced,
+ Expert,
+ Unsafe,
+ Unlisted,
+}
+
+#[derive(Debug, Clone, Copy, ValueEnum)]
+pub enum ListFilter {
+ All,
+ Aosp,
+ Carrier,
+ Google,
+ Misc,
+ Oem,
+ Pending,
+ Unlisted,
+}
+
+impl StateFilter {
+ pub fn to_pm_flag(self) -> Option {
+ match self {
+ Self::Enabled => Some(PmListPacksFlag::OnlyEnabled),
+ Self::Disabled => Some(PmListPacksFlag::OnlyDisabled),
+ Self::Uninstalled | Self::All => Some(PmListPacksFlag::IncludeUninstalled),
+ }
+ }
+
+ pub fn matches(self, pkg_state: PackageState) -> bool {
+ match self {
+ Self::All => true,
+ Self::Enabled => pkg_state == PackageState::Enabled,
+ Self::Disabled => pkg_state == PackageState::Disabled,
+ Self::Uninstalled => pkg_state == PackageState::Uninstalled,
+ }
+ }
+
+ pub fn is_specific(self) -> bool {
+ matches!(self, Self::Enabled | Self::Disabled | Self::Uninstalled)
+ }
+}
+
+impl RemovalFilter {
+ pub fn matches(self, pkg_info: Option<&Package>) -> bool {
+ match pkg_info {
+ Some(info) => match self {
+ Self::All => true,
+ Self::Recommended => info.removal == Removal::Recommended,
+ Self::Advanced => info.removal == Removal::Advanced,
+ Self::Expert => info.removal == Removal::Expert,
+ Self::Unsafe => info.removal == Removal::Unsafe,
+ Self::Unlisted => info.removal == Removal::Unlisted,
+ },
+ None => matches!(self, Self::All | Self::Unlisted),
+ }
+ }
+
+ pub fn is_specific(self) -> bool {
+ !matches!(self, Self::All)
+ }
+}
+
+impl ListFilter {
+ pub fn matches(self, pkg_info: Option<&Package>) -> bool {
+ match pkg_info {
+ Some(info) => match self {
+ Self::All => true,
+ Self::Aosp => info.list == UadList::Aosp,
+ Self::Carrier => info.list == UadList::Carrier,
+ Self::Google => info.list == UadList::Google,
+ Self::Misc => info.list == UadList::Misc,
+ Self::Oem => info.list == UadList::Oem,
+ Self::Pending => info.list == UadList::Pending,
+ Self::Unlisted => info.list == UadList::Unlisted,
+ },
+ None => matches!(self, Self::All | Self::Unlisted),
+ }
+ }
+}
diff --git a/crates/uad-cli/src/main.rs b/crates/uad-cli/src/main.rs
new file mode 100644
index 0000000..f473e28
--- /dev/null
+++ b/crates/uad-cli/src/main.rs
@@ -0,0 +1,251 @@
+#![allow(
+ clippy::needless_continue,
+ clippy::collapsible_if,
+ clippy::uninlined_format_args,
+ clippy::map_unwrap_or,
+ clippy::unnecessary_wraps,
+ reason = "Suppress non-critical pedantic/style lints to keep build green"
+)]
+
+use clap::{Parser, Subcommand};
+use clap_complete::Shell;
+use std::process::ExitCode;
+use uad_core::uad_lists::PackageState;
+
+mod commands;
+mod device;
+mod filters;
+mod output;
+mod repl;
+
+use filters::{ListFilter, RemovalFilter, StateFilter};
+
+#[derive(Parser)]
+#[command(name = "uad")]
+#[command(about = "Universal Android Debloater - Command Line Interface", long_about = None)]
+#[command(version)]
+#[command(propagate_version = true)]
+pub struct Cli {
+ #[command(subcommand)]
+ command: Commands,
+}
+
+#[derive(Subcommand)]
+enum Commands {
+ /// List connected Android devices
+ Devices,
+
+ /// List packages on a device
+ #[command(name = "list", visible_alias = "ls")]
+ List {
+ /// Device serial number (optional, uses first device if not specified)
+ #[arg(short, long)]
+ device: Option,
+
+ /// Filter by package state
+ #[arg(short, long, value_enum)]
+ state: Option,
+
+ /// Filter by removal category
+ #[arg(short, long, value_enum)]
+ removal: Option,
+
+ /// Filter by UAD list
+ #[arg(short, long, value_enum)]
+ list: Option,
+
+ /// Search pattern (matches package name or description)
+ #[arg(short = 'q', long)]
+ search: Option,
+
+ /// User ID (defaults to 0)
+ #[arg(short, long)]
+ user: Option,
+ },
+
+ /// Uninstall packages (default removal action)
+ #[command(visible_alias = "rm")]
+ Uninstall {
+ /// Package names to uninstall
+ packages: Vec,
+
+ /// Device serial number (optional, uses first device if not specified)
+ #[arg(short, long)]
+ device: Option,
+
+ /// User ID (defaults to 0)
+ #[arg(short, long)]
+ user: Option,
+
+ /// Dry run - show what would be done without actually doing it
+ #[arg(long)]
+ dry_run: bool,
+ },
+
+ /// Restore (reinstall) packages
+ #[command(visible_alias = "restore")]
+ Enable {
+ /// Package names to restore/enable
+ packages: Vec,
+
+ /// Device serial number (optional, uses first device if not specified)
+ #[arg(short, long)]
+ device: Option,
+
+ /// User ID (defaults to 0)
+ #[arg(short, long)]
+ user: Option,
+
+ /// Dry run - show what would be done without actually doing it
+ #[arg(long)]
+ dry_run: bool,
+ },
+
+ /// Disable packages (keeps data but prevents execution)
+ Disable {
+ /// Package names to disable
+ packages: Vec,
+
+ /// Device serial number (optional, uses first device if not specified)
+ #[arg(short, long)]
+ device: Option,
+
+ /// User ID (defaults to 0)
+ #[arg(short, long)]
+ user: Option,
+
+ /// Dry run - show what would be done without actually doing it
+ #[arg(long)]
+ dry_run: bool,
+ },
+
+ /// Show detailed information about a package
+ Info {
+ /// Package name
+ package: String,
+
+ /// Device serial number (optional, uses first device if not specified)
+ #[arg(short, long)]
+ device: Option,
+
+ /// User ID (defaults to 0)
+ #[arg(short, long)]
+ user: Option,
+ },
+
+ /// Update UAD package lists from remote repository
+ Update,
+
+ /// Generate shell completion script
+ Completions {
+ /// Shell to generate completions for
+ #[arg(value_enum)]
+ shell: Shell,
+ },
+
+ /// Start interactive REPL mode
+ #[command(visible_alias = "shell")]
+ Repl {
+ /// Device serial number (optional, uses first device if not specified)
+ #[arg(short, long)]
+ device: Option,
+
+ /// User ID (defaults to 0)
+ #[arg(short, long)]
+ user: Option,
+ },
+}
+
+#[tokio::main]
+async fn main() -> ExitCode {
+ match run() {
+ Ok(()) => ExitCode::SUCCESS,
+ Err(err) => {
+ eprintln!("Error: {err}");
+ ExitCode::FAILURE
+ }
+ }
+}
+
+fn run() -> Result<(), Box> {
+ let cli = Cli::parse();
+
+ match cli.command {
+ Commands::Devices => {
+ commands::list_devices()?;
+ }
+ Commands::List {
+ device,
+ state,
+ removal,
+ list,
+ search,
+ user,
+ } => {
+ commands::list_packages(device, state, removal, list, search, user)?;
+ }
+ Commands::Uninstall {
+ packages,
+ device,
+ user,
+ dry_run,
+ } => {
+ commands::change_package_state(
+ &packages,
+ device,
+ user,
+ dry_run,
+ PackageState::Uninstalled,
+ "Uninstalling",
+ )?;
+ }
+ Commands::Enable {
+ packages,
+ device,
+ user,
+ dry_run,
+ } => {
+ commands::change_package_state(
+ &packages,
+ device,
+ user,
+ dry_run,
+ PackageState::Enabled,
+ "Enabling",
+ )?;
+ }
+ Commands::Disable {
+ packages,
+ device,
+ user,
+ dry_run,
+ } => {
+ commands::change_package_state(
+ &packages,
+ device,
+ user,
+ dry_run,
+ PackageState::Disabled,
+ "Disabling",
+ )?;
+ }
+ Commands::Info {
+ package,
+ device,
+ user,
+ } => {
+ commands::show_package_info(&package, device, user)?;
+ }
+ Commands::Update => {
+ commands::update_lists()?;
+ }
+ Commands::Completions { shell } => {
+ commands::generate_completions(shell);
+ }
+ Commands::Repl { device, user } => {
+ repl::repl_mode(device, user)?;
+ }
+ }
+
+ Ok(())
+}
diff --git a/crates/uad-cli/src/output.rs b/crates/uad-cli/src/output.rs
new file mode 100644
index 0000000..cff4724
--- /dev/null
+++ b/crates/uad-cli/src/output.rs
@@ -0,0 +1,18 @@
+/// Helper macro to handle broken pipe errors gracefully
+/// When piping to commands like `head`, we want to exit cleanly when the pipe closes
+#[macro_export]
+macro_rules! println_or_exit {
+ () => {
+ let _ = writeln!(std::io::stdout());
+ };
+ ($($arg:tt)*) => {
+ let _ = writeln!(std::io::stdout(), $($arg)*);
+ };
+}
+
+#[macro_export]
+macro_rules! print_or_exit {
+ ($($arg:tt)*) => {
+ let _ = write!(std::io::stdout(), $($arg)*);
+ };
+}
diff --git a/crates/uad-cli/src/repl.rs b/crates/uad-cli/src/repl.rs
new file mode 100644
index 0000000..eeee0c6
--- /dev/null
+++ b/crates/uad-cli/src/repl.rs
@@ -0,0 +1,374 @@
+use rustyline::DefaultEditor;
+use rustyline::error::ReadlineError;
+use std::collections::HashMap;
+use std::io::Write;
+use uad_core::adb::ACommand;
+use uad_core::sync::{CorePackage, Phone, User, apply_pkg_state_commands, get_package_state};
+use uad_core::uad_lists::{Package, PackageState, Removal, UadList, load_debloat_lists};
+
+use crate::commands::{PackageListContext, display_package_list, execute_with_fallback};
+use crate::device::{get_target_device, get_user};
+use crate::filters::StateFilter;
+use crate::println_or_exit;
+
+enum ReplAction {
+ Continue,
+ Exit,
+}
+
+/// Start interactive REPL mode
+pub fn repl_mode(
+ device: Option,
+ user_id: Option,
+) -> Result<(), Box> {
+ println!("Universal Android Debloater - Interactive Mode");
+ println!("Type 'help' for available commands, 'exit' or 'quit' to leave\n");
+
+ let target_device = get_target_device(device)?;
+ let user = get_user(&target_device, user_id)?;
+
+ println!(
+ "Connected to: {} ({})",
+ target_device.model, target_device.adb_id
+ );
+ println!("User: {}\n", user.id);
+
+ let uad_lists = load_debloat_lists(false).unwrap_or_else(|lists| lists);
+ let mut rl = DefaultEditor::new()?;
+
+ // Try to load history
+ let history_file = dirs::cache_dir().map(|d| d.join("uad").join("cli_history.txt"));
+ if let Some(ref path) = history_file {
+ let _ = rl.load_history(path);
+ }
+
+ loop {
+ let readline = rl.readline("uad> ");
+ match readline {
+ Ok(line) => {
+ match handle_repl_line(&line, &mut rl, &target_device, user, user_id, &uad_lists) {
+ Ok(ReplAction::Continue) => {}
+ Ok(ReplAction::Exit) => break,
+ Err(e) => {
+ eprintln!("Error: {}", e);
+ }
+ }
+ }
+ Err(ReadlineError::Interrupted) => {
+ println!("Interrupted (Ctrl-C). Type 'exit' to quit.");
+ continue;
+ }
+ Err(ReadlineError::Eof) => {
+ println!("Goodbye!");
+ break;
+ }
+ Err(err) => {
+ eprintln!("Error: {:?}", err);
+ break;
+ }
+ }
+ }
+
+ // Save history
+ if let Some(ref path) = history_file {
+ if let Some(parent) = path.parent() {
+ let _ = std::fs::create_dir_all(parent);
+ }
+ let _ = rl.save_history(path);
+ }
+
+ Ok(())
+}
+
+/// Handle a single line of REPL input
+fn handle_repl_line(
+ line: &str,
+ rl: &mut DefaultEditor,
+ device: &Phone,
+ user: User,
+ user_id: Option,
+ uad_lists: &HashMap,
+) -> Result> {
+ let line = line.trim();
+ if line.is_empty() {
+ return Ok(ReplAction::Continue);
+ }
+
+ let _ = rl.add_history_entry(line);
+
+ let parts: Vec<&str> = line.split_whitespace().collect();
+ if parts.is_empty() {
+ return Ok(ReplAction::Continue);
+ }
+
+ match parts[0] {
+ "help" => print_repl_help(),
+ "exit" | "quit" => {
+ println!("Goodbye!");
+ return Ok(ReplAction::Exit);
+ }
+ "list" | "ls" => {
+ handle_list_command(&parts[1..], device, user_id, uad_lists)?;
+ }
+ "info" => {
+ handle_info_command(&parts[1..], device, user.id, uad_lists)?;
+ }
+ "uninstall" | "rm" => {
+ handle_state_change_command(
+ &parts[1..],
+ device,
+ user,
+ PackageState::Uninstalled,
+ "Uninstalling",
+ uad_lists,
+ )?;
+ }
+ "enable" | "restore" => {
+ handle_state_change_command(
+ &parts[1..],
+ device,
+ user,
+ PackageState::Enabled,
+ "Enabling",
+ uad_lists,
+ )?;
+ }
+ "disable" => {
+ handle_state_change_command(
+ &parts[1..],
+ device,
+ user,
+ PackageState::Disabled,
+ "Disabling",
+ uad_lists,
+ )?;
+ }
+ "device" => {
+ println!(
+ "Device: {} ({}), Android SDK: {}, User: {}",
+ device.model, device.adb_id, device.android_sdk, user.id
+ );
+ }
+ "clear" => {
+ print!("\x1B[2J\x1B[1;1H");
+ }
+ _ => {
+ eprintln!(
+ "Unknown command: '{}'. Type 'help' for available commands.",
+ parts[0]
+ );
+ }
+ }
+
+ Ok(ReplAction::Continue)
+}
+
+/// Parse REPL arguments into filters
+struct ReplListArgs {
+ state_filter: Option,
+ search_term: Option,
+}
+
+impl ReplListArgs {
+ fn parse(args: &[&str]) -> Result {
+ let mut state_filter = None;
+ let mut search_term = None;
+ let mut i = 0;
+
+ while i < args.len() {
+ match args[i] {
+ "--state" | "-s" => {
+ if i + 1 >= args.len() {
+ return Err("--state requires a value".to_string());
+ }
+ state_filter = match args[i + 1].to_lowercase().as_str() {
+ "enabled" => Some(StateFilter::Enabled),
+ "disabled" => Some(StateFilter::Disabled),
+ "uninstalled" => Some(StateFilter::Uninstalled),
+ "all" => Some(StateFilter::All),
+ _ => return Err(format!("Invalid state: {}", args[i + 1])),
+ };
+ i += 2;
+ }
+ "--search" | "-q" => {
+ if i + 1 >= args.len() {
+ return Err("--search requires a value".to_string());
+ }
+ search_term = Some(args[i + 1].to_string());
+ i += 2;
+ }
+ _ => {
+ return Err(format!("Unknown option: {}", args[i]));
+ }
+ }
+ }
+
+ Ok(Self {
+ state_filter,
+ search_term,
+ })
+ }
+}
+
+/// Handle list command in REPL
+fn handle_list_command(
+ args: &[&str],
+ device: &Phone,
+ user_id: Option,
+ uad_lists: &HashMap,
+) -> Result<(), Box> {
+ let parsed = ReplListArgs::parse(args)?;
+
+ let pm_flag = parsed.state_filter.and_then(StateFilter::to_pm_flag);
+ let system_packages = ACommand::new()
+ .shell(&device.adb_id)
+ .pm()
+ .list_packages_sys(pm_flag, user_id)?;
+
+ let context = PackageListContext {
+ state_filter: parsed.state_filter,
+ removal_filter: None,
+ list_filter: None,
+ search: parsed.search_term,
+ };
+
+ let displayed_count = display_package_list(
+ &system_packages,
+ uad_lists,
+ &device.adb_id,
+ user_id,
+ &context,
+ )?;
+
+ if displayed_count == 0 {
+ println_or_exit!(" No packages found.");
+ } else {
+ println_or_exit!("\nTotal: {} package(s)", displayed_count);
+ }
+
+ Ok(())
+}
+
+/// Handle info command in REPL
+fn handle_info_command(
+ args: &[&str],
+ device: &Phone,
+ user_id: u16,
+ uad_lists: &HashMap,
+) -> Result<(), Box> {
+ if args.is_empty() {
+ eprintln!("Usage: info ");
+ return Ok(());
+ }
+
+ let package = args[0];
+ println!("Package: {}", package);
+
+ if let Some(pkg_info) = uad_lists.get(package) {
+ println!(" List: {}", pkg_info.list);
+ println!(" Removal: {}", pkg_info.removal);
+ println!(" Description: {}", pkg_info.description);
+ } else {
+ println!(" Not found in UAD lists (unlisted package)");
+ }
+
+ let state = get_package_state(&device.adb_id, package, Some(user_id))
+ .ok_or("Package not found on device")?;
+ println!(" State: {}", state);
+
+ Ok(())
+}
+
+/// Handle state change command in REPL
+fn handle_state_change_command(
+ args: &[&str],
+ device: &Phone,
+ user: User,
+ target_state: PackageState,
+ action_name: &str,
+ uad_lists: &HashMap,
+) -> Result<(), Box> {
+ if args.is_empty() {
+ eprintln!(
+ "Usage: {} [package_name...]",
+ action_name.to_lowercase()
+ );
+ return Ok(());
+ }
+
+ for pkg_name in args {
+ process_package_change(pkg_name, device, user, target_state, action_name, uad_lists)?;
+ }
+
+ Ok(())
+}
+
+/// Process state change for a single package in REPL
+fn process_package_change(
+ pkg_name: &str,
+ device: &Phone,
+ user: User,
+ target_state: PackageState,
+ action_name: &str,
+ uad_lists: &HashMap,
+) -> Result<(), Box> {
+ let current_state = get_package_state(&device.adb_id, pkg_name, Some(user.id))
+ .ok_or("Package not found on device")?;
+
+ println!("{} {} (current: {})", action_name, pkg_name, current_state);
+
+ if current_state == target_state {
+ println!(" → Already in target state, skipping");
+ return Ok(());
+ }
+
+ let pkg_info = uad_lists.get(pkg_name);
+ if let Some(info) = pkg_info {
+ if info.removal == Removal::Unsafe {
+ println!(" ⚠ WARNING: This package is marked as UNSAFE to remove!");
+ }
+ }
+
+ let core_pkg = CorePackage {
+ name: pkg_name.to_string(),
+ description: pkg_info.map(|p| p.description.clone()).unwrap_or_default(),
+ removal: pkg_info.map(|p| p.removal).unwrap_or(Removal::Unlisted),
+ state: current_state,
+ list: pkg_info.map(|p| p.list).unwrap_or(UadList::Unlisted),
+ };
+
+ let commands = apply_pkg_state_commands(&core_pkg, target_state, user, device);
+
+ execute_with_fallback(
+ pkg_name,
+ target_state,
+ &core_pkg,
+ user,
+ device,
+ &commands,
+ " ",
+ )
+}
+
+/// Print REPL help message
+fn print_repl_help() {
+ println!("Available commands:");
+ println!(" list [--state ] [--search ]");
+ println!(" List packages with optional filters");
+ println!(" info ");
+ println!(" Show information about a package");
+ println!(" uninstall [package_name...]");
+ println!(" Uninstall one or more packages");
+ println!(" enable [package_name...]");
+ println!(" Enable/restore one or more packages");
+ println!(" disable [package_name...]");
+ println!(" Disable one or more packages");
+ println!(" device");
+ println!(" Show current device information");
+ println!(" clear");
+ println!(" Clear the screen");
+ println!(" help");
+ println!(" Show this help message");
+ println!(" exit, quit");
+ println!(" Exit the interactive mode");
+}
diff --git a/crates/uad-core/Cargo.toml b/crates/uad-core/Cargo.toml
new file mode 100644
index 0000000..f7d3a43
--- /dev/null
+++ b/crates/uad-core/Cargo.toml
@@ -0,0 +1,52 @@
+[package]
+name = "uad-core"
+version.workspace = true
+authors.workspace = true
+license.workspace = true
+homepage.workspace = true
+repository.workspace = true
+readme.workspace = true
+keywords.workspace = true
+categories = ["command-line-utilities"]
+edition.workspace = true
+
+[features]
+default = []
+self-update = ["dep:flate2", "dep:tar"]
+
+[dependencies]
+serde.workspace = true
+serde_json.workspace = true
+log.workspace = true
+chrono.workspace = true
+toml.workspace = true
+dirs.workspace = true
+ureq.workspace = true
+retry.workspace = true
+csv.workspace = true
+flate2 = { workspace = true, optional = true }
+tar = { workspace = true, optional = true }
+
+[target.'cfg(target_os = "windows")'.dependencies]
+win32console.workspace = true
+
+[lints.rust]
+deprecated_safe = "warn"
+
+[lints.clippy]
+undocumented_unsafe_blocks = "forbid"
+exit = "deny"
+panic_in_result_fn = "warn"
+infinite_loop = "warn"
+mem_forget = "warn"
+implicit_clone = "warn"
+format_push_string = "warn"
+large_include_file = "warn"
+shadow_unrelated = "warn"
+struct_field_names = "allow" # annoying
+
+disallowed_types = "deny"
+disallowed_methods = "deny"
+
+allow_attributes_without_reason = "warn"
+pedantic = { level = "warn", priority = -1 }
diff --git a/crates/uad-core/src/adb.rs b/crates/uad-core/src/adb.rs
new file mode 100644
index 0000000..f2335e0
--- /dev/null
+++ b/crates/uad-core/src/adb.rs
@@ -0,0 +1,503 @@
+#![deny(clippy::unwrap_used)]
+
+//! This module is intended to group everything that's "intrinsic" of ADB.
+//!
+//! Following the design philosophy of most of Rust `std`,
+//! `*Command` are intended to be "thin wrappers" (low-overhead abstractions)
+//! around the ADB CLI or `adb_client`
+//! ([in the future](https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/issues/700) ),
+//! which implies:
+//! - no "magic"
+//! - no custom commands
+//! - no chaining ("piping") of existing commands
+//!
+//! This guarantees a 1-to-1 mapping between methods and cmds,
+//! thereby reducing surprises such as:
+//! - Non-atomic operations: consider what happens if a pack changes state
+//! in the middle of listing enabled and disabled packs!
+//! - Non-standard semantics: what would happen if a new ADB version
+//! supports a feature we already defined,
+//! but has _slightly_ different behavior?
+//!
+//! Despite being "low-level", we can still "have cake and eat it too";
+//! After all, what's the point of an abstraction if it doesn't come with goodies?:
+//! We can reserve some artistic license, such as:
+//! - pre-parsing or validanting output, to provide types with invariants
+//! - strongly-typed rather than "stringly-typed" APIs
+//! - nicer IDE support
+//! - compile-time prevention of malformed cmds
+//! - implicit enforcement of a narrow set of operations
+//!
+//! About that last point, if there's ever a need for an ADB feature
+//! which these APIs don't expose,
+//! please, **PLEASE** refrain from falling-back to any `Command`-like API.
+//! Rather, please extend these APIs in a consistent way.
+//!
+//! Thank you! ❤️
+//!
+//! For comprehensive info about ADB,
+//! [see this](https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/master/docs/)
+
+use std::rc::Rc;
+
+#[cfg(target_os = "windows")]
+use std::os::windows::process::CommandExt;
+
+use crate::utils::is_all_w_c;
+use log::{error, info, warn};
+
+/// Convert ADB output bytes to a trimmed UTF-8 string.
+/// Uses lossy conversion to prevent panics on non-UTF8 output from certain OEMs.
+#[must_use]
+pub fn to_trimmed_utf8(v: &[u8]) -> String {
+ String::from_utf8_lossy(v).trim_end().to_string()
+}
+
+#[cfg(debug_assertions)]
+#[must_use]
+fn is_version_triple(s: &str) -> bool {
+ let mut components = s.split('.');
+ for _ in 0..3 {
+ if !components
+ .next()
+ .is_some_and(|comp| comp.as_bytes().iter().all(u8::is_ascii_digit))
+ {
+ return false;
+ }
+ }
+ if components.next().is_some() {
+ return false;
+ }
+ true
+}
+
+/// Builder object for an Android Debug Bridge CLI command,
+/// using the type-state and new-type patterns.
+///
+/// This is not intended to model the entire ADB API.
+/// It only models the subset that concerns UADNG.
+///
+/// [More info here](https://developer.android.com/tools/adb)
+#[derive(Debug)]
+pub struct ACommand(std::process::Command);
+impl ACommand {
+ /// `adb` command builder
+ #[must_use]
+ pub fn new() -> Self {
+ Self(std::process::Command::new("adb"))
+ }
+
+ /// `shell` sub-command builder.
+ ///
+ /// If `device_serial` is empty, it lets ADB choose the default device.
+ #[must_use]
+ pub fn shell>(mut self, device_serial: S) -> ShellCommand {
+ let serial = device_serial.as_ref();
+ if !serial.is_empty() {
+ self.0.args(["-s", serial]);
+ }
+ self.0.arg("shell");
+ ShellCommand(self)
+ }
+
+ /// Header-less list of attached devices (as serials) and their statuses:
+ /// - USB
+ /// - TCP/IP: WIFI, Ethernet, etc...
+ /// - Local emulators
+ ///
+ /// Status can be (but not limited to):
+ /// - "unauthorized"
+ /// - "device"
+ pub fn devices(mut self) -> Result, String> {
+ self.0.arg("devices");
+ Ok(self
+ .run()?
+ .lines()
+ .skip(1) // header
+ .map(|dev_stat| {
+ let tab_idx = dev_stat
+ // OS-specific?
+ .find('\t')
+ // True on Linux,
+ // no matter if ADB is piped or connected to terminal
+ .expect("There must be 1 tab after serial");
+ (
+ // serial
+ dev_stat[..tab_idx].to_string(),
+ // status
+ dev_stat[(tab_idx + 1)..].to_string(),
+ )
+ })
+ .collect())
+ }
+
+ /// `version` sub-command
+ ///
+ /// ## Format
+ /// This is just a sample,
+ /// we don't know which guarantees are stable (yet):
+ /// ```txt
+ /// Android Debug Bridge version 1.0.41
+ /// Version 34.0.5-debian
+ /// Installed as /usr/lib/android-sdk/platform-tools/adb
+ /// Running on Linux 6.12.12-amd64 (x86_64)
+ /// ```
+ ///
+ /// The expected format should be like:
+ /// ```txt
+ /// Android Debug Bridge version ..
+ /// Version ..-
+ /// Installed as /platform-tools/adb[.exe]
+ /// Running on ()
+ /// ```
+ #[expect(clippy::panic_in_result_fn, reason = "Assertions are fine")]
+ pub fn version(mut self) -> Result {
+ self.0.arg("version");
+ let out = self.run()?;
+
+ #[cfg(debug_assertions)]
+ {
+ const ADBV: &str = "Android Debug Bridge version ";
+ const V: &str = "Version ";
+
+ let mut lns = out.lines();
+
+ assert!(
+ lns.next()
+ .is_some_and(|ln| ln.starts_with(ADBV) && is_version_triple(&ln[ADBV.len()..]))
+ );
+ assert!(lns.next().is_some_and(|ln| ln.starts_with(V)
+ && is_version_triple(&ln[V.len()..ln.find('-').unwrap_or(ln.len())])));
+ // missing test for valid path
+ assert!(lns.next().is_some_and(|ln| ln.starts_with("Installed as ")
+ && (ln.ends_with("adb") || ln.ends_with("adb.exe"))));
+ // missing test for x86/ARM (both 64b)
+ assert!(lns.next().is_some_and(|ln| ln.starts_with("Running on ")));
+ if lns.next().is_some() {
+ unreachable!("Expected < 5 lines")
+ }
+ }
+
+ Ok(out)
+ }
+
+ /// General executor
+ fn run(self) -> Result {
+ let mut cmd = self.0;
+ #[cfg(target_os = "windows")]
+ let cmd = cmd.creation_flags(0x0800_0000); // do not open a cmd window
+
+ info!(
+ "Ran command: adb {}",
+ cmd.get_args()
+ .map(|s| s.to_str().unwrap_or_else(|| unreachable!()))
+ .collect::>()
+ .join(" ")
+ );
+ match cmd.output() {
+ Err(e) => {
+ error!("ADB: {e}");
+ Err("Cannot run ADB, likely not found".to_string())
+ }
+ Ok(o) => {
+ let stdout = to_trimmed_utf8(&o.stdout);
+ if o.status.success() {
+ Ok(stdout)
+ } else {
+ let stderr = to_trimmed_utf8(&o.stderr);
+ // ADB does really weird things:
+ // Some errors are not redirected to `stderr`
+ let err = if stdout.is_empty() { stderr } else { stdout };
+ Err(err)
+ }
+ }
+ }
+ }
+}
+
+impl Default for ACommand {
+ fn default() -> Self {
+ Self::new()
+ }
+}
+
+/// Builder object for a command that runs on the device's default `sh` implementation.
+/// Typically MKSH, but could be Ash.
+///
+/// [More info](https://chromium.googlesource.com/aosp/platform/system/core/+/refs/heads/upstream/shell_and_utilities).
+#[derive(Debug)]
+pub struct ShellCommand(ACommand);
+impl ShellCommand {
+ /// `pm` command builder
+ pub fn pm(mut self) -> PmCommand {
+ self.0.0.arg("pm");
+ PmCommand(self)
+ }
+ /// Query a device property value, by its key.
+ /// These can be of any type:
+ /// - `boolean`
+ /// - `int`
+ /// - chars
+ /// - etc...
+ ///
+ /// So to avoid lossy conversions, we return strs
+ pub fn getprop(mut self, key: &str) -> Result {
+ self.0.0.args(["getprop", key]);
+ self.0.run()
+ }
+ /// Reboots device
+ pub fn reboot(mut self) -> Result {
+ self.0.0.arg("reboot");
+ self.0.run()
+ }
+
+ /// Execute an arbitrary shell action string on the device's default shell.
+ /// The action string is passed as a single argument to `adb shell` and
+ /// interpreted by the remote shell (which splits on spaces).
+ pub fn raw(mut self, action: &str) -> Result {
+ self.0.0.arg(action);
+ self.0.run()
+ }
+}
+
+#[must_use]
+pub const fn is_pkg_component(s: &[u8]) -> bool {
+ if s.is_empty() {
+ return false;
+ }
+ s[0].is_ascii_alphabetic()
+ && if s.len() > 1 {
+ is_all_w_c(s.split_at(1).1)
+ } else {
+ true
+ }
+}
+
+/// String with the invariant of being a valid package-name.
+/// See [`PackageId::new`] for validation details.
+#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+pub struct PackageId(Rc);
+impl PackageId {
+ /// Creates a package-ID if it's `"android"` or valid according to:
+ /// -
+ /// -
+ #[must_use]
+ pub fn new(p_id: &str) -> Option {
+ if p_id == "android" {
+ return Some(Self(p_id.into()));
+ }
+ let mut components = p_id.split('.');
+ for _ in 0..2 {
+ if !components
+ .next()
+ .is_some_and(|comp| is_pkg_component(comp.as_bytes()))
+ {
+ return None;
+ }
+ }
+ if components.all(|comp| is_pkg_component(comp.as_bytes())) {
+ Some(Self(p_id.into()))
+ } else {
+ None
+ }
+ }
+}
+
+/// `pm list packages` flag/state/type
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum PmListPacksFlag {
+ /// `-u`, not to be confused with `-a`
+ IncludeUninstalled,
+ /// `-e`
+ OnlyEnabled,
+ /// `-d`
+ OnlyDisabled,
+}
+impl PmListPacksFlag {
+ // is there a trait for this?
+ fn to_str(self) -> &'static str {
+ match self {
+ Self::IncludeUninstalled => "-u",
+ Self::OnlyEnabled => "-e",
+ Self::OnlyDisabled => "-d",
+ }
+ }
+}
+#[expect(clippy::to_string_trait_impl, reason = "This is not user-facing")]
+impl ToString for PmListPacksFlag {
+ fn to_string(&self) -> String {
+ self.to_str().to_string()
+ }
+}
+
+const PACK_PREFIX: &str = "package:";
+
+pub const PM_CLEAR_PACK: &str = "pm clear";
+
+/// Builder object for an Android Package Manager command.
+///
+#[derive(Debug)]
+#[must_use]
+pub struct PmCommand(ShellCommand);
+impl PmCommand {
+ /// `list packages -s` sub-command, [`PACK_PREFIX`] stripped from each element.
+ ///
+ /// `Ok` variant:
+ /// - isn't 100% guaranteed to contain valid pack-IDs
+ /// but you can assume it does (except in `unsafe {}` blocks)
+ /// - isn't sorted
+ /// - duplicates never _seem_ to happen, but don't assume uniqueness
+ pub fn list_packages_sys(
+ mut self,
+ f: Option,
+ user_id: Option,
+ ) -> Result, String> {
+ let cmd = &mut self.0.0.0;
+
+ cmd.args(["list", "packages", "-s"]);
+ if let Some(s) = f {
+ cmd.arg(s.to_str());
+ }
+ if let Some(u) = user_id {
+ cmd.arg("--user");
+ cmd.arg(u.to_string());
+ }
+
+ self.0.0.run().map(|pack_ls| {
+ pack_ls
+ .lines()
+ .filter_map(|p_ln| {
+ debug_assert!(p_ln.starts_with(PACK_PREFIX));
+ let p = &p_ln[PACK_PREFIX.len()..];
+ if PackageId::new(p).is_some() {
+ Some(String::from(p))
+ } else {
+ warn!("skipping nonstandard package name: {p:?}");
+ None
+ }
+ })
+ .collect()
+ })
+ }
+
+ /// `list users` sub-command, deserialized/parsed.
+ ///
+ /// -
+ /// -
+ pub fn list_users(mut self) -> Result, String> {
+ self.0.0.0.args(["list", "users"]);
+ Ok(self
+ .0
+ .0
+ .run()?
+ .lines()
+ .skip(1) // omit header
+ .map(|ln| {
+ // this could be optimized by making more API-stability assumptions
+ let ln = ln.trim_ascii_start();
+ let ln = ln.strip_prefix("UserInfo").unwrap_or(ln).trim_ascii_start();
+ let ln = ln.strip_prefix('{').unwrap_or(ln).trim_ascii();
+ //let run;
+ let ln = if let Some(l) = ln.strip_suffix("running") {
+ //run = true;
+ l.trim_ascii_end()
+ } else {
+ //run = false;
+ ln
+ };
+ let ln = ln.strip_suffix('}').unwrap_or(ln).trim_ascii_end();
+ // https://android.googlesource.com/platform/frameworks/base/+/refs/heads/main/core/java/android/content/pm/UserInfo.java
+ // The format looks stable today, but google may change it in future Android versions
+ // (and very old Androids might differ). Keep parsing defensive.
+ // Expected shape: "UserInfo{::}[ running]"
+
+ let mut comps = ln.split(':');
+
+ let id = comps
+ .next()
+ .expect("There must be at least 1 ':'-separated component")
+ .parse()
+ .expect("string assumed to be UID numeral");
+ //let name = comps
+ // .next()
+ // .expect("There must be at least 2 ':'-separated components. 2nd is user-name");
+ //let flags = u32::from_str_radix(
+ // comps.next().expect(
+ // "There must be at least 3 ':'-separated components. 3rd is user bit-flags",
+ // ),
+ // 16,
+ //)
+ //.expect("string assumed to be hexadecimal bit-flags");
+ UserInfo {
+ id,
+ //name: name.into(),
+ //flags,
+ //running: run,
+ }
+ })
+ .collect())
+ }
+}
+
+/// Mirror of AOSP `UserInfo` Java Class, with an extra field
+#[derive(Debug, Clone)]
+pub struct UserInfo {
+ id: u16,
+ //name: Box,
+ //flags: u32,
+ //running: bool,
+}
+impl UserInfo {
+ #[must_use]
+ pub const fn get_id(&self) -> u16 {
+ self.id
+ }
+ /*
+ /// Check if the user was logged-in at the time `pm list users` was invoked
+ #[must_use]
+ #[allow(dead_code, reason = "Currently unused by UI; kept for future features")]
+ pub const fn was_running(&self) -> bool {
+ self.running
+ }
+ */
+}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ #[test]
+ fn invalid_pack_ids() {
+ for p_id in [
+ "",
+ " ",
+ ".",
+ "nodots",
+ "com..example",
+ "net.hello.",
+ "org.0example",
+ "org._foobar",
+ "the.🎂.is.a.lie",
+ "EXCLAMATION!!!!",
+ ] {
+ assert_eq!(PackageId::new(p_id), None);
+ }
+ }
+
+ #[test]
+ fn valid_pack_ids() {
+ for p_id in [
+ "A.a",
+ "x.X",
+ "org.example",
+ "net.hello",
+ "uwu.owo",
+ "Am0Gu5.Zuz",
+ "net.net.net.net.net.net.net.net.net.net.net",
+ "com.github.w1nst0n",
+ "this_.String_.is_.not_.real_",
+ ] {
+ assert_ne!(PackageId::new(p_id), None);
+ }
+ }
+}
diff --git a/crates/uad-core/src/config.rs b/crates/uad-core/src/config.rs
new file mode 100644
index 0000000..5c41d78
--- /dev/null
+++ b/crates/uad-core/src/config.rs
@@ -0,0 +1,150 @@
+use crate::CACHE_DIR;
+use crate::CONFIG_DIR;
+use crate::sync::User;
+use crate::utils::DisplayablePath;
+use log::error;
+use serde::{Deserialize, Serialize};
+use std::fs;
+use std::path::PathBuf;
+use std::sync::LazyLock;
+
+const DEFAULT_THEME: &str = "Auto (follow system theme)";
+
+#[derive(Default, Debug, Serialize, Deserialize, Clone)]
+pub struct Config {
+ pub general: GeneralSettings,
+ #[serde(skip_serializing_if = "Vec::is_empty", default = "Vec::new")]
+ pub devices: Vec,
+}
+
+#[derive(Debug, Serialize, Deserialize, Clone)]
+pub struct GeneralSettings {
+ pub theme: String,
+ pub expert_mode: bool,
+ pub backup_folder: PathBuf,
+}
+
+#[derive(Default, Debug, Clone)]
+pub struct BackupSettings {
+ pub backups: Vec,
+ pub selected: Option,
+ pub users: Vec,
+ pub selected_user: Option,
+ pub backup_state: String,
+}
+
+#[derive(Debug, Serialize, Deserialize, Clone, Default)]
+pub struct DeviceSettings {
+ /// Unique serial identifier
+ pub device_id: String,
+ pub disable_mode: bool, // should be `enum RemovalMode`
+ pub multi_user_mode: bool,
+ #[serde(skip)]
+ pub backup: BackupSettings,
+}
+
+impl Default for GeneralSettings {
+ fn default() -> Self {
+ Self {
+ theme: DEFAULT_THEME.to_string(),
+ expert_mode: false,
+ backup_folder: CACHE_DIR.join("backups"),
+ }
+ }
+}
+
+static CONFIG_FILE: LazyLock = LazyLock::new(|| CONFIG_DIR.join("config.toml"));
+
+impl Config {
+ pub fn save_device_settings(
+ &mut self,
+ device_settings: DeviceSettings,
+ general: GeneralSettings,
+ ) {
+ if let Some(device) = self
+ .devices
+ .iter_mut()
+ .find(|x| x.device_id == device_settings.device_id)
+ {
+ *device = device_settings;
+ } else {
+ self.devices.push(device_settings);
+ }
+ self.general = general;
+ let toml = toml::to_string(&self).unwrap();
+ fs::write(&*CONFIG_FILE, toml).expect("Could not write config file to disk!");
+ }
+
+ #[must_use]
+ pub fn load_configuration_file() -> Self {
+ match fs::read_to_string(&*CONFIG_FILE) {
+ Ok(s) => match toml::from_str(&s) {
+ Ok(config) => return config,
+ Err(e) => error!("Invalid config file: `{e}`"),
+ },
+ Err(e) => error!("Failed to read config file: `{e}`"),
+ }
+ error!("Restoring default config file");
+ let toml = toml::to_string(&Self::default()).unwrap();
+ fs::write(&*CONFIG_FILE, toml).expect("Could not write config file to disk!");
+ Self::default()
+ }
+}
+
+#[cfg(test)]
+mod tests {
+ //! Unit tests
+
+ use super::*;
+ use std::path::Path;
+
+ // create a clean default config file for testing
+ fn create_default_config_file() {
+ let toml = toml::to_string(&Config::default()).unwrap();
+ fs::write(&*CONFIG_FILE, toml).expect("Could not write config file to disk!");
+ }
+
+ #[test]
+ fn test_create_default_config_file() {
+ create_default_config_file();
+ assert!(CONFIG_FILE.exists());
+ }
+
+ #[test]
+ fn test_load_configuration_file() {
+ create_default_config_file();
+ let config = Config::load_configuration_file();
+ // non-deterministic
+ //assert_eq!(config.devices.len(), 0);
+ assert_eq!(config.general.theme, DEFAULT_THEME);
+ assert!(!config.general.expert_mode);
+ assert_eq!(config.general.backup_folder, CACHE_DIR.join("backups"));
+ }
+
+ // non-deterministic
+ /*
+ #[test]
+ fn test_save_changes() {
+ let mut settings = Settings::default();
+ let device_id = "test_device".to_string();
+ settings.device.device_id = device_id.clone();
+ Config::save_changes(&settings, &device_id);
+ let config = Config::load_configuration_file();
+ assert_eq!(config.devices[0].device_id, device_id);
+ }
+ */
+
+ #[test]
+ fn test_default_config() {
+ let config = Config::default();
+ assert_eq!(config.devices.len(), 0);
+ assert_eq!(config.general.theme, DEFAULT_THEME);
+ assert!(!config.general.expert_mode);
+ assert_eq!(config.general.backup_folder, CACHE_DIR.join("backups"));
+ }
+
+ #[test]
+ fn test_config_file_path() {
+ assert_eq!(&*CONFIG_FILE, Path::new(&*CONFIG_DIR.join("config.toml")));
+ }
+}
diff --git a/crates/uad-core/src/lib.rs b/crates/uad-core/src/lib.rs
new file mode 100644
index 0000000..be3e5b4
--- /dev/null
+++ b/crates/uad-core/src/lib.rs
@@ -0,0 +1,23 @@
+#![allow(
+ clippy::missing_panics_doc,
+ clippy::missing_errors_doc,
+ clippy::collapsible_if,
+ clippy::uninlined_format_args,
+ clippy::result_unit_err,
+ reason = "Doc+style pedantic lints are out-of-scope for this pass"
+)]
+
+pub mod adb;
+pub mod config;
+pub mod save;
+pub mod sync;
+pub mod uad_lists;
+pub mod update;
+pub mod utils;
+
+use std::path::PathBuf;
+use std::sync::LazyLock;
+pub static CONFIG_DIR: LazyLock =
+ LazyLock::new(|| utils::setup_uad_dir(&dirs::config_dir().expect("Can't detect config dir")));
+pub static CACHE_DIR: LazyLock =
+ LazyLock::new(|| utils::setup_uad_dir(&dirs::cache_dir().expect("Can't detect cache dir")));
diff --git a/src/core/save.rs b/crates/uad-core/src/save.rs
similarity index 64%
rename from src/core/save.rs
rename to crates/uad-core/src/save.rs
index 63add5e..8c1db07 100644
--- a/src/core/save.rs
+++ b/crates/uad-core/src/save.rs
@@ -1,15 +1,12 @@
-use crate::core::config::{Config, DeviceSettings};
-use crate::core::sync::{apply_pkg_state_commands, CorePackage, Phone, User};
-use crate::core::utils::DisplayablePath;
-use crate::gui::widgets::package_row::PackageRow;
-use crate::CACHE_DIR;
+use crate::config::{Config, DeviceSettings};
+use crate::sync::{CorePackage, Phone, User, apply_pkg_state_commands};
+use crate::utils::DisplayablePath;
+use log::{error, info, warn};
use serde::{Deserialize, Serialize};
-use static_init::dynamic;
-use std::fs;
-use std::path::{Path, PathBuf};
-
-#[dynamic]
-pub static BACKUP_DIR: PathBuf = CACHE_DIR.join("backups");
+use std::{
+ fs,
+ path::{Path, PathBuf},
+};
#[derive(Default, Deserialize, Serialize, Debug, Clone, PartialEq, Eq)]
pub struct PhoneBackup {
@@ -24,10 +21,10 @@ pub struct UserBackup {
}
/// Backup all `Uninstalled` and `Disabled` packages
-pub async fn backup_phone(
+pub fn backup_phone(
users: Vec,
device_id: String,
- phone_packages: Vec>,
+ phone_packages: &[Vec],
) -> Result {
let mut backup = PhoneBackup {
device_id: device_id.clone(),
@@ -40,11 +37,8 @@ pub async fn backup_phone(
..UserBackup::default()
};
- for p in phone_packages[u.index].clone() {
- user_backup.packages.push(CorePackage {
- name: p.name.clone(),
- state: p.state,
- });
+ for p in phone_packages[u.index].iter().cloned() {
+ user_backup.packages.push(p);
}
backup.users.push(user_backup);
}
@@ -55,9 +49,9 @@ pub async fn backup_phone(
let backup_path = &*backup_dir.join(device_id);
if let Err(e) = fs::create_dir_all(backup_path) {
- error!("BACKUP: could not create backup dir: {}", e);
+ error!("BACKUP: could not create backup dir: {e}");
return Err(e.to_string());
- };
+ }
let backup_filename =
format!("{}.json", chrono::Local::now().format("%Y-%m-%d_%H-%M-%S"));
@@ -72,7 +66,6 @@ pub async fn backup_phone(
}
pub fn list_available_backups(dir: &Path) -> Vec {
- #[allow(clippy::option_if_let_else)]
match fs::read_dir(dir) {
Ok(files) => files
.filter_map(Result::ok)
@@ -82,24 +75,21 @@ pub fn list_available_backups(dir: &Path) -> Vec {
}
}
+#[must_use]
pub fn list_available_backup_user(backup: DisplayablePath) -> Vec {
match fs::read_to_string(backup.path) {
- Ok(data) => {
- let phone_backup: PhoneBackup =
- serde_json::from_str(&data).expect("Unable to parse backup file");
-
- let mut users = vec![];
- for u in phone_backup.users {
- users.push(User {
- id: u.id,
- index: 0,
- protected: false,
- });
- }
- users
- }
+ Ok(data) => serde_json::from_str::(&data)
+ .expect("Unable to parse backup file")
+ .users
+ .into_iter()
+ .map(|u| User {
+ id: u.id,
+ index: 0,
+ protected: false,
+ })
+ .collect(),
Err(e) => {
- error!("[BACKUP]: Selected backup file not found: {}", e);
+ error!("[BACKUP]: Selected backup file not found: {e}");
vec![]
}
}
@@ -107,15 +97,22 @@ pub fn list_available_backup_user(backup: DisplayablePath) -> Vec {
#[derive(Debug)]
pub struct BackupPackage {
+ pub i_user: usize,
pub index: usize,
pub commands: Vec,
}
+#[derive(Debug)]
+pub struct RestoreResult {
+ pub packages: Vec,
+ pub skipped_count: usize,
+}
+
pub fn restore_backup(
selected_device: &Phone,
- packages: &[Vec],
+ packages: &[Vec],
settings: &DeviceSettings,
-) -> Result, String> {
+) -> Result {
match fs::read_to_string(
settings
.backup
@@ -130,30 +127,31 @@ pub fn restore_backup(
serde_json::from_str(&data).expect("Unable to parse backup file");
let mut commands = vec![];
+ let mut skipped_packages = 0;
for u in phone_backup.users {
- let index = match selected_device.user_list.iter().find(|x| x.id == u.id) {
+ let i_user = match selected_device.user_list.iter().find(|x| x.id == u.id) {
Some(i) => i.index,
None => return Err(format!("user {} doesn't exist", u.id)),
};
for (i, backup_package) in u.packages.iter().enumerate() {
- let package: CorePackage;
- match packages[index]
+ let package: CorePackage = if let Some(p) = packages[i_user]
.iter()
.find(|x| x.name == backup_package.name)
{
- Some(p) => package = p.into(),
- None => {
- return Err(format!(
- "{} not found for user {}",
- backup_package.name, u.id
- ))
- }
- }
+ p.clone()
+ } else {
+ skipped_packages += 1;
+ warn!(
+ "{} not found for user {} - skipping package during restore",
+ backup_package.name, u.id
+ );
+ continue;
+ };
let p_commands = apply_pkg_state_commands(
&package,
backup_package.state,
- &settings
+ settings
.backup
.selected_user
.ok_or("field should be Some type")?,
@@ -161,19 +159,29 @@ pub fn restore_backup(
);
if !p_commands.is_empty() {
commands.push(BackupPackage {
+ i_user,
index: i,
commands: p_commands,
});
}
}
}
+ if skipped_packages > 0 {
+ info!(
+ "Restore completed with {skipped_packages} packages skipped (not found on device)"
+ );
+ }
if !commands.is_empty() {
commands.push(BackupPackage {
+ i_user: 0,
index: 0,
commands: vec![],
});
}
- Ok(commands)
+ Ok(RestoreResult {
+ packages: commands,
+ skipped_count: skipped_packages,
+ })
}
Err(e) => Err(e.to_string()),
}
diff --git a/crates/uad-core/src/sync.rs b/crates/uad-core/src/sync.rs
new file mode 100644
index 0000000..f90b6ee
--- /dev/null
+++ b/crates/uad-core/src/sync.rs
@@ -0,0 +1,663 @@
+use crate::{
+ adb::{ACommand as AdbCommand, PM_CLEAR_PACK, PackageId},
+ uad_lists::PackageState,
+};
+use log::{error, info};
+use retry::{OperationResult, delay::Fixed, retry};
+use serde::{Deserialize, Serialize};
+
+/// An Android device, typically a phone
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub struct Phone {
+ /// Non-market name
+ pub model: String, // could be `Copy`
+ /// Android API level version
+ pub android_sdk: u8,
+ /// In theory, `len < u16::MAX` _should_ always be `true`.
+ /// In practice, `len <= u8::MAX`.
+ pub user_list: Vec,
+ /// Unique serial identifier
+ pub adb_id: String, // could be `Copy`
+}
+
+impl Default for Phone {
+ fn default() -> Self {
+ Self {
+ model: "fetching devices...".to_string(),
+ android_sdk: 0,
+ user_list: vec![],
+ adb_id: String::default(),
+ }
+ }
+}
+
+impl std::fmt::Display for Phone {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ write!(f, "{}", self.model)
+ }
+}
+
+/// `UserInfo` but relevant to UAD
+#[derive(Default, Debug, Clone, Copy, PartialEq, Eq)]
+pub struct User {
+ pub id: u16,
+ pub index: usize,
+ pub protected: bool,
+}
+
+impl std::fmt::Display for User {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ write!(f, "user {}", self.id)
+ }
+}
+
+/// An enum to contain different variants for errors yielded by ADB.
+#[derive(Debug, Clone)]
+pub enum AdbError {
+ Generic(String),
+}
+
+/// Run an arbitrary shell action via the typed ADB wrapper.
+/// This replaces the deprecated `adb_shell_command`.
+///
+/// If `serial` is empty, it lets ADB choose the default device.
+pub fn run_adb_shell_action>(
+ device_serial: S,
+ action: &str,
+) -> Result {
+ let serial = device_serial.as_ref();
+
+ match AdbCommand::new().shell(serial).raw(action) {
+ Ok(o) => {
+ if ["Error", "Failure"].iter().any(|&e| o.contains(e)) {
+ let friendly_msg = make_friendly_error_message(&o, action);
+ return Err(AdbError::Generic(friendly_msg));
+ }
+ info!("{action} -> {o}");
+ Ok(o)
+ }
+ Err(err) => {
+ if !err.contains("[not installed for") {
+ let friendly_msg = make_friendly_error_message(&err, action);
+ return Err(AdbError::Generic(friendly_msg));
+ }
+ Err(AdbError::Generic(err))
+ }
+ }
+}
+
+/// Convert common OEM-specific ADB error messages into user-friendly explanations.
+fn make_friendly_error_message(error_output: &str, action: &str) -> String {
+ // Common Samsung errors
+ if error_output.contains("DELETE_FAILED_USER_RESTRICTED") {
+ return format!(
+ "Cannot uninstall: This package is restricted by the device manufacturer (Samsung Knox or similar).\n\
+ Error: {error_output}\n\
+ Tip: Try disabling the package instead, or check device settings for Knox/security restrictions."
+ );
+ }
+
+ if error_output.contains("NOT_INSTALLED_FOR_USER") {
+ return format!(
+ "Package is not installed for the current user.\n\
+ Error: {error_output}\n\
+ Tip: The package may be installed for a different user profile or work profile."
+ );
+ }
+
+ // Empty package name error
+ if error_output.contains("Shell cannot change component state for null") {
+ return format!(
+ "Invalid package: Empty package name detected.\n\
+ Error: {error_output}\n\
+ Tip: Please refresh the package list and try again."
+ );
+ }
+
+ // Generic permission errors
+ if error_output.contains("Permission denied")
+ || error_output.contains("INSTALL_FAILED_PERMISSION_MODEL_DOWNGRADE")
+ {
+ return format!(
+ "Permission denied: Insufficient privileges to perform this action.\n\
+ Error: {error_output}\n\
+ Tip: This may require root access or the package is protected by the system."
+ );
+ }
+
+ // Work profile / managed device errors
+ if error_output.contains("DELETE_FAILED_DEVICE_POLICY_MANAGER") {
+ return format!(
+ "Cannot modify: Package is managed by device policy (MDM/EMM).\n\
+ Error: {error_output}\n\
+ Tip: Contact your IT administrator if this is a work device."
+ );
+ }
+
+ // Generic failure with context
+ format!("{action} -> {error_output}")
+}
+
+/// If `None`, returns an empty String, not " --user 0"
+#[must_use]
+pub fn user_flag(user_id: Option) -> String {
+ user_id
+ .map(|user| format!(" --user {}", user.id))
+ .unwrap_or_default()
+}
+
+// Minimum information for processing adb commands
+#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+pub struct CorePackage {
+ pub name: String,
+ pub description: String,
+ #[serde(default)]
+ pub removal: crate::uad_lists::Removal,
+ #[serde(default)]
+ pub state: PackageState,
+ #[serde(default)]
+ pub list: crate::uad_lists::UadList,
+}
+
+#[must_use]
+pub fn apply_pkg_state_commands(
+ package: &CorePackage,
+ wanted_state: PackageState,
+ selected_user: User,
+ phone: &Phone,
+) -> Vec {
+ // https://github.com/Universal-Debloater-Alliance/universal-android-debloater/wiki/ADB-reference
+ // ALWAYS PUT THE COMMAND THAT CHANGES THE PACKAGE STATE FIRST!
+ let commands = match wanted_state {
+ PackageState::Enabled => match package.state {
+ PackageState::Disabled => vec!["pm enable"],
+ PackageState::Uninstalled => match phone.android_sdk {
+ i if i >= 23 => vec!["cmd package install-existing"],
+ 21 | 22 => vec!["pm unhide"],
+ 19 | 20 => vec!["pm unblock", PM_CLEAR_PACK],
+ _ => unreachable!("already prevented by the GUI"),
+ },
+ _ => vec![],
+ },
+ PackageState::Disabled => match package.state {
+ PackageState::Uninstalled | PackageState::Enabled => {
+ if supports_disabling(phone) {
+ vec!["pm disable-user", "am force-stop", PM_CLEAR_PACK]
+ } else {
+ vec![]
+ }
+ }
+ _ => vec![],
+ },
+ PackageState::Uninstalled => match package.state {
+ PackageState::Enabled | PackageState::Disabled => match phone.android_sdk {
+ sdk if sdk >= 23 => vec!["pm uninstall"], // > Marshmallow (6.0)
+ 21 | 22 => vec!["pm hide", PM_CLEAR_PACK], // Lollipop (5.x)
+ _ => vec!["pm block", PM_CLEAR_PACK], // Disable mode is unavailable on older devices because the specific ADB commands need root
+ },
+ _ => vec![],
+ },
+ PackageState::All => vec![],
+ }; // this should be a `tinyvec`, as `len <= 4`
+
+ let user = supports_multi_user(phone).then_some(selected_user);
+ request_builder(&commands, &package.name, user)
+}
+
+/// Build a command request to be sent via ADB to a device.
+/// `commands` accepts one or more ADB shell commands
+/// which act on a common `package` and `user`.
+#[must_use]
+pub fn request_builder(commands: &[&str], package: &str, user: Option) -> Vec {
+ // Defense-in-depth: `package` is interpolated verbatim into a device-shell
+ // action, so refuse any invalid name/ID. Every current caller already
+ // reconciles the name against the live device package list before reaching
+ // here, so this rejects nothing legitimate — it just keeps the no-injection
+ // guarantee local to the sink instead of relying on each caller to sanitise.
+ // Fail closed: emit no command for a malformed name rather than an injectable
+ // device-shell string.
+ if PackageId::new(package).is_none() {
+ error!("request_builder: refusing invalid package name: {package:?}");
+ return Vec::new();
+ }
+ let maybe_user_flag = user_flag(user);
+ commands
+ .iter()
+ .map(|c| format!("{c}{maybe_user_flag} {package}"))
+ .collect()
+}
+
+/// Get the model by querying the `ro.product.model` property.
+///
+/// If `serial` is empty, it lets ADB choose the default device.
+#[must_use]
+pub fn get_device_model(serial: &str) -> String {
+ AdbCommand::new()
+ .shell(serial)
+ .getprop("ro.product.model")
+ .unwrap_or_else(|err| {
+ eprintln!("ERROR: {err}");
+ error!("{err}");
+ if err.contains("adb: no devices/emulators found") {
+ "no devices/emulators found".to_string()
+ } else {
+ err
+ }
+ })
+}
+
+/// Get the brand by querying the `ro.product.brand` property.
+///
+/// If `serial` is empty, it lets ADB choose the default device.
+#[must_use]
+pub fn get_device_brand(serial: &str) -> String {
+ AdbCommand::new()
+ .shell(serial)
+ .getprop("ro.product.brand")
+ // `trim` is just-in-case
+ .map(|s| s.trim().to_string())
+ .unwrap_or_default()
+}
+
+/// Get Android SDK version by querying the
+// `ro.build.version.sdk` property or defaulting to 0.
+///
+/// If `device_serial` is empty, it lets ADB choose the default device.
+#[must_use]
+pub fn get_android_sdk(device_serial: &str) -> u8 {
+ AdbCommand::new()
+ .shell(device_serial)
+ .getprop("ro.build.version.sdk")
+ .map_or(0, |sdk| {
+ sdk.parse().expect("SDK version numeral must be valid")
+ })
+}
+
+/// Capture the current state of a package across all non-protected users.
+/// This is used to detect cross-user behavior by comparing before and after states.
+///
+/// Only includes users where the package exists (Some state). Users where the package
+/// doesn't exist (None) are not tracked.
+#[must_use]
+pub fn capture_cross_user_states(
+ package_name: &str,
+ device_serial: &str,
+ target_user_id: u16,
+ phone: &Phone,
+) -> Vec<(u16, PackageState)> {
+ phone
+ .user_list
+ .iter()
+ .filter(|u| !u.protected && u.id != target_user_id)
+ .filter_map(|u| {
+ verify_package_state(package_name, device_serial, Some(u.id)).map(|state| (u.id, state))
+ })
+ .collect()
+}
+
+/// Detect cross-user behavior and return appropriate notification message.
+/// This handles unexpected cross-user behavior:
+/// - Case A: Uninstall → Restore (package appears on other users)
+/// - Case B: Uninstall → Uninstall (package disappears from other users that previously had it)
+/// - Case C: Restore → Restore (package appears on other users)
+#[must_use]
+pub fn detect_cross_user_behavior(
+ package_name: &str,
+ device_serial: &str,
+ target_user_id: u16,
+ wanted_state: PackageState,
+ actual_state: PackageState,
+ phone: &Phone,
+ before_states: &[(u16, PackageState)],
+) -> Option {
+ // Only check if operation was successful on target user
+ if actual_state != wanted_state {
+ return None;
+ }
+
+ // Only check if we have multiple users
+ if phone.user_list.len() < 2 {
+ return None;
+ }
+
+ let after_states =
+ check_cross_user_package_existence(package_name, device_serial, target_user_id, phone);
+
+ match wanted_state {
+ PackageState::Uninstalled => {
+ if after_states.is_empty() {
+ // Case B: Uninstall → Uninstall (check if all users lost package)
+ let affected_users: Vec<_> = before_states
+ .iter()
+ .filter(|(uid, before_state)| {
+ // Only flag if the package was installed/enabled/disabled before
+ *before_state != PackageState::Uninstalled
+ // And is NOT in after_states (doesn't exist in usable state anymore)
+ && !after_states.iter().any(|(after_uid, _)| after_uid == uid)
+ })
+ .map(|(uid, _)| uid)
+ .collect();
+
+ if affected_users.is_empty() {
+ None
+ } else {
+ let user_list = affected_users
+ .iter()
+ .map(|uid| format!("user {uid}"))
+ .collect::>()
+ .join(", ");
+
+ Some(format!(
+ "Detected cross-user uninstall: package was also uninstalled from {user_list} after uninstalling from user {target_user_id}"
+ ))
+ }
+ } else {
+ // Case A: Uninstall → Restore (package appears on other users)
+ let user_list = after_states
+ .iter()
+ .map(|(uid, state)| format!("user {uid} ({state:?})"))
+ .collect::>()
+ .join(", ");
+
+ Some(format!(
+ "Detected cross-user restoration: package exists on {user_list} after uninstalling from user {target_user_id}"
+ ))
+ }
+ }
+ PackageState::Enabled | PackageState::Disabled => {
+ // Case C: Restore → Restore (package appears on other users)
+
+ // Check if a user didn't have the package before (not tracked or package didn't exist).
+ // Detects packages that appear on users where they didn't exist previously (OEM cross-user restoration).
+ let was_package_absent_before = |uid: &u16| {
+ before_states
+ .iter()
+ .find(|(before_uid, _)| before_uid == uid)
+ .is_none_or(|(_, before_state)| *before_state == PackageState::Uninstalled)
+ };
+
+ let newly_appeared: Vec<_> = after_states
+ .iter()
+ .filter(|(uid, _after_state)| was_package_absent_before(uid))
+ .collect();
+
+ if newly_appeared.is_empty() {
+ None
+ } else {
+ let user_list = newly_appeared
+ .iter()
+ .map(|(uid, state)| format!("user {uid} ({state:?})"))
+ .collect::>()
+ .join(", ");
+
+ Some(format!(
+ "Detected cross-user restoration: package exists on {user_list} after {} from user {target_user_id}",
+ if wanted_state == PackageState::Enabled {
+ "enabling"
+ } else {
+ "disabling"
+ }
+ ))
+ }
+ }
+ PackageState::All => None,
+ }
+}
+
+#[must_use]
+pub const fn supports_disabling(dev: &Phone) -> bool {
+ // >= Marshmallow (6.0)
+ dev.android_sdk >= 23
+}
+
+/// Check if it might support multi-user mode,
+/// by simply comparing SDK version.
+/// `true` isn't reliable, you can only trust `false`.
+///
+/// See:
+/// -
+/// -
+#[must_use]
+pub const fn supports_multi_user(dev: &Phone) -> bool {
+ // >= Lollipop (5.0)
+ dev.android_sdk >= 21
+}
+
+/// Check if a `user_id` is protected on a device by trying
+/// to list associated packages.
+///
+/// If `device_serial` is empty, it lets ADB choose the default device.
+pub fn is_protected_user>(user_id: u16, device_serial: S) -> bool {
+ AdbCommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(None, Some(user_id))
+ .is_err()
+}
+
+#[must_use]
+pub fn list_users_idx_prot(device_serial: &str) -> Vec {
+ AdbCommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_users()
+ .map(|out| {
+ out.into_iter()
+ .enumerate()
+ .map(|(i, user)| {
+ let id = user.get_id();
+ User {
+ id,
+ index: i,
+ protected: is_protected_user(id, device_serial),
+ }
+ })
+ .collect()
+ })
+ .unwrap_or_default()
+}
+
+/// This matches serials (`getprop ro.serialno`)
+/// that are authorized by the user.
+#[must_use]
+pub fn get_devices_list() -> Vec {
+ retry(
+ Fixed::from_millis(500).take(if cfg!(debug_assertions) { 3 } else { 10 }),
+ || match AdbCommand::new().devices() {
+ Ok(devices) => {
+ let mut device_list: Vec = vec![];
+ if devices.iter().all(|(_, stat)| stat != "device") {
+ return OperationResult::Retry(vec![]);
+ }
+ for device in devices {
+ let serial = &device.0;
+ device_list.push(Phone {
+ model: format!("{} {}", get_device_brand(serial), get_device_model(serial)),
+ android_sdk: get_android_sdk(serial),
+ user_list: list_users_idx_prot(serial),
+ adb_id: serial.clone(),
+ });
+ }
+ OperationResult::Ok(device_list)
+ }
+ Err(err) => {
+ error!("get_devices_list() -> {err}");
+ let test: Vec = vec![];
+ OperationResult::Retry(test)
+ }
+ },
+ )
+ .unwrap_or_default()
+}
+
+#[must_use]
+pub fn initial_load() -> bool {
+ match AdbCommand::new().devices() {
+ Ok(_devices) => true,
+ Err(_err) => false,
+ }
+}
+
+/// Get the current state of a package on a device
+#[must_use]
+pub fn get_package_state(
+ device_serial: &str,
+ package_name: &str,
+ user_id: Option,
+) -> Option {
+ use crate::adb::{ACommand as AdbCommand, PmListPacksFlag};
+
+ // Check if package is enabled
+ if let Ok(enabled_packages) = AdbCommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(Some(PmListPacksFlag::OnlyEnabled), user_id)
+ && enabled_packages.contains(&package_name.to_string())
+ {
+ return Some(PackageState::Enabled);
+ }
+
+ // Check if package is disabled
+ if let Ok(disabled_packages) = AdbCommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(Some(PmListPacksFlag::OnlyDisabled), user_id)
+ && disabled_packages.contains(&package_name.to_string())
+ {
+ return Some(PackageState::Disabled);
+ }
+
+ // Check if package exists at all (including uninstalled)
+ if let Ok(all_packages) = AdbCommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(Some(PmListPacksFlag::IncludeUninstalled), user_id)
+ && all_packages.contains(&package_name.to_string())
+ {
+ return Some(PackageState::Uninstalled);
+ }
+
+ // Package not found at all - it doesn't exist on this device/user
+ None
+}
+
+/// Verify the current state of a package on a device.
+/// Returns the package state, or `None` if the package doesn't exist.
+#[must_use]
+pub fn verify_package_state(
+ package_name: &str,
+ device_serial: &str,
+ user_id: Option,
+) -> Option {
+ get_package_state(device_serial, package_name, user_id)
+}
+
+/// Check if a package exists on any other users besides the target user.
+/// This helps detect OEM-specific cross-user restoration behavior.
+///
+/// Only includes users where the package exists in a non-uninstalled state
+/// (i.e., Enabled or Disabled).
+#[must_use]
+pub fn check_cross_user_package_existence(
+ package_name: &str,
+ device_serial: &str,
+ target_user_id: u16,
+ phone: &Phone,
+) -> Vec<(u16, PackageState)> {
+ let mut other_user_states = Vec::new();
+
+ for user in &phone.user_list {
+ if user.id != target_user_id
+ && !user.protected
+ && let Some(state) = verify_package_state(package_name, device_serial, Some(user.id))
+ && state != PackageState::Uninstalled
+ {
+ other_user_states.push((user.id, state));
+ }
+ }
+
+ other_user_states
+}
+
+/// Creates a `CorePackage` with the specified state, preserving other fields from the original.
+fn package_with_state(package: &CorePackage, state: PackageState) -> CorePackage {
+ CorePackage {
+ state,
+ ..package.clone()
+ }
+}
+
+/// Executes the first available command and returns the result.
+fn execute_first_command(commands: &[String], phone: &Phone) -> Result<(), String> {
+ if commands.is_empty() {
+ return Err("No command available".to_string());
+ }
+ AdbCommand::new()
+ .shell(&phone.adb_id)
+ .raw(&commands[0])
+ .map(|_| ())
+ .map_err(|err| err.clone())
+}
+
+/// Attempt fallback action when package state verification fails
+pub fn attempt_fallback(
+ package: &CorePackage,
+ wanted_state: PackageState,
+ actual_state: PackageState,
+ user: User,
+ phone: &Phone,
+) -> Result {
+ match (wanted_state, actual_state) {
+ // Case 1: Tried to uninstall but package was reinstalled -> disable it
+ (PackageState::Uninstalled, PackageState::Enabled) => {
+ let pkg = package_with_state(package, PackageState::Enabled);
+ let commands = apply_pkg_state_commands(&pkg, PackageState::Disabled, user, phone);
+ execute_first_command(&commands, phone)
+ .map(|()| "disabled package instead of uninstalling".to_string())
+ .map_err(|e| format!("Failed to disable package: {e}"))
+ }
+
+ // Case 2: Tried to disable but package re-enabled itself -> try uninstall
+ (PackageState::Disabled, PackageState::Enabled) => {
+ let pkg = package_with_state(package, PackageState::Enabled);
+ let commands = apply_pkg_state_commands(&pkg, PackageState::Uninstalled, user, phone);
+ execute_first_command(&commands, phone)
+ .map_err(|e| format!("Failed to uninstall: {e}"))?;
+
+ // Verify the package was actually uninstalled
+ match verify_package_state(&package.name, &phone.adb_id, Some(user.id)) {
+ Some(PackageState::Uninstalled) | None => {
+ Ok("uninstalled package instead of disabling".to_string())
+ }
+ _ => Err("Package still exists after uninstall attempt".to_string()),
+ }
+ }
+
+ // Case 3: Tried to enable but package was disabled -> try uninstall then reinstall
+ (PackageState::Enabled, PackageState::Disabled) => {
+ let pkg = package_with_state(package, PackageState::Disabled);
+ let uninstall_cmds =
+ apply_pkg_state_commands(&pkg, PackageState::Uninstalled, user, phone);
+ execute_first_command(&uninstall_cmds, phone)
+ .map_err(|e| format!("Failed to uninstall for reinstall: {e}"))?;
+
+ // Now try to reinstall/enable
+ let pkg_uninstalled = package_with_state(package, PackageState::Uninstalled);
+ let enable_cmds =
+ apply_pkg_state_commands(&pkg_uninstalled, PackageState::Enabled, user, phone);
+
+ if enable_cmds.is_empty() {
+ return Ok("uninstalled package but couldn't reinstall".to_string());
+ }
+
+ execute_first_command(&enable_cmds, phone)
+ .map(|()| "uninstalled and reinstalled package to enable it".to_string())
+ .map_err(|e| format!("Failed to reinstall package: {e}"))
+ }
+
+ // Other cases - no fallback available
+ _ => Err(format!(
+ "No fallback available for wanted state {wanted_state:?} and actual state {actual_state:?}"
+ )),
+ }
+}
diff --git a/src/core/uad_lists.rs b/crates/uad-core/src/uad_lists.rs
similarity index 67%
rename from src/core/uad_lists.rs
rename to crates/uad-core/src/uad_lists.rs
index 9a3cdd5..35cade9 100644
--- a/src/core/uad_lists.rs
+++ b/crates/uad-core/src/uad_lists.rs
@@ -1,8 +1,10 @@
-use crate::core::utils::{format_diff_time_from_now, last_modified_date};
use crate::CACHE_DIR;
-use retry::{delay::Fixed, retry, OperationResult};
+use crate::utils::{format_diff_time_from_now, last_modified_date};
+use log::warn;
+use retry::{OperationResult, delay::Fixed, retry};
use serde::{Deserialize, Serialize};
use serde_json;
+use std::borrow::Cow;
use std::collections::HashMap;
use std::fs;
use std::path::PathBuf;
@@ -14,8 +16,7 @@ pub const LIST_FNAME: &str = "uad_lists.json";
reason = "https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/discussions/608"
)]
// not `const`, because it's too big
-pub static DATA: &str = include_str!("../../resources/assets/uad_lists.json");
-// TODO: use `const_format` crate
+pub static DATA: &str = include_str!("../../../resources/assets/uad_lists.json");
#[derive(Deserialize, Debug, Clone, PartialEq, Hash, Eq)]
#[serde(rename_all = "camelCase")]
@@ -28,7 +29,7 @@ pub struct Package {
pub removal: Removal,
}
-#[derive(Default, Deserialize, Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Default, Deserialize, Serialize, Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub enum UadList {
#[default]
All,
@@ -72,24 +73,31 @@ impl UadList {
Self::Pending,
Self::Unlisted,
];
+
+ #[must_use]
+ pub const fn as_str(self) -> &'static str {
+ match self {
+ Self::All => "All lists",
+ Self::Aosp => "aosp",
+ Self::Carrier => "carrier",
+ Self::Google => "google",
+ Self::Misc => "misc",
+ Self::Oem => "oem",
+ Self::Pending => "pending",
+ Self::Unlisted => "unlisted",
+ }
+ }
}
impl std::fmt::Display for UadList {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
- write!(
- f,
- "{}",
- match self {
- Self::All => "All lists",
- Self::Aosp => "aosp",
- Self::Carrier => "carrier",
- Self::Google => "google",
- Self::Misc => "misc",
- Self::Oem => "oem",
- Self::Pending => "pending",
- Self::Unlisted => "unlisted",
- }
- )
+ f.write_str(self.as_str())
+ }
+}
+
+impl From for Cow<'_, str> {
+ fn from(list: UadList) -> Self {
+ Cow::Borrowed(list.as_str())
}
}
@@ -112,7 +120,7 @@ impl std::fmt::Display for PackageState {
f,
"{}",
match self {
- Self::All => "All packages",
+ Self::All => "All states",
Self::Enabled => "Enabled",
Self::Uninstalled => "Uninstalled",
Self::Disabled => "Disabled",
@@ -142,7 +150,7 @@ impl Opposite for PackageState {
}
// Bad names. To be changed!
-#[derive(Default, Debug, Deserialize, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Default, Debug, Deserialize, Serialize, Clone, Copy, PartialEq, Eq, Hash)]
pub enum Removal {
#[default]
Recommended,
@@ -169,22 +177,29 @@ impl Removal {
Self::Unsafe,
Self::Unlisted,
];
+
+ #[must_use]
+ pub const fn as_str(self) -> &'static str {
+ match self {
+ Self::All => "All removals",
+ Self::Recommended => "Recommended",
+ Self::Advanced => "Advanced",
+ Self::Expert => "Expert",
+ Self::Unsafe => "Unsafe",
+ Self::Unlisted => "Unlisted",
+ }
+ }
}
impl std::fmt::Display for Removal {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
- write!(
- f,
- "{}",
- match self {
- Self::All => "All",
- Self::Recommended => "Recommended",
- Self::Advanced => "Advanced",
- Self::Expert => "Expert",
- Self::Unsafe => "Unsafe",
- Self::Unlisted => "Unlisted",
- }
- )
+ f.write_str(self.as_str())
+ }
+}
+
+impl From for Cow<'_, str> {
+ fn from(list: Removal) -> Self {
+ Cow::Borrowed(list.as_str())
}
}
@@ -194,23 +209,32 @@ pub fn load_debloat_lists(remote: bool) -> Result {
- // TODO: max resp size is 10MB, list is ~1.3MB;
- // TODO: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/discussions/608
- #[warn(clippy::expect_used, reason = "this will panic if GH servers rate-limit the user, or many other reasons.")]
- let text = data.into_string().expect("response should be Ok type");
+ Ok(mut data) => {
+ // https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/discussions/608
+ let text = data
+ .body_mut()
+ .with_config()
+ .limit(1 << (3 + 10 + 10))
+ .read_to_string()
+ .expect("remote list is bigger than 8MiB");
fs::write(cached_uad_lists.clone(), &text).expect("Unable to write file");
- let list: PackageHashMap = serde_json::from_str(&text).expect("Unable to parse");
+ let list: PackageHashMap =
+ serde_json::from_str(&text).expect("Unable to parse");
OperationResult::Ok(list)
}
Err(e) => {
- warn!("Could not load remote debloat list: {}", e);
+ warn!("Could not load remote debloat list: {e}");
error = true;
OperationResult::Retry(PackageHashMap::new())
}
diff --git a/src/core/update.rs b/crates/uad-core/src/update.rs
similarity index 86%
rename from src/core/update.rs
rename to crates/uad-core/src/update.rs
index bd4c24e..51e52e4 100644
--- a/src/core/update.rs
+++ b/crates/uad-core/src/update.rs
@@ -1,10 +1,10 @@
-use crate::core::utils::NAME;
-
use serde::Deserialize;
#[cfg(feature = "self-update")]
use {
- retry::{delay::Fibonacci, retry, OperationResult},
+ crate::utils::NAME,
+ log::{debug, error},
+ retry::{OperationResult, delay::Fibonacci, retry},
std::fs,
std::io,
std::io::copy,
@@ -55,15 +55,14 @@ impl std::fmt::Display for SelfUpdateStatus {
/// Download a file from the internet
#[cfg(feature = "self-update")]
#[allow(clippy::unused_async, reason = "`.call` is equivalent to `.await`")]
-pub async fn download_file(url: T, dest_file: PathBuf) -> Result<(), String> {
- let url = url.to_string();
- debug!("downloading file from {}", &url);
+pub async fn download_file(url: &str, dest_file: PathBuf) -> Result<(), String> {
+ debug!("downloading file from {url}");
- match ureq::get(&url).call() {
- Ok(res) => {
+ match ureq::get(url).call() {
+ Ok(mut res) => {
let mut file = fs::File::create(dest_file).map_err(|e| e.to_string())?;
- if let Err(e) = copy(&mut res.into_reader(), &mut file) {
+ if let Err(e) = copy(&mut res.body_mut().as_reader(), &mut file) {
return Err(e.to_string());
}
}
@@ -77,7 +76,7 @@ pub async fn download_file(url: T, dest_file: PathBuf) -> Re
/// then returns both the original file name (new version) and temp path (old version)
#[cfg(feature = "self-update")]
pub async fn download_update_to_temp_file(
- bin_name: String,
+ bin_name: &str,
release: Release,
) -> Result<(PathBuf, PathBuf), ()> {
let current_bin_path = std::env::current_exe().map_err(|_| ())?;
@@ -110,8 +109,8 @@ pub async fn download_update_to_temp_file(
let archive_path = current_bin_path.parent().ok_or(())?.join(&asset_name);
- if let Err(e) = download_file(asset.download_url, archive_path.clone()).await {
- error!("Couldn't download {NAME} update: {}", e);
+ if let Err(e) = download_file(&asset.download_url, archive_path.clone()).await {
+ error!("Couldn't download {NAME} update: {e}");
return Err(());
}
@@ -133,7 +132,7 @@ pub async fn download_update_to_temp_file(
.cloned()
.ok_or(())?;
- if let Err(e) = download_file(asset.download_url, download_path.clone()).await {
+ if let Err(e) = download_file(&asset.download_url, download_path.clone()).await {
error!("Couldn't download {NAME} update: {}", e);
return Err(());
}
@@ -147,23 +146,17 @@ pub async fn download_update_to_temp_file(
let mut permissions = fs::metadata(&download_path).map_err(|_| ())?.permissions();
permissions.set_mode(0o755);
if let Err(e) = fs::set_permissions(&download_path, permissions) {
- error!("[SelfUpdate] Couldn't set permission to temp file: {}", e);
+ error!("[SelfUpdate] Couldn't set permission to temp file: {e}");
return Err(());
}
}
if let Err(e) = rename(¤t_bin_path, &tmp_path) {
- error!(
- "[SelfUpdate] Couldn't rename from current to temporary binary path: {}",
- e
- );
+ error!("[SelfUpdate] Couldn't rename from current to temporary binary path: {e}");
return Err(());
}
if let Err(e) = rename(&download_path, ¤t_bin_path) {
- error!(
- "[SelfUpdate] Couldn't rename from downloaded to current binary path: {}",
- e
- );
+ error!("[SelfUpdate] Couldn't rename from downloaded to current binary path: {e}");
return Err(());
}
@@ -182,10 +175,10 @@ pub fn get_latest_release() -> Result, ()> {
pub fn get_latest_release() -> Result, ()> {
debug!("Checking for {NAME} update");
- if let Ok(res) = ureq::get("https://api.github.com/repos/Universal-Debloater-Alliance/universal-android-debloater/releases/latest")
+ if let Ok(mut res) = ureq::get("https://api.github.com/repos/Universal-Debloater-Alliance/universal-android-debloater/releases/latest")
.call() {
let release: Release = serde_json::from_value(
- res.into_json::()
+ res.body_mut().read_json::()
.map_err(|_| ())?
.clone(),
)
@@ -232,13 +225,18 @@ pub fn extract_binary_from_tar(archive_path: &Path, temp_file: &Path) -> io::Res
/// Hardcoded binary names for each compilation target
/// that gets published to the GitHub Release
#[cfg(feature = "self-update")]
-pub const fn bin_name() -> &'static str {
+pub const BIN_NAME: &str = {
#[cfg(target_os = "windows")]
{
- "uad-ng.exe"
+ "uad-ng-windows.exe"
}
- #[cfg(target_os = "macos")]
+ #[cfg(all(target_os = "macos", any(target_arch = "x86_64", target_arch = "x86")))]
+ {
+ "uad-ng-macos-intel"
+ }
+
+ #[cfg(all(target_os = "macos", any(target_arch = "arm", target_arch = "aarch64")))]
{
"uad-ng-macos"
}
@@ -247,7 +245,7 @@ pub const fn bin_name() -> &'static str {
{
"uad-ng-linux"
}
-}
+};
/// Rename a file or directory to a new name, retrying if the operation fails because of permissions
///
diff --git a/crates/uad-core/src/utils.rs b/crates/uad-core/src/utils.rs
new file mode 100644
index 0000000..3569162
--- /dev/null
+++ b/crates/uad-core/src/utils.rs
@@ -0,0 +1,299 @@
+#![warn(clippy::unwrap_used)]
+
+use crate::{
+ adb::{ACommand as AdbCommand, PmListPacksFlag},
+ sync::{CorePackage, User},
+ uad_lists::{PackageHashMap, PackageState, Removal, UadList},
+};
+use chrono::{DateTime, offset::Utc};
+use csv::Writer;
+use log::error;
+use std::{
+ collections::HashSet,
+ fmt, fs,
+ path::{Path, PathBuf},
+};
+
+/// Canonical shortened name of the application
+pub const NAME: &str = "UAD-ng";
+/// Full name of the application
+pub const FULL_NAME: &str = "Universal Android Debloater Next Generation";
+pub const EXPORT_FILE_NAME: &str = "selection_export.txt";
+
+/// Returns `true` if `c` matches the regex `\w`
+#[inline]
+#[must_use]
+pub const fn is_w(c: u8) -> bool {
+ // https://github.com/rust-lang/rust/issues/93279
+ // https://github.com/rust-lang/rust/issues/83623
+ (c == b'_') | c.is_ascii_alphanumeric()
+}
+
+/// Returns `true` if `s` matches the regex `^\w+$`
+#[must_use]
+pub const fn is_all_w_c(s: &[u8]) -> bool {
+ let mut i = 0;
+ while i < s.len() {
+ if !is_w(s[i]) {
+ return false;
+ }
+ i += 1;
+ }
+ true
+}
+
+// Takes a time-stamp parameter,
+// for purity and testability.
+//
+// The TZ is generic, because testing requires UTC,
+// while users get the local-aware version.
+#[expect(
+ clippy::needless_pass_by_value,
+ reason = "Timestamps should be fresh, no need to borrow"
+)]
+#[must_use]
+pub fn generate_backup_name(t: DateTime) -> String
+where
+ T: chrono::TimeZone,
+ T::Offset: std::fmt::Display,
+{
+ t.format("uninstalled_packages_%Y%m%d.csv").to_string()
+}
+
+#[derive(Debug, Clone, Copy)]
+pub enum Error {
+ DialogClosed,
+}
+
+#[must_use]
+pub fn fetch_packages(
+ uad_lists: &PackageHashMap,
+ device_serial: &str,
+ user_id: Option,
+) -> Vec {
+ let all_sys_packs = AdbCommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(Some(PmListPacksFlag::IncludeUninstalled), user_id)
+ .unwrap_or_default();
+ let enabled_sys_packs: HashSet = AdbCommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(Some(PmListPacksFlag::OnlyEnabled), user_id)
+ .unwrap_or_default()
+ .into_iter()
+ .collect();
+ let disabled_sys_packs: HashSet = AdbCommand::new()
+ .shell(device_serial)
+ .pm()
+ .list_packages_sys(Some(PmListPacksFlag::OnlyDisabled), user_id)
+ .unwrap_or_default()
+ .into_iter()
+ .collect();
+
+ let mut description;
+ let mut removal;
+ let mut state;
+ let mut list;
+ let mut user_package: Vec = Vec::new();
+
+ for pack_name in all_sys_packs {
+ let p_name = &pack_name;
+ description = String::from("[No description]: CONTRIBUTION WELCOMED");
+ removal = Removal::Unlisted;
+ state = PackageState::Uninstalled;
+ list = UadList::Unlisted;
+
+ if let Some(package) = uad_lists.get(p_name) {
+ if !package.description.is_empty() {
+ description = package.description.clone();
+ }
+ removal = package.removal;
+ list = package.list;
+ }
+
+ if enabled_sys_packs.contains(p_name) {
+ state = PackageState::Enabled;
+ } else if disabled_sys_packs.contains(p_name) {
+ state = PackageState::Disabled;
+ }
+
+ let package = CorePackage {
+ name: p_name.clone(),
+ description,
+ removal,
+ state,
+ list,
+ };
+ user_package.push(package);
+ }
+ user_package.sort_by_key(|package| package.name.to_lowercase());
+ user_package
+}
+
+#[must_use]
+pub fn setup_uad_dir(dir: &Path) -> PathBuf {
+ let dir = dir.join("uad");
+ if let Err(e) = fs::create_dir_all(&dir) {
+ error!("Can't create directory: {}", dir.display());
+ panic!("{e}");
+ }
+ dir
+}
+
+/// Open a directory or file with the system's default file manager.
+pub fn open_url(dir: PathBuf) {
+ const OPENER: &str = match std::env::consts::OS.as_bytes() {
+ b"windows" => "explorer",
+ b"macos" => "open",
+ // "linux"
+ _ => "xdg-open",
+ };
+ match std::process::Command::new(OPENER).arg(dir).output() {
+ Ok(o) => {
+ if !o.status.success() {
+ // Use lossy conversion for stderr - some systems (like Windows)
+ // may output non-UTF8 characters in error messages
+ let stderr = String::from_utf8_lossy(&o.stderr);
+ let stderr_trimmed = stderr.trim_end();
+ if stderr_trimmed.is_empty() {
+ error!("Can't open URL: command failed with no error message");
+ } else {
+ error!("Can't open the following URL: {stderr_trimmed}");
+ }
+ }
+ }
+ Err(e) => error!("Failed to run command to open the file explorer: {e}"),
+ }
+}
+
+#[rustfmt::skip]
+#[must_use]
+pub fn last_modified_date(file: PathBuf) -> DateTime {
+ fs::metadata(file).map_or_else(|_| Utc::now(), |metadata| match metadata.modified() {
+ Ok(time) => time.into(),
+ Err(_) => Utc::now(),
+ })
+}
+
+#[must_use]
+pub fn format_diff_time_from_now(date: DateTime) -> String {
+ let now: DateTime = Utc::now();
+ let last_update = now - date;
+ if last_update.num_days() == 0 {
+ if last_update.num_hours() == 0 {
+ last_update.num_minutes().to_string() + " min(s) ago"
+ } else {
+ last_update.num_hours().to_string() + " hour(s) ago"
+ }
+ } else {
+ last_update.num_days().to_string() + " day(s) ago"
+ }
+}
+
+/// Export selected package names.
+/// File will be saved in same directory where UAD-ng is located.
+pub fn export_selection(package_names: &[String]) -> Result {
+ let selected = package_names.join("\n");
+
+ match fs::write(EXPORT_FILE_NAME, selected) {
+ Ok(()) => Ok(true),
+ Err(err) => Err(err.to_string()),
+ }
+}
+
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub struct DisplayablePath {
+ pub path: PathBuf,
+}
+
+impl fmt::Display for DisplayablePath {
+ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+ let stem = self.path.file_stem().map_or_else(
+ || {
+ error!("[PATH STEM]: No file stem found");
+ "[File steam not found]".to_string()
+ },
+ |p| {
+ if let Ok(stem) = p.to_os_string().into_string() {
+ stem
+ } else {
+ error!("[PATH ENCODING]: {}", self.path.display());
+ "[PATH ENCODING ERROR]".to_string()
+ }
+ },
+ );
+
+ write!(f, "{stem}")
+ }
+}
+
+/// Export uninstalled packages in a csv file.
+/// Exported information will contain package name and description.
+pub fn export_packages(user: User, phone_packages: &[Vec]) -> Result {
+ let backup_file = generate_backup_name(chrono::Local::now());
+
+ let file = fs::File::create(backup_file).map_err(|err| err.to_string())?;
+ let mut wtr = Writer::from_writer(file);
+
+ wtr.write_record(["Package Name", "Description"])
+ .map_err(|err| err.to_string())?;
+
+ let uninstalled_packages: Vec<&CorePackage> = phone_packages[user.index]
+ .iter()
+ .filter(|p| p.state == PackageState::Uninstalled)
+ .collect();
+
+ for package in uninstalled_packages {
+ wtr.write_record([&package.name, &package.description.replace('\n', " ")])
+ .map_err(|err| err.to_string())?;
+ }
+
+ wtr.flush().map_err(|err| err.to_string())?;
+
+ Ok(true)
+}
+
+/// Truncate description to fit within max length, taking only the first line
+#[must_use]
+pub fn truncate_description(desc: &str, max_len: usize) -> String {
+ let first_line = desc.split('\n').next().unwrap_or("").trim_end();
+
+ if first_line.len() <= max_len {
+ first_line.to_string()
+ } else {
+ format!("{}...", &first_line[..max_len.saturating_sub(3)])
+ }
+}
+
+/// Check if package matches search term (checks name and description)
+#[must_use]
+pub fn matches_search(pkg_name: &str, search_term: &str, pkg_description: Option<&str>) -> bool {
+ let search_lower = search_term.to_lowercase();
+
+ if pkg_name.to_lowercase().contains(&search_lower) {
+ return true;
+ }
+
+ if let Some(description) = pkg_description {
+ if description.to_lowercase().contains(&search_lower) {
+ return true;
+ }
+ }
+
+ false
+}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use chrono::TimeZone;
+
+ #[test]
+ fn backup_name() {
+ assert_eq!(
+ generate_backup_name(chrono::Utc.timestamp_millis_opt(0).unwrap()),
+ "uninstalled_packages_19700101.csv".to_string()
+ );
+ }
+}
diff --git a/crates/uad-gui/Cargo.toml b/crates/uad-gui/Cargo.toml
new file mode 100644
index 0000000..4a50636
--- /dev/null
+++ b/crates/uad-gui/Cargo.toml
@@ -0,0 +1,62 @@
+[package]
+name = "uad-gui"
+version.workspace = true
+authors.workspace = true
+license.workspace = true
+homepage.workspace = true
+repository.workspace = true
+readme.workspace = true
+keywords.workspace = true
+categories = ["gui"]
+edition.workspace = true
+
+[[bin]]
+name = "uad-ng"
+path = "src/main.rs"
+
+[features]
+default = ["wgpu", "self-update", "img"]
+wgpu = [] # Iced/wgpu is default
+self-update = ["flate2", "tar"]
+no-self-update = []
+img = ["image", "iced/image"]
+
+[dependencies]
+uad-core = { path = "../uad-core", features = ["self-update"] }
+iced.workspace = true
+image = { workspace = true, optional = true }
+rfd.workspace = true
+dark-light.workspace = true
+fern.workspace = true
+chrono.workspace = true
+dirs.workspace = true
+log.workspace = true
+flate2 = { workspace = true, optional = true }
+tar = { workspace = true, optional = true }
+
+[target.'cfg(target_os = "windows")'.dependencies]
+win32console.workspace = true
+
+[build-dependencies]
+embed-resource = "3"
+
+[lints.rust]
+deprecated_safe = "warn"
+
+[lints.clippy]
+undocumented_unsafe_blocks = "forbid"
+exit = "deny"
+panic_in_result_fn = "warn"
+infinite_loop = "warn"
+mem_forget = "warn"
+implicit_clone = "warn"
+format_push_string = "warn"
+large_include_file = "warn"
+shadow_unrelated = "warn"
+struct_field_names = "allow" # annoying
+
+disallowed_types = "deny"
+disallowed_methods = "deny"
+
+allow_attributes_without_reason = "warn"
+pedantic = { level = "warn", priority = -1 }
diff --git a/src/gui/mod.rs b/crates/uad-gui/src/gui.rs
similarity index 66%
rename from src/gui/mod.rs
rename to crates/uad-gui/src/gui.rs
index e7ba1af..925aedf 100644
--- a/src/gui/mod.rs
+++ b/crates/uad-gui/src/gui.rs
@@ -1,32 +1,32 @@
-pub mod style;
-pub mod views;
-pub mod widgets;
-
-use crate::core::sync::{get_devices_list, initial_load, perform_adb_commands, CommandType, Phone};
-use crate::core::theme::Theme;
-use crate::core::uad_lists::UadListState;
-use crate::core::update::{get_latest_release, Release, SelfUpdateState, SelfUpdateStatus};
-use crate::core::utils::{string_to_theme, ANDROID_SERIAL, NAME};
-
-use iced::advanced::graphics::image::image_rs::ImageFormat;
-use iced::font;
-use iced::window::icon;
-use views::about::{About as AboutView, Message as AboutMessage};
-use views::list::{List as AppsView, LoadingState as ListLoadingState, Message as AppsMessage};
-use views::settings::{Message as SettingsMessage, Settings as SettingsView};
-use widgets::navigation_menu::nav_menu;
-
-use iced::widget::column;
-use iced::{
- window::Settings as Window, Alignment, Application, Command, Element, Length, Renderer,
- Settings,
+#[cfg(feature = "img")]
+use crate::theme::OS_COLOR_SCHEME;
+use crate::theme::Theme;
+use crate::theme::string_to_theme;
+use crate::views::about::{About as AboutView, Message as AboutMessage};
+use crate::views::list::{
+ List as AppsView, LoadingState as ListLoadingState, Message as AppsMessage,
};
-use std::env;
+use crate::views::settings::{Message as SettingsMessage, Settings as SettingsView};
+use crate::widgets::navigation_menu::nav_menu;
+use iced::font;
+use iced::widget::column;
+#[cfg(feature = "img")]
+use iced::window::icon;
+use iced::{Alignment, Element, Length, Settings, Task, window::Settings as Window};
+use iced::{Subscription, event, keyboard};
+#[cfg(feature = "img")]
+use image::ImageFormat;
+use log::{debug, error, info};
#[cfg(feature = "self-update")]
use std::path::PathBuf;
+use uad_core::adb;
+use uad_core::sync::{Phone, get_devices_list, initial_load};
+use uad_core::uad_lists::UadListState;
+use uad_core::update::{Release, SelfUpdateState, SelfUpdateStatus, get_latest_release};
+use uad_core::utils::{FULL_NAME, NAME};
#[cfg(feature = "self-update")]
-use crate::core::update::{bin_name, download_update_to_temp_file, remove_file};
+use uad_core::update::{BIN_NAME, download_update_to_temp_file, remove_file};
#[derive(Default, Debug, Clone)]
enum View {
@@ -38,11 +38,11 @@ enum View {
#[derive(Default, Clone)]
pub struct UpdateState {
- self_update: SelfUpdateState,
- uad_list: UadListState,
+ pub self_update: SelfUpdateState,
+ pub uad_list: UadListState,
}
-#[derive(Default, Clone)]
+#[derive(Default)]
pub struct UadGui {
view: View,
apps_view: AppsView,
@@ -77,22 +77,28 @@ pub enum Message {
ADBSatisfied(bool),
}
-impl Application for UadGui {
- type Theme = Theme;
- type Executor = iced::executor::Default;
- type Message = Message;
- type Flags = ();
+impl UadGui {
+ #[allow(
+ clippy::unused_self,
+ reason = "required by iced's Application trait interface"
+ )]
+ fn title(&self) -> String {
+ self.selected_device.as_ref().map_or_else(
+ || FULL_NAME.to_string(),
+ |device| format!("{FULL_NAME} - {}", device.model),
+ )
+ }
- fn new(_flags: ()) -> (Self, Command) {
+ fn new() -> (Self, Task) {
(
Self::default(),
- Command::batch([
- // Used in crate::gui::widgets::navigation_menu::ICONS. Name is `icomoon`.
- font::load(include_bytes!("../../resources/assets/icons.ttf").as_slice())
+ Task::batch([
+ // Used in crate::widgets::navigation_menu::ICONS. Name is `icomoon`.
+ font::load(include_bytes!("../../../resources/assets/icons.ttf").as_slice())
.map(Message::FontLoaded),
- Command::perform(initial_load(), Message::ADBSatisfied),
- Command::perform(get_devices_list(), Message::LoadDevices),
- Command::perform(
+ Task::perform(async { initial_load() }, Message::ADBSatisfied),
+ Task::perform(async { get_devices_list() }, Message::LoadDevices),
+ Task::perform(
async move { get_latest_release() },
Message::GetLatestRelease,
),
@@ -100,18 +106,58 @@ impl Application for UadGui {
)
}
- fn theme(&self) -> Theme {
- string_to_theme(&self.settings_view.general.theme)
+ #[allow(
+ clippy::unused_self,
+ reason = "required by iced's Application trait interface"
+ )]
+ fn subscription(&self) -> Subscription {
+ if self.selected_device.is_some() {
+ event::listen_with(Self::keyboard_shortcuts_with_device)
+ } else {
+ event::listen_with(Self::keyboard_shortcuts_without_device)
+ }
}
- fn title(&self) -> String {
- String::from("Universal Android Debloater Next Generation")
+ fn keyboard_shortcuts_with_device(
+ event: iced::Event,
+ _status: iced::event::Status,
+ _window: iced::window::Id,
+ ) -> Option {
+ Self::keyboard_shortcuts(event, true)
}
- // TODO: refactor later
- #[allow(clippy::too_many_lines)]
- fn update(&mut self, msg: Message) -> Command {
+
+ fn keyboard_shortcuts_without_device(
+ event: iced::Event,
+ _status: iced::event::Status,
+ _window: iced::window::Id,
+ ) -> Option {
+ Self::keyboard_shortcuts(event, false)
+ }
+
+ fn keyboard_shortcuts(event: iced::Event, can_control_device: bool) -> Option {
+ match event {
+ iced::Event::Keyboard(keyboard::Event::KeyPressed {
+ key: keyboard::Key::Character(c),
+ modifiers,
+ ..
+ }) if modifiers.control() && modifiers.shift() => match c.as_str() {
+ "r" if can_control_device => Some(Message::RebootButtonPressed),
+ "5" if can_control_device => Some(Message::RefreshButtonPressed),
+ "a" => Some(Message::AppsPress),
+ "i" => Some(Message::AboutPressed),
+ "s" => Some(Message::SettingsPressed),
+ _ => None,
+ },
+ _ => None,
+ }
+ }
+
+ #[allow(
+ clippy::too_many_lines,
+ reason = "Root GUI update orchestrates many flows"
+ )]
+ fn update(&mut self, msg: Message) -> Task {
match msg {
- #[allow(clippy::option_if_let_else)]
Message::LoadDevices(devices_list) => {
self.selected_device = match &self.selected_device {
Some(s_device) => {
@@ -125,7 +171,7 @@ impl Application for UadGui {
};
self.devices_list = devices_list;
- #[allow(unused_must_use)]
+ #[expect(unused_must_use, reason = "side-effect")]
{
self.update(Message::SettingsAction(SettingsMessage::LoadDeviceSettings));
}
@@ -134,36 +180,40 @@ impl Application for UadGui {
}
Message::AppsPress => {
self.view = View::List;
- Command::none()
+ Task::none()
}
Message::AboutPressed => {
self.view = View::About;
self.update_state.self_update = SelfUpdateState::default();
- Command::perform(
+ Task::perform(
async move { get_latest_release() },
Message::GetLatestRelease,
)
}
Message::SettingsPressed => {
self.view = View::Settings;
- Command::none()
+ Task::none()
}
Message::RefreshButtonPressed => {
self.apps_view = AppsView::default();
- #[allow(unused_must_use)]
+ #[expect(unused_must_use, reason = "side-effect")]
{
self.update(Message::AppsAction(AppsMessage::ADBSatisfied(
self.adb_satisfied,
)));
}
- Command::perform(get_devices_list(), Message::LoadDevices)
+ Task::perform(async { get_devices_list() }, Message::LoadDevices)
}
Message::RebootButtonPressed => {
self.apps_view = AppsView::default();
+ let serial = match &self.selected_device {
+ Some(d) => d.adb_id.clone(),
+ _ => String::default(),
+ };
self.selected_device = None;
self.devices_list = vec![];
- Command::perform(
- perform_adb_commands("reboot".to_string(), CommandType::Shell),
+ Task::perform(
+ async { adb::ACommand::new().shell(serial).reboot() },
|_| Message::Nothing,
)
}
@@ -182,7 +232,7 @@ impl Application for UadGui {
self.nb_running_async_adb_commands -= 1;
self.view = View::List;
- #[allow(unused_must_use)]
+ #[expect(unused_must_use, reason = "side-effect")]
{
self.apps_view.update(
&mut self.settings_view,
@@ -238,24 +288,22 @@ impl Application for UadGui {
{
self.update_state.self_update.status = SelfUpdateStatus::Updating;
self.apps_view.loading_state = ListLoadingState::_UpdatingUad;
- let bin_name = bin_name().to_owned();
- Command::perform(
- download_update_to_temp_file(bin_name, release.clone()),
+ Task::perform(
+ download_update_to_temp_file(BIN_NAME, release.clone()),
Message::_NewReleaseDownloaded,
)
} else {
- Command::none()
+ Task::none()
}
#[cfg(not(feature = "self-update"))]
- Command::none()
+ Task::none()
}
- AboutMessage::UrlPressed(_) => Command::none(),
+ AboutMessage::UrlPressed(_) => Task::none(),
}
}
Message::DeviceSelected(s_device) => {
self.selected_device = Some(s_device.clone());
self.view = View::List;
- env::set_var(ANDROID_SERIAL, s_device.adb_id);
info!("{:-^65}", "-");
info!(
"ANDROID_SDK: {} | DEVICE: {}",
@@ -264,7 +312,7 @@ impl Application for UadGui {
info!("{:-^65}", "-");
self.apps_view.loading_state = ListLoadingState::FindingPhones;
- #[allow(unused_must_use)]
+ #[expect(unused_must_use, reason = "side-effects")]
{
self.update(Message::SettingsAction(SettingsMessage::LoadDeviceSettings));
self.update(Message::AppsAction(AppsMessage::ToggleAllSelected(false)));
@@ -299,26 +347,26 @@ impl Application for UadGui {
{
Ok(_) => {
if let Err(e) = remove_file(cleanup_path) {
- error!("Could not remove temp update file: {}", e);
+ error!("Could not remove temp update file: {e}");
}
std::process::exit(0)
}
Err(error) => {
if let Err(e) = remove_file(cleanup_path) {
- error!("Could not remove temp update file: {}", e);
+ error!("Could not remove temp update file: {e}");
}
- error!("Failed to update {NAME}: {}", error);
+ error!("Failed to update {NAME}: {error}");
}
}
} else {
error!("Failed to update {NAME}!");
- #[allow(unused_must_use)]
+ #[expect(unused_must_use, reason = "side-effect")]
{
self.update(Message::AppsAction(AppsMessage::UpdateFailed));
self.update_state.self_update.status = SelfUpdateStatus::Failed;
}
}
- Command::none()
+ Task::none()
}
Message::GetLatestRelease(release) => {
match release {
@@ -327,15 +375,15 @@ impl Application for UadGui {
self.update_state.self_update.latest_release = r;
}
Err(()) => self.update_state.self_update.status = SelfUpdateStatus::Failed,
- };
- Command::none()
+ }
+ Task::none()
}
Message::FontLoaded(result) => {
if let Err(error) = result {
error!("Couldn't load font: {error:?}");
}
- Command::none()
+ Task::none()
}
Message::ADBSatisfied(result) => {
self.adb_satisfied = result;
@@ -343,11 +391,11 @@ impl Application for UadGui {
self.adb_satisfied,
)))
}
- Message::Nothing => Command::none(),
+ Message::Nothing => Task::none(),
}
}
- fn view(&self) -> Element {
+ fn view(&self) -> Element<'_, Message, Theme> {
let navigation_container = nav_menu(
&self.devices_list,
self.selected_device.clone(),
@@ -373,33 +421,55 @@ impl Application for UadGui {
column![navigation_container, main_container]
.width(Length::Fill)
- .align_items(Alignment::Center)
+ .align_x(Alignment::Center)
.into()
}
+
+ fn theme(&self) -> Theme {
+ string_to_theme(&self.settings_view.general.theme)
+ }
}
impl UadGui {
pub fn start() -> iced::Result {
- let logo: &[u8] = match dark_light::detect() {
- dark_light::Mode::Dark => include_bytes!("../../resources/assets/logo-dark.png"),
- dark_light::Mode::Light => include_bytes!("../../resources/assets/logo-light.png"),
- dark_light::Mode::Default => include_bytes!("../../resources/assets/logo-light.png"),
+ #[cfg(feature = "img")]
+ let logo: &[u8] = match *OS_COLOR_SCHEME {
+ // remember to keep `Unspecified` in sync with `src/theme`
+ dark_light::Mode::Dark | dark_light::Mode::Unspecified => {
+ include_bytes!("../../../resources/assets/logo-dark.png")
+ }
+ dark_light::Mode::Light => {
+ include_bytes!("../../../resources/assets/logo-light.png")
+ }
};
- Self::run(Settings {
- id: Some(String::from(NAME)),
- window: Window {
+ iced::application(UadGui::new, UadGui::update, UadGui::view)
+ .title(UadGui::title)
+ .theme(UadGui::theme)
+ .subscription(UadGui::subscription)
+ .settings(Settings {
+ id: Some(String::from(NAME)),
+ default_text_size: iced::Pixels(16.0),
+ // HACK: avoid glyph clipping on some systems. Details:
+ // https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/pull/1337
+ #[cfg(target_os = "linux")]
+ default_font: iced::Font {
+ family: iced::font::Family::Name("Adwaita Sans"),
+ ..Default::default()
+ },
+ ..Settings::default()
+ })
+ .window(Window {
size: iced::Size {
width: 950.0,
height: 700.0,
},
resizable: true,
decorations: true,
+ #[cfg(feature = "img")]
icon: icon::from_file_data(logo, Some(ImageFormat::Png)).ok(),
..iced::window::Settings::default()
- },
- default_text_size: iced::Pixels(16.0),
- ..Settings::default()
- })
+ })
+ .run()
}
}
diff --git a/crates/uad-gui/src/helpers.rs b/crates/uad-gui/src/helpers.rs
new file mode 100644
index 0000000..25c06f1
--- /dev/null
+++ b/crates/uad-gui/src/helpers.rs
@@ -0,0 +1,23 @@
+use crate::style;
+use crate::theme::Theme;
+use iced::Element;
+use iced::widget::button::Button;
+
+/// Wrapper function for `iced::widget::button` with padding and style applied
+pub fn button_primary<'a, Message>(
+ content: impl Into>,
+) -> Button<'a, Message, Theme> {
+ iced::widget::button(content)
+ .padding([5, 10])
+ .style(style::Button::Primary)
+}
+
+/// Opens a file picker dialog to select a folder
+pub async fn open_folder() -> Result {
+ rfd::AsyncFileDialog::new()
+ .set_title("Choose a backup location")
+ .pick_folder()
+ .await
+ .ok_or(uad_core::utils::Error::DialogClosed)
+ .map(|f| f.path().to_path_buf())
+}
diff --git a/crates/uad-gui/src/lib.rs b/crates/uad-gui/src/lib.rs
new file mode 100644
index 0000000..ede5da8
--- /dev/null
+++ b/crates/uad-gui/src/lib.rs
@@ -0,0 +1,11 @@
+#![allow(
+ clippy::missing_errors_doc,
+ reason = "Short-circuit doc lint to keep CI green"
+)]
+
+pub mod gui;
+pub mod helpers;
+pub mod style;
+pub mod theme;
+pub mod views;
+pub mod widgets;
diff --git a/src/main.rs b/crates/uad-gui/src/main.rs
similarity index 71%
rename from src/main.rs
rename to crates/uad-gui/src/main.rs
index a21d50c..07608a5 100644
--- a/src/main.rs
+++ b/crates/uad-gui/src/main.rs
@@ -1,38 +1,39 @@
#![windows_subsystem = "windows"]
-#[macro_use]
-extern crate log;
-use crate::core::utils::setup_uad_dir;
use fern::{
- colors::{Color, ColoredLevelConfig},
FormatCallback,
+ colors::{Color, ColoredLevelConfig},
};
use log::Record;
-use static_init::dynamic;
-use std::path::PathBuf;
-use std::{fmt::Arguments, fs::OpenOptions};
+use std::sync::LazyLock;
+use std::{fmt::Arguments, fs::OpenOptions, path::PathBuf};
+use uad_core::utils::setup_uad_dir;
-mod core;
-mod gui;
+use uad_gui::gui::UadGui;
-#[dynamic]
-static CONFIG_DIR: PathBuf = setup_uad_dir(&dirs::config_dir().expect("Can't detect config dir"));
-
-#[dynamic]
-static CACHE_DIR: PathBuf = setup_uad_dir(&dirs::cache_dir().expect("Can't detect cache dir"));
+static CACHE_DIR: LazyLock =
+ LazyLock::new(|| setup_uad_dir(&dirs::cache_dir().expect("Can't detect cache dir")));
fn main() -> iced::Result {
+ // Safety: This function is safe to call in a single-threaded program.
+ // The exact requirement is: you must ensure that there are no other threads concurrently writing or
+ // reading(!) the environment through functions or global variables other than the ones in this module.
+ unsafe {
+ // Force WGPU/Iced to use discrete GPU to prevent crashes on PCs with two GPUs.
+ // See #848 and related pull 850.
+ std::env::set_var("WGPU_POWER_PREF", "high");
+ }
+
setup_logger().expect("setup logging");
- gui::UadGui::start()
+ UadGui::start()
}
-/// Sets up logging to a new file in `CACHE_DIR/UAD`_{time}.log
+/// Sets up logging to a new file in `CACHE_DIR"/uadng.log"`
/// Also attaches the terminal on Windows machines
/// '''
/// match `setup_logger().expect("Error` setting up logger")
/// '''
fn setup_logger() -> Result<(), fern::InitError> {
- /// Attach Windows terminal, only on Windows
#[cfg(target_os = "windows")]
{
attach_windows_console();
@@ -62,20 +63,20 @@ fn setup_logger() -> Result<(), fern::InitError> {
.create(true)
.append(true)
.truncate(false)
- .open(CACHE_DIR.join(format!("UAD_{}.log", chrono::Local::now().format("%Y%m%d"))))?;
+ .open(CACHE_DIR.join("uadng.log"))?;
let file_dispatcher = fern::Dispatch::new()
.format(make_formatter(false))
.level(default_log_level)
// Rust compiler makes module names use _ instead of -
- .level_for("uad_ng", log::LevelFilter::Debug)
+ .level_for("uad_gui", log::LevelFilter::Debug)
.chain(log_file);
let stdout_dispatcher = fern::Dispatch::new()
.format(make_formatter(true))
.level(default_log_level)
// Rust compiler makes module names use _ instead of -
- .level_for("uad_ng", log::LevelFilter::Warn)
+ .level_for("uad_gui", log::LevelFilter::Warn)
.chain(std::io::stdout());
fern::Dispatch::new()
diff --git a/crates/uad-gui/src/style.rs b/crates/uad-gui/src/style.rs
new file mode 100644
index 0000000..9eeba68
--- /dev/null
+++ b/crates/uad-gui/src/style.rs
@@ -0,0 +1,776 @@
+#![allow(
+ non_snake_case,
+ clippy::trivially_copy_pass_by_ref,
+ clippy::wildcard_imports,
+ reason = "Iced style modules use PascalCase and &Theme; wildcard for local convenience"
+)]
+use crate::theme::{ColorPalette, Theme};
+use iced::widget::{
+ button, checkbox, container, overlay, pick_list, radio, scrollable, text, text_editor,
+ text_input,
+};
+use iced::{Background, Border, Color, Shadow};
+
+// Implement theming catalogs for our custom `Theme` so generic widgets
+// like `Button<'_, Message, Theme, Renderer>` compile under iced 0.13.
+
+impl button::Catalog for Theme {
+ type Class<'a> = button::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme, s: button::Status| Button::Primary(t, s))
+ }
+
+ fn style(
+ &self,
+ class: &::Class<'_>,
+ status: button::Status,
+ ) -> button::Style {
+ (class)(self, status)
+ }
+}
+
+impl checkbox::Catalog for Theme {
+ type Class<'a> = checkbox::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme, s: checkbox::Status| CheckBox::SettingsEnabled(t, s))
+ }
+
+ fn style(
+ &self,
+ class: &::Class<'_>,
+ status: checkbox::Status,
+ ) -> checkbox::Style {
+ (class)(self, status)
+ }
+}
+
+impl container::Catalog for Theme {
+ type Class<'a> = container::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme| Container::Background(t))
+ }
+
+ fn style(&self, class: &::Class<'_>) -> container::Style {
+ (class)(self)
+ }
+}
+
+impl scrollable::Catalog for Theme {
+ type Class<'a> = scrollable::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme, s: scrollable::Status| Scrollable::Description(t, s))
+ }
+
+ fn style(
+ &self,
+ class: &::Class<'_>,
+ status: scrollable::Status,
+ ) -> scrollable::Style {
+ (class)(self, status)
+ }
+}
+
+impl text::Catalog for Theme {
+ type Class<'a> = text::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme| Text::Default(t))
+ }
+
+ fn style(&self, class: &::Class<'_>) -> text::Style {
+ (class)(self)
+ }
+}
+
+// Additional catalogs required by Iced 0.13 generic theming
+
+impl text_input::Catalog for Theme {
+ type Class<'a> = text_input::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme, s: text_input::Status| {
+ let p = t.palette();
+
+ let active = text_input::Style {
+ background: Background::Color(p.base.foreground),
+ border: Border {
+ color: p.base.foreground,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ icon: Color {
+ a: 0.5,
+ ..p.normal.primary
+ },
+ placeholder: p.normal.surface,
+ value: p.bright.primary,
+ selection: p.normal.primary,
+ };
+
+ let focused = text_input::Style {
+ background: Background::Color(p.base.foreground),
+ border: Border {
+ color: Color {
+ a: 0.5,
+ ..p.normal.primary
+ },
+ width: 1.0,
+ radius: 2.0.into(),
+ },
+ icon: Color {
+ a: 0.5,
+ ..p.normal.primary
+ },
+ placeholder: p.normal.surface,
+ value: p.bright.primary,
+ selection: p.normal.primary,
+ };
+
+ let disabled = text_input::Style {
+ background: Background::Color(p.base.background),
+ border: Border {
+ color: Color {
+ a: 0.5,
+ ..p.base.foreground
+ },
+ width: 1.0,
+ radius: 2.0.into(),
+ },
+ icon: Color {
+ a: 0.5,
+ ..p.base.foreground
+ },
+ placeholder: p.normal.surface,
+ value: p.bright.primary,
+ selection: p.normal.primary,
+ };
+
+ match s {
+ text_input::Status::Active => active,
+ text_input::Status::Focused { .. } | text_input::Status::Hovered => focused,
+ text_input::Status::Disabled => disabled,
+ }
+ })
+ }
+
+ fn style(
+ &self,
+ class: &::Class<'_>,
+ status: text_input::Status,
+ ) -> text_input::Style {
+ (class)(self, status)
+ }
+}
+
+impl pick_list::Catalog for Theme {
+ type Class<'a> = pick_list::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme, s: pick_list::Status| {
+ let p = t.palette();
+ let border_color = match s {
+ pick_list::Status::Hovered => p.normal.primary,
+ _ => Color {
+ a: 0.5,
+ ..p.normal.primary
+ },
+ };
+ pick_list::Style {
+ text_color: p.bright.surface,
+ placeholder_color: p.bright.surface,
+ handle_color: p.bright.surface,
+ background: Background::Color(p.base.background),
+ border: Border {
+ color: border_color,
+ width: 1.0,
+ radius: 2.0.into(),
+ },
+ }
+ })
+ }
+
+ fn style(
+ &self,
+ class: &::Class<'_>,
+ status: pick_list::Status,
+ ) -> pick_list::Style {
+ (class)(self, status)
+ }
+}
+
+impl overlay::menu::Catalog for Theme {
+ type Class<'a> = overlay::menu::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme| {
+ let p = t.palette();
+ overlay::menu::Style {
+ text_color: p.bright.surface,
+ background: p.base.background.into(),
+ border: Border {
+ color: p.base.background,
+ width: 1.0,
+ radius: 2.0.into(),
+ },
+ selected_text_color: p.bright.surface,
+ selected_background: p.normal.primary.into(),
+ shadow: Shadow::default(),
+ }
+ })
+ }
+
+ fn style(&self, class: &::Class<'_>) -> overlay::menu::Style {
+ (class)(self)
+ }
+}
+
+impl radio::Catalog for Theme {
+ type Class<'a> = radio::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme, s: radio::Status| {
+ let p = t.palette();
+ let active = radio::Style {
+ background: Color::TRANSPARENT.into(),
+ dot_color: p.bright.primary,
+ border_width: 1.0,
+ border_color: p.bright.primary,
+ text_color: None,
+ };
+
+ match s {
+ radio::Status::Active { .. } => active,
+ radio::Status::Hovered { .. } => radio::Style {
+ border_width: 2.0,
+ ..active
+ },
+ }
+ })
+ }
+
+ fn style(
+ &self,
+ class: &::Class<'_>,
+ status: radio::Status,
+ ) -> radio::Style {
+ (class)(self, status)
+ }
+}
+
+impl text_editor::Catalog for Theme {
+ type Class<'a> = text_editor::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme, _s: text_editor::Status| {
+ let p = t.palette();
+ text_editor::Style {
+ background: Background::Color(p.base.foreground),
+ border: Border {
+ color: Color::TRANSPARENT,
+ width: 0.0,
+ radius: 0.0.into(),
+ },
+ placeholder: p.normal.surface,
+ value: p.bright.surface,
+ selection: Color {
+ a: 0.3,
+ ..p.normal.primary
+ },
+ }
+ })
+ }
+
+ fn style(
+ &self,
+ class: &::Class<'_>,
+ status: text_editor::Status,
+ ) -> text_editor::Style {
+ (class)(self, status)
+ }
+}
+
+// Rule styling for custom Theme (needed by vertical_rule)
+impl iced::widget::rule::Catalog for Theme {
+ type Class<'a> = iced::widget::rule::StyleFn<'a, Theme>;
+
+ fn default<'a>() -> ::Class<'a> {
+ Box::new(|t: &Theme| {
+ let p = t.palette();
+ iced::widget::rule::Style {
+ color: p.bright.surface,
+ radius: 2.0.into(),
+ fill_mode: iced::widget::rule::FillMode::Full,
+ snap: true,
+ }
+ })
+ }
+
+ fn style(
+ &self,
+ class: &::Class<'_>,
+ ) -> iced::widget::rule::Style {
+ (class)(self)
+ }
+}
+
+pub mod Container {
+ use super::*;
+
+ #[allow(dead_code, reason = "Used by other themes or future styles")]
+ #[must_use]
+ pub fn Invisible(_: &Theme) -> container::Style {
+ container::Style::default()
+ }
+
+ #[must_use]
+ pub fn Frame(theme: &Theme) -> container::Style {
+ let p = theme.palette();
+ container::Style {
+ background: Some(Background::Color(p.base.foreground)),
+ text_color: Some(p.bright.surface),
+ border: Border {
+ color: Color::TRANSPARENT,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ }
+ }
+
+ #[must_use]
+ pub fn BorderedFrame(theme: &Theme) -> container::Style {
+ let p = theme.palette();
+ container::Style {
+ background: Some(Background::Color(p.base.foreground)),
+ text_color: Some(p.bright.surface),
+ border: Border {
+ color: p.normal.error,
+ width: 1.0,
+ radius: 5.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ }
+ }
+
+ #[allow(dead_code, reason = "Currently unused in some views")]
+ #[must_use]
+ pub fn Tooltip(theme: &Theme) -> container::Style {
+ let p = theme.palette();
+ container::Style {
+ background: Some(Background::Color(p.base.foreground)),
+ text_color: Some(p.bright.surface),
+ border: Border {
+ color: p.normal.primary,
+ width: 1.0,
+ radius: 8.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ }
+ }
+
+ #[must_use]
+ pub fn Background(theme: &Theme) -> container::Style {
+ let p = theme.palette();
+ container::Style {
+ background: Some(Background::Color(p.base.background)),
+ text_color: Some(p.bright.surface),
+ border: Border {
+ color: Color::TRANSPARENT,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ }
+ }
+}
+
+pub mod Button {
+ use super::*;
+
+ #[allow(
+ dead_code,
+ reason = "Helper used by multiple styles; may be inlined by compiler"
+ )]
+ fn base(border_color: Color) -> button::Style {
+ button::Style {
+ background: None,
+ text_color: Color::WHITE,
+ border: Border {
+ color: border_color,
+ width: 1.0,
+ radius: 2.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ }
+ }
+
+ #[must_use]
+ pub fn Primary(theme: &Theme, status: button::Status) -> button::Style {
+ let p = theme.palette();
+ let mut style = style_active_hover_disabled(p.bright.primary, p.bright.primary, status);
+ if matches!(status, button::Status::Active | button::Status::Pressed) {
+ style.background = Some(Background::Color(p.base.foreground));
+ }
+ style
+ }
+
+ #[allow(
+ dead_code,
+ reason = "Alias kept for semantic clarity in some call-sites"
+ )]
+ #[must_use]
+ pub fn SelfUpdate(theme: &Theme, status: button::Status) -> button::Style {
+ Primary(theme, status)
+ }
+
+ #[must_use]
+ pub fn RestorePackage(theme: &Theme, status: button::Status) -> button::Style {
+ let p = theme.palette();
+ let mut style = style_active_hover_disabled(p.bright.secondary, p.bright.secondary, status);
+ if matches!(status, button::Status::Active | button::Status::Pressed) {
+ style.background = Some(Background::Color(p.base.foreground));
+ }
+ if matches!(status, button::Status::Disabled) {
+ style.background = Some(Background::Color(Color {
+ a: 0.05,
+ ..p.normal.primary
+ }));
+ style.text_color = p.bright.primary;
+ }
+ style
+ }
+
+ #[must_use]
+ pub fn UninstallPackage(theme: &Theme, status: button::Status) -> button::Style {
+ let p = theme.palette();
+ let mut style = style_active_hover_disabled(p.bright.error, p.bright.error, status);
+ if matches!(status, button::Status::Active | button::Status::Pressed) {
+ style.background = Some(Background::Color(p.base.foreground));
+ }
+ style
+ }
+
+ #[allow(
+ dead_code,
+ reason = "Style exposed for disabled state buttons in some contexts"
+ )]
+ #[must_use]
+ pub fn Unavailable(theme: &Theme, status: button::Status) -> button::Style {
+ UninstallPackage(theme, status)
+ }
+
+ #[must_use]
+ pub fn NormalPackage(theme: &Theme, status: button::Status) -> button::Style {
+ let p = theme.palette();
+ match status {
+ button::Status::Hovered => button::Style {
+ background: Some(Background::Color(Color {
+ a: 0.25,
+ ..p.normal.primary
+ })),
+ text_color: p.bright.surface,
+ border: Border {
+ color: p.base.background,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ },
+ _ => button::Style {
+ background: Some(Background::Color(p.base.foreground)),
+ text_color: p.bright.surface,
+ border: Border {
+ color: p.base.background,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ },
+ }
+ }
+
+ #[must_use]
+ pub fn SelectedPackage(theme: &Theme, _status: button::Status) -> button::Style {
+ let p = theme.palette();
+ button::Style {
+ background: Some(Background::Color(Color {
+ a: 0.25,
+ ..p.normal.primary
+ })),
+ text_color: p.bright.primary,
+ border: Border {
+ color: p.normal.primary,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ }
+ }
+
+ #[allow(dead_code, reason = "Used in views where buttons must be invisible")]
+ #[must_use]
+ pub fn Hidden(_: &Theme, _: button::Status) -> button::Style {
+ button::Style {
+ background: Some(Background::Color(Color::TRANSPARENT)),
+ text_color: Color::TRANSPARENT,
+ border: Border {
+ color: Color::TRANSPARENT,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ }
+ }
+
+ fn style_active_hover_disabled(
+ main: Color,
+ text: Color,
+ status: button::Status,
+ ) -> button::Style {
+ match status {
+ button::Status::Active | button::Status::Pressed => button::Style {
+ background: Some(Background::Color(main)),
+ text_color: text,
+ border: Border {
+ color: Color { a: 0.5, ..main },
+ width: 1.0,
+ radius: 2.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ },
+ button::Status::Hovered => button::Style {
+ background: Some(Background::Color(Color { a: 0.25, ..main })),
+ text_color: text,
+ border: Border {
+ color: Color { a: 0.5, ..main },
+ width: 1.0,
+ radius: 2.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ },
+ button::Status::Disabled => button::Style {
+ background: Some(Background::Color(Color { a: 0.05, ..main })),
+ text_color: Color { a: 0.5, ..text },
+ border: Border {
+ color: Color { a: 0.5, ..main },
+ width: 1.0,
+ radius: 2.0.into(),
+ },
+ shadow: Shadow::default(),
+ snap: true,
+ },
+ }
+ }
+}
+
+pub mod Scrollable {
+ use super::*;
+
+ #[allow(dead_code, reason = "Kept for future custom rails variations")]
+ fn rails(scroller_color: Color) -> (scrollable::Rail, scrollable::Rail) {
+ let rail = scrollable::Rail {
+ background: Some(Background::Color(Color::TRANSPARENT)),
+ border: Border {
+ color: Color::TRANSPARENT,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ scroller: scrollable::Scroller {
+ background: Background::Color(scroller_color),
+ border: Border {
+ color: Color::TRANSPARENT,
+ width: 1.0,
+ radius: 5.0.into(),
+ },
+ },
+ };
+ (rail, rail)
+ }
+
+ fn autoscroll(p: ColorPalette) -> scrollable::AutoScroll {
+ scrollable::AutoScroll {
+ background: Background::Color(Color {
+ a: 0.05,
+ ..p.base.background
+ }),
+ border: Border {
+ color: Color::TRANSPARENT,
+ width: 0.0,
+ radius: 5.0.into(),
+ },
+ shadow: Shadow::default(),
+ icon: p.bright.surface,
+ }
+ }
+
+ #[must_use]
+ pub fn Description(theme: &Theme, _status: scrollable::Status) -> scrollable::Style {
+ let p = theme.palette();
+ let (v, h) = rails(p.normal.surface);
+ scrollable::Style {
+ container: container::Style::default(),
+ vertical_rail: v,
+ horizontal_rail: h,
+ gap: Some(Background::Color(Color::TRANSPARENT)),
+ auto_scroll: autoscroll(p),
+ }
+ }
+
+ #[must_use]
+ pub fn Packages(theme: &Theme, _status: scrollable::Status) -> scrollable::Style {
+ let p = theme.palette();
+ let (v, h) = rails(p.base.foreground);
+ scrollable::Style {
+ container: container::Style::default(),
+ vertical_rail: v,
+ horizontal_rail: h,
+ gap: Some(Background::Color(Color::TRANSPARENT)),
+ auto_scroll: autoscroll(p),
+ }
+ }
+}
+
+pub mod CheckBox {
+ use super::*;
+
+ #[must_use]
+ pub fn PackageEnabled(theme: &Theme, _status: checkbox::Status) -> checkbox::Style {
+ let p = theme.palette();
+ checkbox::Style {
+ background: Background::Color(p.base.background),
+ icon_color: p.bright.primary,
+ border: Border {
+ color: p.base.background,
+ width: 1.0,
+ radius: 5.0.into(),
+ },
+ text_color: Some(p.bright.surface),
+ }
+ }
+
+ #[must_use]
+ pub fn PackageDisabled(theme: &Theme, _status: checkbox::Status) -> checkbox::Style {
+ let p = theme.palette();
+ checkbox::Style {
+ background: Background::Color(Color {
+ a: 0.55,
+ ..p.base.background
+ }),
+ icon_color: p.bright.primary,
+ border: Border {
+ color: p.normal.primary,
+ width: 1.0,
+ radius: 5.0.into(),
+ },
+ text_color: Some(p.normal.primary),
+ }
+ }
+
+ #[must_use]
+ pub fn SettingsEnabled(theme: &Theme, _status: checkbox::Status) -> checkbox::Style {
+ let p = theme.palette();
+ checkbox::Style {
+ background: Background::Color(p.base.background),
+ icon_color: p.bright.primary,
+ border: Border {
+ color: p.bright.primary,
+ width: 1.0,
+ radius: 5.0.into(),
+ },
+ text_color: Some(p.bright.surface),
+ }
+ }
+
+ #[must_use]
+ pub fn SettingsDisabled(theme: &Theme, _status: checkbox::Status) -> checkbox::Style {
+ let p = theme.palette();
+ checkbox::Style {
+ background: Background::Color(p.base.foreground),
+ icon_color: p.bright.primary,
+ border: Border {
+ color: p.normal.primary,
+ width: 1.0,
+ radius: 5.0.into(),
+ },
+ text_color: Some(p.bright.surface),
+ }
+ }
+}
+
+pub mod Text {
+ use super::*;
+
+ #[must_use]
+ pub fn Default(theme: &Theme) -> text::Style {
+ let _ = theme;
+ text::Style::default()
+ }
+
+ #[must_use]
+ pub fn Ok(theme: &Theme) -> text::Style {
+ let p = theme.palette();
+ text::Style {
+ color: Some(p.bright.secondary),
+ }
+ }
+
+ #[must_use]
+ pub fn Danger(theme: &Theme) -> text::Style {
+ let p = theme.palette();
+ text::Style {
+ color: Some(p.bright.error),
+ }
+ }
+
+ #[must_use]
+ pub fn Commentary(theme: &Theme) -> text::Style {
+ let p = theme.palette();
+ text::Style {
+ color: Some(p.normal.surface),
+ }
+ }
+
+ #[allow(
+ dead_code,
+ reason = "Convenience factory used by dynamic text coloring"
+ )]
+ pub fn Color(c: Color) -> impl Fn(&Theme) -> text::Style {
+ move |_t: &Theme| text::Style { color: Some(c) }
+ }
+}
+
+// Unit tests
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ #[test]
+ fn test_palette() {
+ let palette = Theme::Dark.palette();
+
+ assert_ne!(palette.base.background, palette.base.foreground);
+ assert_ne!(palette.normal.primary, Color::BLACK);
+ assert_ne!(palette.normal.surface, Color::BLACK);
+ assert_ne!(palette.bright.primary, Color::BLACK);
+ // if `LIGHT` then this can be `BLACK`
+ // https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/pull/730#issuecomment-2525405134
+ //assert_ne!(palette.bright.surface, Color::BLACK);
+ assert_ne!(palette.normal.error, Color::BLACK);
+ assert_ne!(palette.bright.error, Color::BLACK);
+ }
+}
diff --git a/src/core/theme.rs b/crates/uad-gui/src/theme.rs
similarity index 58%
rename from src/core/theme.rs
rename to crates/uad-gui/src/theme.rs
index e9fc989..e18a428 100644
--- a/src/core/theme.rs
+++ b/crates/uad-gui/src/theme.rs
@@ -1,5 +1,18 @@
-use dark_light;
-use iced::{color, Color};
+use iced::theme::{self, Mode, Palette, Style};
+use iced::{Color, color};
+use std::sync::LazyLock;
+
+/*
+In-memory caching.
+This fixes the perf bug
+caused by Iced repeatedly calling `palette`.
+
+Coincidentally, this also ensures consistent colors across the GUI,
+at the cost of requiring a restart to update the palette.
+(this is just a patch, not a fix)
+*/
+pub static OS_COLOR_SCHEME: LazyLock =
+ LazyLock::new(|| dark_light::detect().unwrap_or(dark_light::Mode::Unspecified));
#[derive(Default, Debug, PartialEq, Eq, Copy, Clone)]
/// Color scheme
@@ -24,7 +37,7 @@ pub struct BaseColors {
#[derive(Debug, Clone, Copy)]
pub struct NormalColors {
pub primary: Color,
- #[allow(dead_code)]
+ #[allow(dead_code, reason = "Reserved for future palette updates")]
pub secondary: Color,
pub surface: Color,
pub error: Color,
@@ -52,6 +65,8 @@ impl Theme {
clippy::unreadable_literal,
reason = "https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/pull/578#discussion_r1759653408"
)]
+ /// This `fn` _could_ be `const`,
+ /// but `deref`ing a lazy-`static` is non-`const`.
#[must_use]
pub fn palette(self) -> ColorPalette {
const DARK: ColorPalette = ColorPalette {
@@ -112,11 +127,9 @@ impl Theme {
Self::Dark => DARK,
Self::Light => LIGHT,
Self::Lupin => LUPIN,
- #[allow(clippy::match_same_arms)]
- Self::Auto => match dark_light::detect() {
+ Self::Auto => match *OS_COLOR_SCHEME {
dark_light::Mode::Light => LIGHT,
- dark_light::Mode::Dark => DARK,
- dark_light::Mode::Default => DARK,
+ dark_light::Mode::Dark | dark_light::Mode::Unspecified => DARK,
},
}
}
@@ -136,3 +149,71 @@ impl std::fmt::Display for Theme {
)
}
}
+
+/// Converts a string to the GUI's Theme type
+#[must_use]
+pub fn string_to_theme(theme: &str) -> Theme {
+ match theme {
+ "Lupin" => Theme::Lupin,
+ "Dark" => Theme::Dark,
+ "Light" => Theme::Light,
+ _ => Theme::Auto,
+ }
+}
+
+impl theme::Base for Theme {
+ fn default(preference: Mode) -> Self {
+ match preference {
+ Mode::Light => Self::Light,
+ Mode::Dark => Self::Dark,
+ Mode::None => match *OS_COLOR_SCHEME {
+ dark_light::Mode::Light => Self::Light,
+ dark_light::Mode::Dark | dark_light::Mode::Unspecified => Self::Dark,
+ },
+ }
+ }
+
+ fn mode(&self) -> Mode {
+ let resolved = match self {
+ Self::Auto => match *OS_COLOR_SCHEME {
+ dark_light::Mode::Light => Self::Light,
+ dark_light::Mode::Dark | dark_light::Mode::Unspecified => Self::Dark,
+ },
+ other => *other,
+ };
+
+ match resolved {
+ Self::Light => Mode::Light,
+ _ => Mode::Dark,
+ }
+ }
+
+ fn base(&self) -> Style {
+ let p = Self::palette(*self);
+ Style {
+ background_color: p.base.background,
+ text_color: p.bright.surface,
+ }
+ }
+
+ fn palette(&self) -> Option {
+ let p = Self::palette(*self);
+ Some(Palette {
+ background: p.base.background,
+ text: p.bright.surface,
+ primary: p.normal.primary,
+ success: p.bright.secondary,
+ warning: p.normal.surface,
+ danger: p.normal.error,
+ })
+ }
+
+ fn name(&self) -> &str {
+ match self {
+ Self::Dark => "Dark",
+ Self::Light => "Light",
+ Self::Lupin => "Lupin",
+ Self::Auto => "Auto",
+ }
+ }
+}
diff --git a/crates/uad-gui/src/views/about.rs b/crates/uad-gui/src/views/about.rs
new file mode 100644
index 0000000..42cb723
--- /dev/null
+++ b/crates/uad-gui/src/views/about.rs
@@ -0,0 +1,174 @@
+use crate::helpers::button_primary;
+use crate::theme::Theme;
+use crate::{gui::UpdateState, style, widgets::text};
+use iced::widget::{Space, column, container, row};
+use iced::{Alignment, Element, Length, Renderer};
+use log::error;
+use std::path::PathBuf;
+use uad_core::CACHE_DIR;
+use uad_core::adb;
+use uad_core::uad_lists::LIST_FNAME;
+use uad_core::utils::{FULL_NAME, NAME, last_modified_date, open_url};
+
+#[cfg(feature = "self-update")]
+use uad_core::update::SelfUpdateStatus;
+
+#[derive(Default, Debug, Clone)]
+pub struct About {}
+
+#[derive(Debug, Clone)]
+pub enum Message {
+ UrlPressed(PathBuf),
+ UpdateUadLists,
+ DoSelfUpdate,
+}
+
+impl About {
+ #[allow(
+ clippy::unused_self,
+ reason = "Trait-like shape required by GUI architecture"
+ )]
+ pub fn update(&mut self, msg: Message) {
+ if let Message::UrlPressed(url) = msg {
+ open_url(url);
+ }
+ // other events are handled by UadGui update()
+ }
+ #[allow(
+ clippy::unused_self,
+ reason = "Trait-like shape required by GUI architecture"
+ )]
+ pub fn view(&self, update_state: &UpdateState) -> Element<'_, Message, Theme, Renderer> {
+ let about_text = text(format!(
+ "{FULL_NAME} ({NAME}) is a free and open-source community project \naiming at simplifying the removal of pre-installed apps on any Android device."
+ ));
+
+ let descr_container = container(about_text)
+ .width(Length::Fill)
+ .padding(25)
+ .style(style::Container::Frame);
+
+ let date = last_modified_date(CACHE_DIR.join(LIST_FNAME));
+ let uad_list_text =
+ text(format!("{NAME} package list: v{}", date.format("%Y%m%d"))).width(250);
+ let last_update_text = text(update_state.uad_list.to_string());
+ let uad_lists_btn = button_primary("Update").on_press(Message::UpdateUadLists);
+
+ #[cfg(feature = "self-update")]
+ let self_update_row = {
+ let self_update_btn = button_primary("Update").on_press(Message::DoSelfUpdate);
+
+ let uad_version_text =
+ text(format!("{NAME} version: v{}", env!("CARGO_PKG_VERSION"))).width(250);
+
+ let self_update_text = update_state
+ .self_update
+ .latest_release
+ .as_ref()
+ .map_or_else(
+ || {
+ if update_state.self_update.status == SelfUpdateStatus::Done {
+ "(No update available)".to_string()
+ } else {
+ update_state.self_update.status.to_string()
+ }
+ },
+ |r| {
+ if update_state.self_update.status == SelfUpdateStatus::Updating {
+ update_state.self_update.status.to_string()
+ } else {
+ format!("({} available)", r.tag_name)
+ }
+ },
+ );
+
+ let last_self_update_text = text(self_update_text).style(style::Text::Default);
+
+ row![uad_version_text, self_update_btn, last_self_update_text,]
+ .align_y(Alignment::Center)
+ .spacing(10)
+ .width(550)
+ };
+
+ let uad_list_row = row![uad_list_text, uad_lists_btn, last_update_text,]
+ .align_y(Alignment::Center)
+ .spacing(10)
+ .width(550);
+
+ /*
+ There's no need to fetch this info every time the view is updated,
+ we could cache it in a `static` `LazyLock`.
+
+ But what if the system updates ADB while the app is running?
+ the numbers will be out of sync!
+
+ However, the server will still be the "old" version
+ until it's killed
+ */
+ let adb_version_text = text(match adb::ACommand::new().version() {
+ Ok(s) => s
+ .lines()
+ .nth(0)
+ .unwrap_or_else(|| unreachable!())
+ // This allocation is good.
+ // If it was a ref, the app would hold the entire string
+ // instead of the relevant slice.
+ .to_string(),
+ Err(e) => {
+ error!("{e}");
+ "Couldn't fetch ADB version. Is it installed?".into()
+ // satisfy `match` by inferring the type of the `Ok` arm
+ }
+ })
+ .width(250);
+ let adb_version_row = row![adb_version_text].align_y(Alignment::Center).width(550);
+
+ #[cfg(feature = "self-update")]
+ let update_column = column![uad_list_row, self_update_row, adb_version_row];
+ #[cfg(not(feature = "self-update"))]
+ let update_column = column![uad_list_row, adb_version_row];
+
+ let update_column = update_column.align_x(Alignment::Center).spacing(10);
+
+ let update_container = container(update_column)
+ .width(Length::Fill)
+ .center_x(Length::Fill)
+ .padding(10)
+ .style(style::Container::Frame);
+
+ let website_btn =
+ button_primary("GitHub page").on_press(Message::UrlPressed(PathBuf::from(
+ "https://github.com/Universal-Debloater-Alliance/universal-android-debloater",
+ )));
+
+ let issue_btn = button_primary("Have an issue?")
+ .on_press(Message::UrlPressed(PathBuf::from(
+ "https://github.com/Universal-Debloater-Alliance/universal-android-debloater/issues",
+ )));
+
+ let log_btn = button_primary("Locate the logfiles")
+ .on_press(Message::UrlPressed(CACHE_DIR.to_path_buf()));
+
+ let wiki_btn = button_primary("Wiki").on_press(Message::UrlPressed(PathBuf::from(
+ "https://github.com/Universal-Debloater-Alliance/universal-android-debloater/wiki",
+ )));
+
+ let row = row![website_btn, wiki_btn, issue_btn, log_btn,].spacing(20);
+
+ let content = column![
+ Space::new().width(Length::Fill).height(Length::Shrink),
+ descr_container,
+ update_container,
+ row,
+ ]
+ .width(Length::Fill)
+ .spacing(20)
+ .align_x(Alignment::Center);
+
+ container(content)
+ .width(Length::Fill)
+ .height(Length::Fill)
+ .padding(10)
+ .into()
+ }
+}
diff --git a/crates/uad-gui/src/views/list.rs b/crates/uad-gui/src/views/list.rs
new file mode 100644
index 0000000..a9792dd
--- /dev/null
+++ b/crates/uad-gui/src/views/list.rs
@@ -0,0 +1,1597 @@
+use crate::helpers::button_primary;
+use crate::style;
+use crate::theme::Theme;
+use crate::widgets::navigation_menu::ICONS;
+use log::{error, info, warn};
+use std::path::PathBuf;
+use uad_core::config::DeviceSettings;
+use uad_core::sync::{AdbError, Phone, User, apply_pkg_state_commands};
+use uad_core::uad_lists::{
+ Opposite, PackageHashMap, PackageState, Removal, UadList, UadListState, load_debloat_lists,
+};
+use uad_core::utils::{
+ EXPORT_FILE_NAME, NAME, export_selection, fetch_packages, matches_search, open_url,
+};
+
+use crate::views::settings::Settings;
+use crate::widgets::modal::Modal;
+use crate::widgets::package_row::{Message as RowMessage, PackageRow};
+use crate::widgets::text;
+use iced::widget::scrollable::{Direction, Scrollbar};
+use iced::widget::{
+ Column, Space, button, checkbox, column, container, pick_list, radio, row, rule, scrollable,
+ text_editor, text_input, tooltip,
+};
+use iced::{Alignment, Element, Length, Renderer, Task, alignment};
+
+#[derive(Debug, Default, Clone)]
+pub struct PackageInfo {
+ pub i_user: usize,
+ pub index: usize,
+ pub removal: String,
+ pub before_cross_user_states: Vec<(u16, PackageState)>,
+}
+
+#[derive(Default, Debug, Clone)]
+pub enum LoadingState {
+ DownloadingList,
+ #[default]
+ FindingPhones,
+ LoadingPackages,
+ _UpdatingUad,
+ Ready,
+ RestoringDevice(String),
+ FailedToUpdate,
+}
+
+#[derive(Default, Debug)]
+#[allow(clippy::struct_excessive_bools, reason = "Not a state-machine")]
+pub struct List {
+ pub loading_state: LoadingState,
+ pub uad_lists: PackageHashMap,
+ /// packages of all users of the phone
+ pub phone_packages: Vec>,
+ /// `phone_packages` indexes of the selected user (= what you see on screen)
+ filtered_packages: Vec,
+ /// Vec of `(user_index, pkg_index)`
+ selected_packages: Vec<(usize, usize)>,
+ selected_removal: Option,
+ selected_package_state: Option,
+ selected_list: Option,
+ pub selected_user: Option,
+ all_selected: bool,
+ pub input_value: String,
+ description: String,
+ description_content: text_editor::Content,
+ selection_modal: bool,
+ error_modal: Option,
+ export_modal: bool,
+ current_package_index: usize,
+ is_adb_satisfied: bool,
+ copy_confirmation: bool,
+ fallback_notifications: Vec,
+}
+
+#[derive(Debug, Clone)]
+pub enum Message {
+ LoadUadList(bool),
+ LoadPhonePackages((PackageHashMap, UadListState)),
+ RestoringDevice(Result),
+ ApplyFilters(Vec>),
+ DismissFallbackNotifications,
+ VerifyAndFallbackFinished(VerifyAndFallbackResult),
+ SearchInputChanged(String),
+ ToggleAllSelected(bool),
+ ListSelected(UadList),
+ UserSelected(User),
+ RemovalSelected(Removal),
+ PackageStateSelected(PackageState),
+ ApplyActionOnSelection,
+ List(usize, RowMessage),
+ VerifyAndFallback(Result),
+ Nothing,
+ ModalHide,
+ ModalUserSelected(User),
+ ModalValidate,
+ ClearSelectedPackages,
+ ADBSatisfied(bool),
+ UpdateFailed,
+ GoToUrl(PathBuf),
+ ExportSelection,
+ SelectionExported(Result),
+ DescriptionEdit(text_editor::Action),
+ CopyError(String),
+ HideCopyConfirmation,
+}
+
+pub struct SummaryEntry {
+ category: Removal,
+ discard: u8,
+ restore: u8,
+}
+
+#[derive(Debug, Clone)]
+pub struct VerifyAndFallbackResult {
+ pub i_user: usize,
+ pub index: usize,
+ pub new_state: PackageState,
+ pub notification: Option,
+ pub error_modal: Option,
+}
+
+impl From for SummaryEntry {
+ fn from(category: Removal) -> Self {
+ Self {
+ category,
+ discard: 0,
+ restore: 0,
+ }
+ }
+}
+
+impl List {
+ pub fn update(
+ &mut self,
+ settings: &mut Settings,
+ selected_device: &mut Phone,
+ list_update_state: &mut UadListState,
+ message: Message,
+ ) -> Task {
+ match message {
+ Message::ModalHide => self.on_modal_hide(),
+ Message::ModalValidate => self.on_modal_validate(settings, selected_device),
+ Message::RestoringDevice(output) => self.on_restoring_device(output),
+ Message::LoadUadList(remote) => self.on_load_uad_list(remote, selected_device),
+ Message::LoadPhonePackages(payload) => {
+ self.on_load_phone_packages(payload, selected_device, list_update_state)
+ }
+ Message::ApplyFilters(packages) => self.on_apply_filters(packages),
+ Message::DismissFallbackNotifications => self.on_dismiss_fallback_notifications(),
+ Message::ToggleAllSelected(selected) => {
+ self.on_toggle_all_selected(selected, settings, selected_device, list_update_state)
+ }
+ Message::SearchInputChanged(letter) => self.on_search_input_changed(letter),
+ Message::ListSelected(list) => self.on_list_selected(list),
+ Message::RemovalSelected(removal) => self.on_removal_selected(removal),
+ Message::PackageStateSelected(state) => self.on_package_state_selected(state),
+ Message::List(i, row_msg) => self.on_list_row(i, &row_msg, settings, selected_device),
+ Message::ApplyActionOnSelection => self.on_apply_action_on_selection(),
+ Message::UserSelected(user) => self.on_user_selected(user),
+ Message::VerifyAndFallback(res) => {
+ self.on_verify_and_fallback(res, settings, selected_device)
+ }
+ Message::VerifyAndFallbackFinished(result) => {
+ self.on_verify_and_fallback_finished(result)
+ }
+ Message::ModalUserSelected(user) => {
+ self.on_modal_user_selected(user, settings, selected_device, list_update_state)
+ }
+ Message::ClearSelectedPackages => self.on_clear_selected_packages(),
+ Message::ADBSatisfied(result) => self.on_adb_satisfied(result),
+ Message::UpdateFailed => self.on_update_failed(),
+ Message::GoToUrl(url) => Self::on_go_to_url(url),
+ Message::ExportSelection => self.on_export_selection(),
+ Message::SelectionExported(res) => self.on_selection_exported(res),
+ Message::Nothing => Task::none(),
+ Message::DescriptionEdit(action) => self.on_description_edit(action),
+ Message::CopyError(err) => self.on_copy_error(err),
+ Message::HideCopyConfirmation => self.on_hide_copy_confirmation(),
+ }
+ }
+
+ // Handle verification completion on the UI thread after async work
+ fn on_verify_and_fallback_finished(
+ &mut self,
+ result: VerifyAndFallbackResult,
+ ) -> Task {
+ let package = &mut self.phone_packages[result.i_user][result.index];
+ if let Some(notification) = result.notification {
+ self.fallback_notifications.push(notification);
+ }
+ if let Some(err) = result.error_modal {
+ self.error_modal = Some(err);
+ }
+ package.state = result.new_state;
+ package.selected = false;
+ self.selected_packages
+ .retain(|&x| x.1 != result.index && x.0 != result.i_user);
+ Self::filter_package_lists(self);
+ Task::none()
+ }
+
+ /// Builds the main view for the app list interface
+ pub fn view(
+ &self,
+ settings: &Settings,
+ selected_device: &Phone,
+ ) -> Element<'_, Message, Theme, Renderer> {
+ match &self.loading_state {
+ LoadingState::DownloadingList => waiting_view(
+ &format!("Downloading latest {NAME} lists from GitHub. Please wait..."),
+ Some(button("No internet?").on_press(Message::LoadUadList(false))),
+ style::Text::Default,
+ ),
+ LoadingState::FindingPhones => {
+ if self.is_adb_satisfied {
+ waiting_view("Finding connected devices...", None, style::Text::Default)
+ } else {
+ waiting_view(
+ "ADB is not installed on your system, install ADB and relaunch application.",
+ Some(button("Read on how to get started.")
+ .on_press(Message::GoToUrl(PathBuf::from(
+ "https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki/Getting-started",
+ )))),
+ style::Text::Danger,
+ )
+ }
+ }
+ LoadingState::LoadingPackages => waiting_view(
+ "Pulling packages from the device. Please wait...",
+ None,
+ style::Text::Default,
+ ),
+ LoadingState::_UpdatingUad => waiting_view(
+ &format!("Updating {NAME}. Please wait..."),
+ None,
+ style::Text::Default,
+ ),
+ LoadingState::RestoringDevice(device) => waiting_view(
+ &format!("Restoring device: {device}"),
+ None,
+ style::Text::Default,
+ ),
+ LoadingState::Ready => self.ready_view(settings, selected_device),
+ LoadingState::FailedToUpdate => waiting_view(
+ "Failed to download update",
+ Some(button("Go back").on_press(Message::LoadUadList(false))),
+ style::Text::Danger,
+ ),
+ }
+ }
+
+ fn control_panel(&self, selected_device: &Phone) -> Element<'_, Message, Theme, Renderer> {
+ let search_packages = text_input("Search packages...", &self.input_value)
+ .width(Length::Fill)
+ .on_input(Message::SearchInputChanged)
+ .padding([5, 10]);
+
+ let select_all_checkbox = checkbox(self.all_selected)
+ .on_toggle(Message::ToggleAllSelected)
+ .size(20)
+ .style(style::CheckBox::SettingsEnabled)
+ .spacing(0); // no label, so remove space entirely
+
+ let col_sel_all = row![
+ tooltip(
+ select_all_checkbox,
+ if self.all_selected {
+ "Deselect all"
+ } else {
+ "Select all"
+ },
+ tooltip::Position::Top,
+ )
+ .style(style::Container::Tooltip)
+ .gap(4)
+ ]
+ .padding(8);
+
+ let user_picklist = pick_list(
+ selected_device.user_list.clone(),
+ self.selected_user,
+ Message::UserSelected,
+ )
+ .width(85);
+
+ let list_picklist =
+ pick_list(UadList::ALL, self.selected_list, Message::ListSelected).width(96);
+
+ let package_state_picklist = pick_list(
+ PackageState::ALL,
+ self.selected_package_state,
+ Message::PackageStateSelected,
+ )
+ .width(120);
+
+ let removal_picklist = pick_list(
+ Removal::ALL,
+ self.selected_removal,
+ Message::RemovalSelected,
+ )
+ .width(150);
+
+ row![
+ col_sel_all,
+ search_packages,
+ user_picklist,
+ removal_picklist,
+ package_state_picklist,
+ list_picklist,
+ ]
+ .width(Length::Fill)
+ .align_y(Alignment::Center)
+ .spacing(6)
+ .padding(iced::Padding {
+ top: 0.0,
+ right: 16.0,
+ bottom: 0.0,
+ left: 0.0,
+ })
+ .into()
+ }
+
+ #[allow(
+ clippy::too_many_lines,
+ reason = "Complex layout; further refactor later"
+ )]
+ fn ready_view(
+ &self,
+ settings: &Settings,
+ selected_device: &Phone,
+ ) -> Element<'_, Message, Theme, Renderer> {
+ let packages = self
+ .filtered_packages
+ .iter()
+ .fold(column![].spacing(6), |col, &i| {
+ col.push(
+ self.phone_packages[self.selected_user.unwrap_or_default().index][i]
+ .view(settings, selected_device)
+ .map(move |msg| Message::List(i, msg)),
+ )
+ });
+
+ let packages_scrollable = scrollable(packages)
+ .height(Length::FillPortion(6))
+ .style(style::Scrollable::Packages);
+
+ let description_scroll =
+ scrollable(text_editor(&self.description_content).on_action(Message::DescriptionEdit))
+ .style(style::Scrollable::Description);
+
+ let description_panel = container(description_scroll)
+ .padding(6)
+ .height(Length::FillPortion(2))
+ .width(Length::Fill)
+ .style(style::Container::Frame);
+
+ let review_selection = {
+ let tmp_widget = text(format!(
+ "Review selection ({})",
+ self.selected_packages.len()
+ ));
+ if self.selected_packages.is_empty() {
+ button(tmp_widget).padding([5, 10])
+ } else {
+ button_primary(tmp_widget).on_press(Message::ApplyActionOnSelection)
+ }
+ };
+
+ let mut export_selection = button(text(format!(
+ "Export current selection ({})",
+ self.selected_packages.len()
+ )))
+ .padding([5, 10]);
+ if !self.selected_packages.is_empty() {
+ export_selection = export_selection
+ .on_press(Message::ExportSelection)
+ .style(style::Button::Primary);
+ }
+ // lock
+ let export_selection = export_selection;
+
+ let action_row = row![
+ export_selection,
+ Space::new().width(Length::Fill).height(Length::Shrink),
+ review_selection
+ ]
+ .width(Length::Fill)
+ .spacing(10)
+ .align_y(Alignment::Center);
+
+ let unavailable = container(
+ column![
+ text("ADB is not authorized to access this user!").size(20)
+ .style(style::Text::Danger),
+ text("The most likely reason is that it is the user of your work profile (also called Secure Folder on Samsung devices). There's really no solution, other than completely disabling your work profile in your device settings.")
+ .style(style::Text::Commentary)
+ .align_x(alignment::Horizontal::Center),
+ ]
+ .spacing(6)
+ .align_x(Alignment::Center)
+ )
+ .padding(10)
+ .center_x(Length::Shrink)
+ .style(style::Container::BorderedFrame);
+
+ let control_panel = self.control_panel(selected_device);
+
+ // Fallback notifications area
+ let notifications_area: Element<'_, Message, Theme, Renderer> =
+ if self.fallback_notifications.is_empty() {
+ Space::new().into()
+ } else {
+ let notification_texts: Vec<_> = self
+ .fallback_notifications
+ .iter()
+ .map(|msg| text(msg).style(style::Text::Commentary).into())
+ .collect();
+
+ container(
+ column![
+ text("Fallback Actions Performed:").style(style::Text::Default),
+ column(notification_texts).spacing(4),
+ row![
+ Space::new().width(Length::Fill).height(Length::Shrink),
+ button(text("Dismiss"))
+ .on_press(Message::DismissFallbackNotifications)
+ .style(style::Button::Primary)
+ .padding([4, 10]),
+ ]
+ ]
+ .spacing(6),
+ )
+ .padding(8)
+ .style(style::Container::BorderedFrame)
+ .into()
+ };
+
+ let content = if selected_device.user_list.is_empty()
+ || match self.selected_user {
+ Some(u) => !self.phone_packages[u.index].is_empty(),
+ // If no user has been selected,
+ // then it could be considered as "equivalent"
+ // to the case where the `user_list` is empty?
+ // However, this is inconsistent,
+ // because other parts of the code simply use a `default` `User`.
+ None => true,
+ } {
+ column![
+ control_panel,
+ notifications_area,
+ packages_scrollable,
+ description_panel,
+ action_row,
+ ]
+ } else {
+ column![
+ control_panel,
+ notifications_area,
+ container(unavailable)
+ .height(Length::Fill)
+ .center_y(Length::Fill),
+ ]
+ }
+ .width(Length::Fill)
+ .spacing(10)
+ .align_x(Alignment::Center);
+
+ if self.selection_modal {
+ return Modal::new(
+ content.padding(10),
+ self.apply_selection_modal(
+ selected_device,
+ settings,
+ &self.phone_packages[self.selected_user.unwrap_or_default().index],
+ ),
+ )
+ .on_blur(Message::ModalHide)
+ .into();
+ }
+
+ if self.export_modal {
+ let title = container(row![text("Success").size(24)].align_y(Alignment::Center))
+ .width(Length::Fill)
+ .style(style::Container::Frame)
+ .padding([10, 0])
+ .center_y(Length::Shrink)
+ .center_x(Length::Shrink);
+
+ let text_box = row![
+ text(format!("Exported current selection into file.\nFile is exported in same directory where {NAME} is located.")).width(Length::Fill),
+ ].padding(20);
+
+ let file_row = row![text(EXPORT_FILE_NAME).style(style::Text::Commentary)].padding(20);
+
+ let modal_btn_row = row![
+ Space::new().width(Length::Fill).height(Length::Shrink),
+ button(text("Close").width(Length::Shrink))
+ .width(Length::Shrink)
+ .on_press(Message::ModalHide),
+ Space::new().width(Length::Fill).height(Length::Shrink),
+ ];
+
+ let ctn = container(column![title, text_box, file_row, modal_btn_row])
+ .height(Length::Shrink)
+ .width(500)
+ .padding(10)
+ .style(style::Container::Frame);
+
+ return Modal::new(content.padding(10), ctn)
+ .on_blur(Message::ModalHide)
+ .into();
+ }
+
+ if let Some(err) = &self.error_modal {
+ error_view(err, content, self.copy_confirmation).into()
+ } else {
+ container(content).height(Length::Fill).padding(10).into()
+ }
+ }
+
+ #[allow(
+ clippy::too_many_lines,
+ reason = "Modal construction is verbose by nature"
+ )]
+ fn apply_selection_modal(
+ &self,
+ device: &Phone,
+ settings: &Settings,
+ packages: &[PackageRow],
+ ) -> Element<'_, Message, Theme, Renderer> {
+ const PACK_NO_USER_MSG: &str = "`selected_packages` implies a user must be selected";
+
+ // 5 element slice is cheap
+ let mut summaries = Removal::CATEGORIES.map(SummaryEntry::from);
+ for p in packages.iter().filter(|p| p.selected) {
+ let summary = &mut summaries[p.removal as usize];
+ match p.state {
+ PackageState::Uninstalled | PackageState::Disabled => summary.restore += 1,
+ _ => summary.discard += 1,
+ }
+ }
+
+ let radio_btn_users = device.user_list.iter().filter(|&u| !u.protected).fold(
+ row![].spacing(10),
+ |row, &user| {
+ row.push(
+ radio(
+ format!("{}", user.clone()),
+ user,
+ self.selected_user,
+ Message::ModalUserSelected,
+ )
+ .size(24),
+ )
+ },
+ );
+
+ let title_ctn =
+ container(row![text("Review your selection").size(24)].align_y(Alignment::Center))
+ .width(Length::Fill)
+ .style(style::Container::Frame)
+ .padding([10, 0])
+ .center_y(Length::Shrink)
+ .center_x(Length::Fill);
+
+ let users_ctn = container(radio_btn_users)
+ .padding(10)
+ .center_x(Length::Shrink)
+ .style(style::Container::Frame);
+
+ let explaination_ctn = container(
+ row![
+ text("The action for the selected user will be applied to all other users")
+ .style(style::Text::Danger),
+ tooltip(
+ text("\u{EA0C}")
+ .font(ICONS)
+ .width(22)
+ .align_x(alignment::Horizontal::Center)
+ .style(style::Text::Commentary),
+ "Let's say you choose user 0. If a selected package on user 0\n\
+ is set to be uninstalled and if this same package is disabled on user 10,\n\
+ then the package on both users will be uninstalled.",
+ tooltip::Position::Top,
+ )
+ .gap(20)
+ .padding(10)
+ .style(style::Container::Tooltip)
+ ]
+ .spacing(10),
+ )
+ .center_x(Length::Shrink)
+ .padding(10)
+ .style(style::Container::BorderedFrame);
+
+ let modal_btn_row = row![
+ button(text("Cancel")).on_press(Message::ModalHide),
+ Space::new().width(Length::Fill),
+ button(text("Apply")).on_press(Message::ModalValidate),
+ ]
+ .padding(iced::Padding {
+ top: 0.0,
+ right: 15.0,
+ bottom: 10.0,
+ left: 10.0,
+ });
+
+ let recap_view = summaries
+ .iter()
+ .fold(column![].spacing(6).width(Length::Fill), |col, r| {
+ col.push(recap(settings, r))
+ });
+
+ let selected_pkgs_ctn = container(
+ container(
+ scrollable(
+ container(
+ if self
+ .selected_packages
+ .iter()
+ .any(|s| s.0 == self.selected_user.expect(PACK_NO_USER_MSG).index)
+ {
+ self.selected_packages
+ .iter()
+ .filter(|s| {
+ s.0 == self.selected_user.expect(PACK_NO_USER_MSG).index
+ })
+ .fold(
+ column![].spacing(6).width(Length::Shrink),
+ |col, selection| {
+ col.push(
+ row![
+ row![text(
+ self.phone_packages[selection.0][selection.1]
+ .removal
+ .to_string()
+ )]
+ .width(120),
+ row![text(
+ self.phone_packages[selection.0][selection.1]
+ .list
+ .to_string()
+ )]
+ .width(55),
+ row![text(
+ self.phone_packages[selection.0][selection.1]
+ .name
+ .clone()
+ ),]
+ .width(540),
+ row![match self.phone_packages[selection.0]
+ [selection.1]
+ .state
+ {
+ PackageState::Enabled =>
+ if settings.device.disable_mode {
+ text("Disable")
+ .style(style::Text::Danger)
+ } else {
+ text("Uninstall")
+ .style(style::Text::Danger)
+ },
+ PackageState::Disabled =>
+ text("Enable").style(style::Text::Ok),
+ PackageState::Uninstalled =>
+ text("Restore").style(style::Text::Ok),
+ PackageState::All => text("Impossible")
+ .style(style::Text::Danger),
+ },]
+ .width(70),
+ ]
+ .width(Length::Shrink)
+ .spacing(20),
+ )
+ },
+ )
+ } else {
+ column![text("No packages selected for this user")]
+ .align_x(Alignment::Center)
+ .width(Length::Fill)
+ },
+ )
+ .padding(10)
+ .width(Length::Shrink)
+ .style(style::Container::Invisible),
+ )
+ .direction(Direction::Both {
+ vertical: Scrollbar::default(),
+ horizontal: Scrollbar::default(),
+ })
+ .style(style::Scrollable::Description),
+ )
+ .width(Length::Fill)
+ .style(style::Container::Frame),
+ )
+ .width(Length::Fill)
+ .max_height(150)
+ .padding([0, 10]);
+
+ container(
+ if device.user_list.iter().filter(|&u| !u.protected).count() > 1
+ && settings.device.multi_user_mode
+ {
+ column![
+ title_ctn,
+ users_ctn,
+ row![explaination_ctn].padding([0, 10]),
+ container(recap_view).padding(10),
+ selected_pkgs_ctn,
+ modal_btn_row,
+ ]
+ .spacing(10)
+ .align_x(Alignment::Center)
+ } else if !settings.device.multi_user_mode {
+ column![
+ title_ctn,
+ users_ctn,
+ container(recap_view).padding(10),
+ selected_pkgs_ctn,
+ modal_btn_row,
+ ]
+ .spacing(10)
+ .align_x(Alignment::Center)
+ } else {
+ column![
+ title_ctn,
+ container(recap_view).padding(10),
+ selected_pkgs_ctn,
+ modal_btn_row,
+ ]
+ .spacing(10)
+ .align_x(Alignment::Center)
+ },
+ )
+ .width(900)
+ .height(Length::Shrink)
+ .max_height(700)
+ .style(style::Container::Background)
+ .into()
+ }
+
+ fn filter_package_lists(&mut self) {
+ let list_filter: UadList = self.selected_list.expect("UAD-list type must be selected");
+ let package_filter: PackageState = self
+ .selected_package_state
+ .expect("pack-state must be selected");
+ let removal_filter: Removal = self
+ .selected_removal
+ .expect("removal recommendation must be selected");
+
+ self.filtered_packages = self.phone_packages
+ [self.selected_user.expect("User must be selected").index]
+ .iter()
+ // we must filter the indices associated with pack-rows,
+ // that's why `enumerate` is before `filter`.
+ .enumerate()
+ .filter(|(_, p)| {
+ (list_filter == UadList::All || p.list == list_filter)
+ && (package_filter == PackageState::All || p.state == package_filter)
+ && (removal_filter == Removal::All || p.removal == removal_filter)
+ && (self.input_value.is_empty()
+ || matches_search(&p.name, &self.input_value, Some(&p.description)))
+ })
+ .map(|(i, _)| i)
+ .collect();
+ }
+
+ #[expect(clippy::unused_async, reason = "1 call-site")]
+ async fn load_packages>(
+ uad_list: PackageHashMap,
+ device_serial: S,
+ user_list: Vec,
+ ) -> Vec> {
+ let serial = device_serial.as_ref();
+ if user_list.len() <= 1 {
+ vec![
+ fetch_packages(&uad_list, serial, None)
+ .into_iter()
+ .map(PackageRow::from)
+ .collect(),
+ ]
+ } else {
+ user_list
+ .iter()
+ .map(|user| {
+ fetch_packages(&uad_list, serial, Some(user.id))
+ .into_iter()
+ .map(PackageRow::from)
+ .collect()
+ })
+ .collect()
+ }
+ }
+
+ #[expect(clippy::unused_async, reason = "1 call-site")]
+ async fn init_apps_view(remote: bool, phone: Phone) -> (PackageHashMap, UadListState) {
+ let uad_lists = load_debloat_lists(remote);
+ match uad_lists {
+ Ok(list) => {
+ if phone.adb_id.is_empty() {
+ warn!("AppsView ready but no phone found");
+ }
+ (list, UadListState::Done)
+ }
+ Err(local_list) => {
+ error!(
+ "Error loading remote debloat list for the phone. Fallback to embedded (and outdated) list"
+ );
+ (local_list, UadListState::Failed)
+ }
+ }
+ }
+
+ // === Split handlers to keep update short ===
+ fn on_modal_hide(&mut self) -> Task {
+ self.selection_modal = false;
+ self.error_modal = None;
+ self.export_modal = false;
+ Task::none()
+ }
+
+ fn on_modal_validate(
+ &mut self,
+ settings: &Settings,
+ selected_device: &mut Phone,
+ ) -> Task {
+ self.fallback_notifications.clear();
+ let mut commands = vec![];
+ self.selected_packages.sort_unstable();
+ self.selected_packages.dedup();
+ for selection in &self.selected_packages {
+ commands.append(&mut build_action_pkg_commands(
+ &self.phone_packages,
+ selected_device,
+ &settings.device,
+ *selection,
+ ));
+ }
+ self.selection_modal = false;
+ Task::batch(commands)
+ }
+
+ fn on_restoring_device(&mut self, output: Result) -> Task {
+ let i_user = self.selected_user.unwrap_or_default().index;
+ if let Ok(p) = output {
+ self.loading_state =
+ LoadingState::RestoringDevice(self.phone_packages[i_user][p.index].name.clone());
+ } else {
+ self.loading_state = LoadingState::RestoringDevice("Error [TODO]".to_string());
+ }
+ Task::none()
+ }
+
+ fn on_load_uad_list(&mut self, remote: bool, selected_device: &Phone) -> Task {
+ info!("{:-^65}", "-");
+ info!(
+ "ANDROID_SDK: {} | DEVICE: {}",
+ selected_device.android_sdk, selected_device.model
+ );
+ info!("{:-^65}", "-");
+ self.loading_state = LoadingState::DownloadingList;
+ Task::perform(
+ Self::init_apps_view(remote, selected_device.clone()),
+ Message::LoadPhonePackages,
+ )
+ }
+
+ fn on_load_phone_packages(
+ &mut self,
+ payload: (PackageHashMap, UadListState),
+ selected_device: &Phone,
+ list_update_state: &mut UadListState,
+ ) -> Task {
+ let (uad_list, list_state) = payload;
+ self.loading_state = LoadingState::LoadingPackages;
+ self.uad_lists.clone_from(&uad_list);
+ *list_update_state = list_state;
+ Task::perform(
+ Self::load_packages(
+ uad_list,
+ selected_device.adb_id.clone(),
+ selected_device.user_list.clone(),
+ ),
+ Message::ApplyFilters,
+ )
+ }
+
+ fn on_apply_filters(&mut self, packages: Vec>) -> Task {
+ let i_user = self.selected_user.unwrap_or_default().index;
+ self.phone_packages = packages;
+ self.filtered_packages = (0..self.phone_packages[i_user].len()).collect();
+ self.selected_removal = Some(Removal::Recommended);
+ self.selected_package_state = Some(PackageState::Enabled);
+ self.selected_list = Some(UadList::All);
+ self.selected_user = Some(User::default());
+ self.fallback_notifications.clear();
+ Self::filter_package_lists(self);
+ self.loading_state = LoadingState::Ready;
+ Task::none()
+ }
+
+ fn on_toggle_all_selected(
+ &mut self,
+ selected: bool,
+ settings: &mut Settings,
+ selected_device: &mut Phone,
+ list_update_state: &mut UadListState,
+ ) -> Task {
+ let i_user = self.selected_user.unwrap_or_default().index;
+ for i in self.filtered_packages.clone() {
+ if self.phone_packages[i_user][i].selected != selected {
+ #[expect(unused_must_use, reason = "side-effect")]
+ self.update(
+ settings,
+ selected_device,
+ list_update_state,
+ Message::List(i, RowMessage::ToggleSelection(selected)),
+ );
+ }
+ }
+ self.all_selected = selected;
+ Task::none()
+ }
+
+ fn on_search_input_changed(&mut self, letter: String) -> Task {
+ self.input_value = letter;
+ Self::filter_package_lists(self);
+ Task::none()
+ }
+
+ fn on_list_selected(&mut self, list: UadList) -> Task {
+ self.selected_list = Some(list);
+ Self::filter_package_lists(self);
+ Task::none()
+ }
+
+ fn on_package_state_selected(&mut self, package_state: PackageState) -> Task {
+ self.selected_package_state = Some(package_state);
+ Self::filter_package_lists(self);
+ Task::none()
+ }
+
+ fn on_removal_selected(&mut self, removal: Removal) -> Task {
+ self.selected_removal = Some(removal);
+ Self::filter_package_lists(self);
+ Task::none()
+ }
+
+ fn on_list_row(
+ &mut self,
+ i_package: usize,
+ row_message: &RowMessage,
+ settings: &Settings,
+ selected_device: &mut Phone,
+ ) -> Task {
+ let i_user = self.selected_user.unwrap_or_default().index;
+ #[expect(unused_must_use, reason = "side-effect")]
+ {
+ self.phone_packages[i_user][i_package]
+ .update(row_message)
+ .map(move |row_message| Message::List(i_package, row_message));
+ }
+
+ let package = &mut self.phone_packages[i_user][i_package];
+
+ match *row_message {
+ RowMessage::ToggleSelection(toggle) => {
+ if package.removal == Removal::Unsafe && !settings.general.expert_mode {
+ package.selected = false;
+ return Task::none();
+ }
+
+ if settings.device.multi_user_mode {
+ for u in selected_device.user_list.iter().filter(|&u| !u.protected) {
+ if let Some(pkg) = self
+ .phone_packages
+ .get_mut(u.index)
+ .and_then(|pkgs| pkgs.get_mut(i_package))
+ {
+ pkg.selected = toggle;
+ if toggle && !self.selected_packages.contains(&(u.index, i_package)) {
+ self.selected_packages.push((u.index, i_package));
+ }
+ }
+ }
+ if !toggle {
+ self.selected_packages.retain(|&x| x.1 != i_package);
+ }
+ } else {
+ package.selected = toggle;
+ if toggle {
+ if !self.selected_packages.contains(&(i_user, i_package)) {
+ self.selected_packages.push((i_user, i_package));
+ }
+ } else {
+ self.selected_packages
+ .retain(|&x| x.1 != i_package || x.0 != i_user);
+ }
+ }
+ Task::none()
+ }
+ RowMessage::ActionPressed => {
+ self.fallback_notifications.clear();
+ self.phone_packages[i_user][i_package].selected = true;
+ Task::batch(build_action_pkg_commands(
+ &self.phone_packages,
+ selected_device,
+ &settings.device,
+ (i_user, i_package),
+ ))
+ }
+ RowMessage::PackagePressed => {
+ self.description = package.clone().description;
+ self.description_content = text_editor::Content::with_text(&package.description);
+ package.current = true;
+ if self.current_package_index != i_package {
+ self.phone_packages[i_user][self.current_package_index].current = false;
+ }
+ self.current_package_index = i_package;
+ Task::none()
+ }
+ }
+ }
+
+ fn on_apply_action_on_selection(&mut self) -> Task