ceos/universal-android-debloater-next-generation
1
0
Fork 0
mirror of https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation.git synced 2026-08-09 15:19:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

chore: fix/mute more lints; rm useless "TODO"s

Browse source
This commit is contained in:
Rudxain 2025-03-06 03:15:18 -04:00
commit fdc220febc
No known key found for this signature in database
GPG key ID: 0DAC837DDEF8E96C
6 changed files with 6 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/core/save.rs
View file

@ -69,7 +69,6 @@ pub async fn backup_phone(
}
pub fn list_available_backups(dir: &Path) -> Vec<DisplayablePath> {
#[allow(clippy::option_if_let_else)]
match fs::read_dir(dir) {
Ok(files) => files
.filter_map(Result::ok)

1
src/core/uad_lists.rs
View file

@ -16,7 +16,6 @@ pub const LIST_FNAME: &str = "uad_lists.json";
)]
// not `const`, because it's too big
pub static DATA: &str = include_str!("../../resources/assets/uad_lists.json");
// TODO: use `const_format` crate
#[derive(Deserialize, Debug, Clone, PartialEq, Hash, Eq)]
#[serde(rename_all = "camelCase")]

12
src/gui/mod.rs
View file

@ -107,11 +107,9 @@ impl Application for UadGui {
fn title(&self) -> String {
String::from("Universal Android Debloater Next Generation")
}
// TODO: refactor later
#[allow(clippy::too_many_lines)]
fn update(&mut self, msg: Message) -> Command<Message> {
match msg {
#[allow(clippy::option_if_let_else)]
Message::LoadDevices(devices_list) => {
self.selected_device = match &self.selected_device {
Some(s_device) => {
@ -125,7 +123,7 @@ impl Application for UadGui {
};
self.devices_list = devices_list;
#[allow(unused_must_use)]
#[expect(unused_must_use, reason = "side-effect")]
{
self.update(Message::SettingsAction(SettingsMessage::LoadDeviceSettings));
}
@ -150,7 +148,7 @@ impl Application for UadGui {
}
Message::RefreshButtonPressed => {
self.apps_view = AppsView::default();
#[allow(unused_must_use)]
#[expect(unused_must_use, reason = "side-effect")]
{
self.update(Message::AppsAction(AppsMessage::ADBSatisfied(
self.adb_satisfied,
@ -186,7 +184,7 @@ impl Application for UadGui {
self.nb_running_async_adb_commands -= 1;
self.view = View::List;
#[allow(unused_must_use)]
#[expect(unused_must_use, reason = "side-effect")]
{
self.apps_view.update(
&mut self.settings_view,
@ -267,7 +265,7 @@ impl Application for UadGui {
info!("{:-^65}", "-");
self.apps_view.loading_state = ListLoadingState::FindingPhones;
#[allow(unused_must_use)]
#[expect(unused_must_use, reason = "side-effects")]
{
self.update(Message::SettingsAction(SettingsMessage::LoadDeviceSettings));
self.update(Message::AppsAction(AppsMessage::ToggleAllSelected(false)));
@ -315,7 +313,7 @@ impl Application for UadGui {
}
} else {
error!("Failed to update {NAME}!");
#[allow(unused_must_use)]
#[expect(unused_must_use, reason = "side-effect")]
{
self.update(Message::AppsAction(AppsMessage::UpdateFailed));
self.update_state.self_update.status = SelfUpdateStatus::Failed;

3
src/gui/views/list.rs
View file

@ -110,7 +110,6 @@ impl From<Removal> for SummaryEntry {
}
impl List {
// TODO: refactor later
#[allow(clippy::too_many_lines)]
pub fn update(
&mut self,
@ -461,7 +460,6 @@ impl List {
.into()
}
// TODO: refactor later
#[allow(clippy::too_many_lines)]
fn ready_view(
&self,
@ -621,7 +619,6 @@ impl List {
}
}
// TODO: refactor later
#[allow(clippy::too_many_lines)]
fn apply_selection_modal(
&self,

4
src/gui/views/settings.rs
View file

@ -68,7 +68,6 @@ pub enum Message {
}
impl Settings {
// TODO: refactor later
#[allow(clippy::too_many_lines)]
pub fn update(
&mut self,
@ -225,7 +224,7 @@ impl Settings {
if let Ok(path) = result {
self.general.backup_folder = path;
Config::save_changes(self, &phone.adb_id);
#[allow(unused_must_use)]
#[expect(unused_must_use, reason = "side-effect")]
{
self.update(
phone,
@ -260,7 +259,6 @@ impl Settings {
}
}
// TODO: refactor later
#[allow(clippy::too_many_lines)]
pub fn view(&self, phone: &Phone, apps_view: &AppsView) -> Element<Message, Theme, Renderer> {
let radio_btn_theme = Theme::ALL

1
src/gui/widgets/navigation_menu.rs
View file

@ -34,7 +34,6 @@ pub fn nav_menu<'a>(
let reboot_btn = button_primary("Reboot").on_press(Message::RebootButtonPressed);
#[allow(clippy::option_if_let_else)]
let uad_version_text = if let Some(r) = &self_update_state.latest_release {
match self_update_state.status {
SelfUpdateStatus::Failed => text(format!("Failed to update to {}", r.tag_name)),