From 0f64f23dc7d0b017a4ebe08f1da76e650e23e9bd Mon Sep 17 00:00:00 2001 From: Himadri Bhattacharjee <107522312+lavafroth@users.noreply.github.com> Date: Sat, 10 Feb 2024 18:29:51 +0530 Subject: [PATCH 1/3] fix: strip `v` version prefix when checking for updates --- src/core/update.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/core/update.rs b/src/core/update.rs index 0a33a03..84fa84e 100644 --- a/src/core/update.rs +++ b/src/core/update.rs @@ -185,8 +185,10 @@ pub fn get_latest_release() -> Result, ()> { .clone(), ) .map_err(|_| ())?; - if release.tag_name.as_str() != "dev-build" - && release.tag_name.as_str() > env!("CARGO_PKG_VERSION") + + let release_version = release.tag_name.strip_prefix("v").unwrap_or(&release.tag_name); + if release_version != "dev-build" + && release_version > env!("CARGO_PKG_VERSION") { Ok(Some(release)) } else { From 684ee331ef621de5a9343064983cb1ab0ec772ff Mon Sep 17 00:00:00 2001 From: Himadri Bhattacharjee <107522312+lavafroth@users.noreply.github.com> Date: Sat, 10 Feb 2024 18:33:24 +0530 Subject: [PATCH 2/3] lint: cargo clippy --- src/core/update.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/update.rs b/src/core/update.rs index 84fa84e..b70140e 100644 --- a/src/core/update.rs +++ b/src/core/update.rs @@ -186,7 +186,8 @@ pub fn get_latest_release() -> Result, ()> { ) .map_err(|_| ())?; - let release_version = release.tag_name.strip_prefix("v").unwrap_or(&release.tag_name); + let release_version = release.tag_name.strip_prefix('v').unwrap_or(&release.tag_name); + if release_version != "dev-build" && release_version > env!("CARGO_PKG_VERSION") { From 33ba195f48d30e25a1e17475bcb5ff3dde18bc31 Mon Sep 17 00:00:00 2001 From: Frigyes <72750891+Frigyes06@users.noreply.github.com> Date: Sun, 11 Feb 2024 21:01:02 -0800 Subject: [PATCH 3/3] remove extra spaces --- src/core/update.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/update.rs b/src/core/update.rs index b70140e..1f611f3 100644 --- a/src/core/update.rs +++ b/src/core/update.rs @@ -187,7 +187,7 @@ pub fn get_latest_release() -> Result, ()> { .map_err(|_| ())?; let release_version = release.tag_name.strip_prefix('v').unwrap_or(&release.tag_name); - + if release_version != "dev-build" && release_version > env!("CARGO_PKG_VERSION") {