From ce341df6c313e857fd79179811589390a39dfb01 Mon Sep 17 00:00:00 2001 From: Rudxain <76864299+Rudxain@users.noreply.github.com> Date: Tue, 29 Apr 2025 13:43:57 -0400 Subject: [PATCH 1/3] ci(cargo): rm `--all` flag --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 755976d..f94a5cf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,9 +38,9 @@ jobs: - lint: test args: "" - lint: clippy - args: " --all --all-features" + args: " --all-features" - lint: fmt - args: " --all -- --check" + args: " -- --check" steps: - uses: actions/checkout@v4 - uses: rui314/setup-mold@v1 # faster linker From 38554ca2d7f2fe8d4e278583bdd32850b2af48ae Mon Sep 17 00:00:00 2001 From: Rudxain <76864299+Rudxain@users.noreply.github.com> Date: Tue, 29 Apr 2025 14:22:39 -0400 Subject: [PATCH 2/3] ci(cargo): replace `check` by `clippy` --- .github/workflows/ci.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f94a5cf..bd2505a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,23 +22,17 @@ jobs: strategy: matrix: os: [ubuntu-22.04, windows-2022, macOS-14] - lint: [check, test, clippy, fmt] + lint: [clippy, test, fmt] exclude: # https://github.com/community/community/discussions/7835 - - os: windows-2022 - lint: clippy - os: windows-2022 lint: fmt - - os: macOS-14 - lint: clippy - os: macOS-14 lint: fmt include: - - lint: check + - lint: clippy args: " --all-features" - lint: test args: "" - - lint: clippy - args: " --all-features" - lint: fmt args: " -- --check" steps: From 5c5499bc6bdcdd3ee2cc81c958b05ed1787461eb Mon Sep 17 00:00:00 2001 From: Rudxain <76864299+Rudxain@users.noreply.github.com> Date: Tue, 29 Apr 2025 14:39:45 -0400 Subject: [PATCH 3/3] ci(clippy): `deny` default warnings but keep `style` as `warn` --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bd2505a..7b62d42 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,7 +30,7 @@ jobs: lint: fmt include: - lint: clippy - args: " --all-features" + args: " --all-features -- -D clippy::all -W clippy::style" - lint: test args: "" - lint: fmt