From 84277cc31ef93cbd9767fe502d89d2675be261e7 Mon Sep 17 00:00:00 2001
From: Danilo Bargen <mail@dbrgn.ch>
Date: Sat, 8 Jan 2022 22:01:36 +0100
Subject: [PATCH] Cache: Return error if HTTP client cannot be created (#247)

Apparently `Client::new` can panic (see #244), so let's return the error instead.
---
 src/cache.rs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/cache.rs b/src/cache.rs
index 87db30c..2eef24a 100644
--- a/src/cache.rs
+++ b/src/cache.rs
@@ -153,7 +153,9 @@ impl Cache {
                 builder = builder.proxy(proxy);
             }
         }
-        let client = builder.build().unwrap_or_else(|_| Client::new());
+        let client = builder.build().map_err(|e| {
+            TealdeerError::UpdateError(format!("Could not instantiate HTTP client: {}", e))
+        })?;
         let mut resp = client.get(&self.url).send()?;
         let mut buf: Vec<u8> = vec![];
         let bytes_downloaded = resp.copy_to(&mut buf)?;