ceos/opencode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tui): prevent duplicate renderable IDs (#32110)

Browse source
This commit is contained in:
Sebastian 2026-06-13 00:51:32 +02:00 • committed by GitHub
commit fff0ec294c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
15 changed files with 98 additions and 95 deletions
Download patch file Download diff file Expand all files Collapse all files

17
packages/tui/src/ui/dialog-select.tsx
View file

@ -238,9 +238,19 @@ export function DialogSelect<T>(props: DialogSelectProps<T>) {
const option = selected()
if (option) props.onMove?.(option)
if (!scroll) return
const target = scroll.getChildren().find((child: { id?: string }) => {
return child.id === JSON.stringify(selected()?.value)
})
let remaining = store.selected
let index = 0
// Locate the row by position because a unique renderable ID cannot currently be ensured.
for (const [category, options] of grouped()) {
if (category) index++
if (remaining < options.length) {
index += remaining
break
}
index += options.length
remaining -= options.length
}
const target = scroll.getChildren()[index]
if (!target) return
const y = target.y - scroll.y
if (center) {
@ -553,7 +563,6 @@ export function DialogSelect<T>(props: DialogSelectProps<T>) {
const current = createMemo(() => isDeepEqual(option.value, props.current))
return (
<box
id={JSON.stringify(option.value)}
flexDirection="column"
position="relative"
onMouseMove={() => {