simplify session keying

packages/app/test-browser/session-route-boundary.test.ts

@@ -1,78 +0,0 @@
-import { expect, test } from "bun:test"
-import { createComponent, createSignal, onCleanup } from "solid-js"
-import { render } from "solid-js/web"
-import { SessionRouteErrorBoundary } from "@/pages/session/route-boundary"
-
-// All session tabs on a server share one route instance, and the subtree holds
-// workspace-scoped state (notably the terminal and its PTY WebSockets), so
-// switching session tabs must not remount it. Remounting is owned elsewhere:
-// per server in app.tsx and per workspace in TargetSessionPage.
-test("switching sessions does not remount the route subtree", () => {
-  const [session, setSession] = createSignal("ses_a")
-  let mounts = 0
-  let disposals = 0
-  const Probe = () => {
-    mounts += 1
-    onCleanup(() => {
-      disposals += 1
-    })
-    return null
-  }
-
-  const dispose = render(
-    () =>
-      createComponent(SessionRouteErrorBoundary, {
-        get sessionID() {
-          return session()
-        },
-        fallback: () => null,
-        get children() {
-          return createComponent(Probe, {})
-        },
-      }),
-    document.createElement("div"),
-  )
-
-  const initialMounts = mounts
-  expect(initialMounts).toBeGreaterThan(0)
-
-  setSession("ses_b")
-  expect(mounts).toBe(initialMounts)
-  expect(disposals).toBe(0)
-
-  dispose()
-})
-
-// Without a per-session remount, the error boundary must clear a stale error
-// (e.g. session not found) when navigating to a different session.
-test("route error clears when navigating to a different session", () => {
-  const [session, setSession] = createSignal("ses_a")
-  const [broken, setBroken] = createSignal(true)
-  const Thrower = () => {
-    if (broken()) throw new Error(`Session not found: ${session()}`)
-    return "content"
-  }
-
-  const container = document.createElement("div")
-  const dispose = render(
-    () =>
-      createComponent(SessionRouteErrorBoundary, {
-        get sessionID() {
-          return session()
-        },
-        fallback: () => "error-fallback",
-        get children() {
-          return createComponent(Thrower, {})
-        },
-      }),
-    container,
-  )
-
-  expect(container.textContent).toBe("error-fallback")
-
-  setBroken(false)
-  setSession("ses_b")
-  expect(container.textContent).toBe("content")
-
-  dispose()
-})