ceos/opencode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(core): detach disposed MCP registrations from root scope (#37660)

Browse source
This commit is contained in:
Aiden Cline 2026-07-18 23:38:07 -05:00 • committed by GitHub
commit cbcf191fdb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
packages/core/src/mcp/index.ts
View file

@ -210,7 +210,12 @@ export const layer = Layer.effect(
entry.integrationID = integrationID entry.integrationID = integrationID
owned.add(integrationID) owned.add(integrationID)
const methodID = Integration.MethodID.make(suffix) const methodID = Integration.MethodID.make(suffix)
entry.registration = yield* integration // Each registration gets its own child scope so disposal detaches it from the root scope
// entirely; registering directly on root would accumulate a dead finalizer per replaced or
// removed server for the lifetime of the layer.
const scope = yield* Scope.fork(root)
entry.registration = { dispose: Scope.close(scope, Exit.void) }
yield* integration
.transform((draft) => { .transform((draft) => {
draft.update(integrationID, (ref) => { draft.update(integrationID, (ref) => {
ref.name = name ref.name = name
@ -221,7 +226,7 @@ export const layer = Layer.effect(
authorize: () => MCPOAuth.authorize({ name, config: remote, methodID }), authorize: () => MCPOAuth.authorize({ name, config: remote, methodID }),
}) })
}) })
.pipe(Scope.provide(root)) .pipe(Scope.provide(scope))
}) })
yield* Effect.forEach(runtime, ([name, entry]) => register(name, entry), { discard: true }) yield* Effect.forEach(runtime, ([name, entry]) => register(name, entry), { discard: true })