ceos/opencode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(app): scroll issues

Browse source
This commit is contained in:
Adam 2026-02-27 09:40:04 -06:00
commit a94f564ff0
No known key found for this signature in database
GPG key ID: 9CB48779AF150E75
1 changed files with 24 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

30
packages/app/src/pages/session/review-tab.tsx
View file

@ -49,6 +49,7 @@ export function SessionReviewTab(props: SessionReviewTabProps) {
let scroll: HTMLDivElement | undefined let scroll: HTMLDivElement | undefined
let restoreFrame: number | undefined let restoreFrame: number | undefined
let userInteracted = false let userInteracted = false
let restored: { x: number; y: number } | undefined
const sdk = useSDK() const sdk = useSDK()
const layout = useLayout() const layout = useLayout()
@ -65,6 +66,11 @@ export function SessionReviewTab(props: SessionReviewTabProps) {
const handleInteraction = () => { const handleInteraction = () => {
userInteracted = true userInteracted = true
if (restoreFrame !== undefined) {
cancelAnimationFrame(restoreFrame)
restoreFrame = undefined
}
} }
const doRestore = () => { const doRestore = () => {
@ -82,8 +88,11 @@ export function SessionReviewTab(props: SessionReviewTabProps) {
const targetY = Math.min(s.y, maxY) const targetY = Math.min(s.y, maxY)
const targetX = Math.min(s.x, maxX) const targetX = Math.min(s.x, maxX)
if (el.scrollTop === targetY && el.scrollLeft === targetX) return
if (el.scrollTop !== targetY) el.scrollTop = targetY if (el.scrollTop !== targetY) el.scrollTop = targetY
if (el.scrollLeft !== targetX) el.scrollLeft = targetX if (el.scrollLeft !== targetX) el.scrollLeft = targetX
restored = { x: el.scrollLeft, y: el.scrollTop }
} }
const queueRestore = () => { const queueRestore = () => {
@ -92,9 +101,16 @@ export function SessionReviewTab(props: SessionReviewTabProps) {
} }
const handleScroll = (event: Event & { currentTarget: HTMLDivElement }) => { const handleScroll = (event: Event & { currentTarget: HTMLDivElement }) => {
if (!layout.ready() || !userInteracted) return
const el = event.currentTarget const el = event.currentTarget
const prev = restored
if (prev && el.scrollTop === prev.y && el.scrollLeft === prev.x) {
restored = undefined
return
}
restored = undefined
handleInteraction()
if (!layout.ready()) return
if (el.clientHeight === 0 || el.clientWidth === 0) return if (el.clientHeight === 0 || el.clientWidth === 0) return
props.view().setScroll("review", { props.view().setScroll("review", {
@ -133,10 +149,11 @@ export function SessionReviewTab(props: SessionReviewTabProps) {
onCleanup(() => { onCleanup(() => {
if (restoreFrame !== undefined) cancelAnimationFrame(restoreFrame) if (restoreFrame !== undefined) cancelAnimationFrame(restoreFrame)
if (scroll) { if (scroll) {
scroll.removeEventListener("wheel", handleInteraction) scroll.removeEventListener("wheel", handleInteraction, { capture: true })
scroll.removeEventListener("pointerdown", handleInteraction) scroll.removeEventListener("mousewheel", handleInteraction, { capture: true })
scroll.removeEventListener("touchstart", handleInteraction) scroll.removeEventListener("pointerdown", handleInteraction, { capture: true })
scroll.removeEventListener("keydown", handleInteraction) scroll.removeEventListener("touchstart", handleInteraction, { capture: true })
scroll.removeEventListener("keydown", handleInteraction, { capture: true })
} }
}) })
@ -147,6 +164,7 @@ export function SessionReviewTab(props: SessionReviewTabProps) {
scrollRef={(el) => { scrollRef={(el) => {
scroll = el scroll = el
el.addEventListener("wheel", handleInteraction, { passive: true, capture: true }) el.addEventListener("wheel", handleInteraction, { passive: true, capture: true })
el.addEventListener("mousewheel", handleInteraction, { passive: true, capture: true })
el.addEventListener("pointerdown", handleInteraction, { passive: true, capture: true }) el.addEventListener("pointerdown", handleInteraction, { passive: true, capture: true })
el.addEventListener("touchstart", handleInteraction, { passive: true, capture: true }) el.addEventListener("touchstart", handleInteraction, { passive: true, capture: true })
el.addEventListener("keydown", handleInteraction, { passive: true, capture: true }) el.addEventListener("keydown", handleInteraction, { passive: true, capture: true })