ceos/opencode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(mcp): close existing client before reassignment to prevent leaks (#8253)

Browse source
This commit is contained in:
Daniel Sauer 2026-01-13 19:38:34 +01:00 • committed by GitHub
commit 80e1173ef7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
packages/opencode/src/mcp/index.ts
View file

@ -266,6 +266,13 @@ export namespace MCP {
status: s.status, status: s.status,
} }
} }
// Close existing client if present to prevent memory leaks
const existingClient = s.clients[name]
if (existingClient) {
await existingClient.close().catch((error) => {
log.error("Failed to close existing MCP client", { name, error })
})
}
s.clients[name] = result.mcpClient s.clients[name] = result.mcpClient
s.status[name] = result.status s.status[name] = result.status
@ -523,6 +530,13 @@ export namespace MCP {
const s = await state() const s = await state()
s.status[name] = result.status s.status[name] = result.status
if (result.mcpClient) { if (result.mcpClient) {
// Close existing client if present to prevent memory leaks
const existingClient = s.clients[name]
if (existingClient) {
await existingClient.close().catch((error) => {
log.error("Failed to close existing MCP client", { name, error })
})
}
s.clients[name] = result.mcpClient s.clients[name] = result.mcpClient
} }
} }