test(core): cover app node builder graphs (#34244)

This commit is contained in:
James Long 2026-06-27 12:54:18 -04:00 committed by GitHub
commit 5d63020dcd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 19 additions and 20 deletions

View file

@ -2,7 +2,7 @@ import { describe, expect, test } from "bun:test"
import { Context, Effect, Layer, LayerMap, Option } from "effect"
import { LayerNode } from "@opencode-ai/core/effect/layer-node"
import { Node } from "@opencode-ai/core/effect/app-node"
import { NodeBuild } from "@opencode-ai/core/effect/app-node-builder"
import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder"
import { Location } from "@opencode-ai/core/location"
import { LocationServiceMap } from "@opencode-ai/core/location-service-map"
import type { LocationError, LocationServices } from "@opencode-ai/core/location-services"
@ -22,7 +22,7 @@ describe("node build", () => {
layer: Layer.succeed(Result, Result.of({ value: "plain" })),
deps: [],
})
const layer = NodeBuild.build(LayerNode.group([result]))
const layer = AppNodeBuilder.build(result)
const program = Effect.gen(function* () {
expect(Option.isNone(yield* Effect.serviceOption(LocationServiceMap.Service))).toBe(true)
return (yield* Result).value
@ -64,7 +64,7 @@ describe("node build", () => {
const map = Node.makeGlobalNode({ service: LocationServiceMap.Service, layer: mapLayer, deps: [b] })
const graph = LayerNode.bind(LayerNode.group([a]), LocationServiceMap.node, map)
expect(() => NodeBuild.build(graph)).toThrow("Cycle detected in layer tree")
expect(() => AppNodeBuilder.build(graph)).toThrow("Cycle detected in layer tree")
})
test("shares top-level project with location services", async () => {
@ -81,7 +81,7 @@ describe("node build", () => {
})
}),
)
const layer = NodeBuild.build(LayerNode.group([Project.node, LocationServiceMap.node]), [
const layer = AppNodeBuilder.build(LayerNode.group([Project.node, LocationServiceMap.node]), [
LayerNode.replace(Project.layer, projectLayer),
])
const ref = Location.Ref.make({ directory: AbsolutePath.make(tmp.path) })
@ -112,7 +112,7 @@ describe("node build", () => {
),
deps: [value],
})
const serviceLayer = NodeBuild.build(LayerNode.group([result]))
const serviceLayer = AppNodeBuilder.build(result)
const program = Effect.gen(function* () {
expect(Option.isNone(yield* Effect.serviceOption(LocationServiceMap.Service))).toBe(true)
return (yield* Result).value