fix(sdk): wake embedded session execution (#33992)

This commit is contained in:
Kit Langton 2026-06-26 05:04:14 +02:00 committed by GitHub
commit 40ecfceec2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 53 additions and 19 deletions

View file

@ -12,7 +12,8 @@ import { Database } from "@opencode-ai/core/database/database"
import { makeRuntime } from "@opencode-ai/core/effect/runtime"
import { EventV2Bridge } from "@/event-v2-bridge"
import { SessionV2 } from "@opencode-ai/core/session"
import { SessionExecution } from "@opencode-ai/core/session/execution"
import * as SessionExecutionLocal from "@opencode-ai/core/session/execution/local"
import { LocationServiceMap } from "@opencode-ai/core/location-layer"
import { NotFoundError } from "@/storage/storage"
import { eq } from "drizzle-orm"
@ -943,8 +944,12 @@ export const defaultLayer = layer.pipe(
Layer.provide(BackgroundJob.defaultLayer),
Layer.provide(Database.defaultLayer),
Layer.provide(EventV2Bridge.defaultLayer),
Layer.provide(SessionExecution.noopLayer),
Layer.provide(SessionV2.defaultLayer),
Layer.provide(
SessionV2.defaultLayer.pipe(
Layer.provide(SessionExecutionLocal.defaultLayer),
Layer.provide(LocationServiceMap.layer),
),
),
Layer.provide(RuntimeFlags.defaultLayer),
)

View file

@ -34,7 +34,7 @@ import { resetDatabase } from "../fixture/db"
import { disposeAllInstances, provideInstanceEffect, TestInstance, tmpdirScoped } from "../fixture/fixture"
import { TestLLMServer } from "../lib/llm-server"
import { testProviderConfig } from "../lib/test-provider"
import { testEffect } from "../lib/effect"
import { pollWithTimeout, testEffect } from "../lib/effect"
const originalWorkspaces = Flag.OPENCODE_EXPERIMENTAL_WORKSPACES
const workspaceLayer = Workspace.defaultLayer.pipe(
@ -581,7 +581,7 @@ describe("session HttpApi", () => {
request(`/api/session/${session.id}/prompt`, {
method: "POST",
headers: { ...headers, "content-type": "application/json" },
body: JSON.stringify({ id: "msg_http_prompt", prompt: { text: "hello" } }),
body: JSON.stringify({ id: "msg_http_prompt", prompt: { text: "hello" }, resume: false }),
})
const first = yield* recordPrompt()
const retried = yield* recordPrompt()
@ -624,6 +624,22 @@ describe("session HttpApi", () => {
message: "Prompt message ID conflicts with an existing durable record: msg_http_prompt",
resource: "msg_http_prompt",
})
const wakeID = SessionMessage.ID.make("msg_http_wake")
const wake = yield* request(`/api/session/${session.id}/prompt`, {
method: "POST",
headers: { ...headers, "content-type": "application/json" },
body: JSON.stringify({ id: wakeID, prompt: { text: "hello again" } }),
})
expect(wake.status).toBe(200)
const message = yield* pollWithTimeout(
requestJson<{ data: SessionMessage.Message[] }>(`/api/session/${session.id}/message`, { headers }).pipe(
Effect.map(({ data }) => data.find((message) => message.id === wakeID)),
),
"V2 prompt was not promoted after wake",
"10 seconds",
)
expect(message).toMatchObject({ id: wakeID, type: "user" })
}),
{ git: true, config: { formatter: false, lsp: false } },
)

View file

@ -613,8 +613,7 @@ describe("session.compaction.create", () => {
})
const v2 = yield* SessionV2.Service.use((svc) => svc.messages({ sessionID: info.id })).pipe(
Effect.provide(SessionExecution.noopLayer),
Effect.provide(SessionV2.defaultLayer),
Effect.provide(SessionV2.defaultLayer.pipe(Layer.provide(SessionExecution.noopLayer))),
)
expect(v2.at(-1)).toMatchObject({
type: "compaction",

View file

@ -697,8 +697,7 @@ noLLMServer.instance.skip(
})
const messages = yield* SessionV2.Service.use((session) => session.messages({ sessionID: chat.id })).pipe(
Effect.provide(SessionExecution.noopLayer),
Effect.provide(SessionV2.defaultLayer),
Effect.provide(SessionV2.defaultLayer.pipe(Layer.provide(SessionExecution.noopLayer))),
)
const { db } = yield* Database.Service
const row = yield* db