ceos/opencode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tui): distinguish asynchronous UI states (#36759)

Browse source
This commit is contained in:
Kit Langton 2026-07-14 10:56:12 -04:00 • committed by GitHub
commit 26e27c7a7f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 219 additions and 116 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/tui/test/cli/tui/dialog-select.test.tsx
View file

@ -267,7 +267,7 @@ test("selects a repopulated option after removing the only option", async () =>
try {
select.replaceOptions([])
await select.app.waitForFrame((frame) => frame.includes("No results found"))
await select.app.waitForFrame((frame) => frame.includes("No items available"))
select.app.mockInput.pressEnter()
expect(select.selected).toEqual([])

13
packages/tui/test/cli/tui/diff-viewer.test.tsx
View file

@ -36,6 +36,16 @@ test("closing the diff viewer returns to the route it opened from", async () =>
}
})
test("shows an error instead of an empty diff when loading fails", async () => {
const viewer = await renderDiffViewer([], 20, undefined, true)
try {
await viewer.app.waitForFrame((frame) => frame.includes("Could not load diff"))
expect(viewer.app.captureCharFrame()).not.toContain("No changes to show")
} finally {
viewer.app.renderer.destroy()
}
})
test("brackets navigate diff hunks", async () => {
const viewer = await renderDiffViewer(
[
@ -102,7 +112,7 @@ test("brackets navigate diff hunks", async () => {
}
})
async function renderDiffViewer(vcsDiff: unknown[], height = 20, initialRoute?: TuiRouteCurrent) {
async function renderDiffViewer(vcsDiff: unknown[], height = 20, initialRoute?: TuiRouteCurrent, fail = false) {
const commands = new Map<
string,
NonNullable<Parameters<TuiPluginApi["keymap"]["registerLayer"]>[0]["commands"]>[number]
@ -113,6 +123,7 @@ async function renderDiffViewer(vcsDiff: unknown[], height = 20, initialRoute?:
const config = createTuiResolvedConfig()
const transport = createFetch((url) => {
if (url.pathname !== "/api/vcs/diff") return
if (fail) return json({ message: "boom" }, { status: 500 })
vcsDiffInput = {
location: { directory: url.searchParams.get("location[directory]") },
mode: url.searchParams.get("mode"),