refactor(core): name the unsettled-tool sweep scope and untangle hosted settlement (#38724)

packages/core/src/session/runner/llm.ts

@@ -364,32 +364,17 @@ const layer = Layer.effect(
           // these sweeps only close calls that could not produce a truthful settlement.
           if (providerFailed)
             yield* serialized(publisher.failUnsettledTools({ type: "aborted", message: "Tool execution interrupted" }))
-          if (llmFailure && !providerFailed)
+          const resultMissing = {
-            yield* serialized(
+            type: "tool.result-missing",
-              publisher.failUnsettledTools(
+            message: "Provider did not return a tool result",
-                {
+          } as const
-                  type: "tool.result-missing",
+          if (llmFailure && !providerFailed) yield* serialized(publisher.failUnsettledTools(resultMissing, "hosted"))
-                  message: "Provider did not return a tool result",
+          // A clean stream that still left hosted calls unresolved fails the step itself.
-                },
+          if (stream._tag === "Success" && !providerFailed) {
-                true,
+            const hostedResultMissing = yield* serialized(publisher.failUnsettledTools(resultMissing, "hosted"))
-              ),
+            if (hostedResultMissing && !publisher.stepSettlement())
-            )
+              yield* serialized(publisher.failAssistant(resultMissing))
-          const hostedResultMissing =
+          }
-            stream._tag === "Success" && !providerFailed
-              ? yield* serialized(
-                  publisher.failUnsettledTools(
-                    { type: "tool.result-missing", message: "Provider did not return a tool result" },
-                    true,
-                  ),
-                )
-              : false
-          if (hostedResultMissing && !publisher.stepSettlement())
-            yield* serialized(
-              publisher.failAssistant({
-                type: "tool.result-missing",
-                message: "Provider did not return a tool result",
-              }),
-            )
 
           const stepFailure = publisher.stepFailure()
           const stepSettlement = publisher.stepSettlement()

packages/core/src/session/runner/publish-llm-event.ts

@@ -277,9 +277,9 @@ export const createLLMEventPublisher = (events: Pick<EventV2.Interface, "publish
 
   const failUnsettledTools = Effect.fn("SessionRunner.failUnsettledTools")(function* (
     error: SessionError.Error,
-    hostedOnly = false,
+    scope: "hosted" | "all" = "all",
   ) {
-    return yield* failTools(error, hostedOnly ? "hosted" : "all")
+    return yield* failTools(error, scope)
   })
 
   const assistantMessageIDForTool = (callID: string) => {