ceos/opencode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(core): clean up Effect audit patterns (#35174)

Browse source
This commit is contained in:
Kit Langton 2026-07-03 13:54:13 -04:00 • committed by GitHub
commit 1b88ff8d53
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
18 changed files with 118 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/server/src/handlers/credential.ts
View file

@ -8,14 +8,16 @@ export const CredentialHandler = HttpApiBuilder.group(Api, "server.credential",
.handle(
"credential.update",
Effect.fn(function* (ctx) {
yield* (yield* Integration.Service).connection.update(ctx.params.credentialID, { label: ctx.payload.label })
const integration = yield* Integration.Service
yield* integration.connection.update(ctx.params.credentialID, { label: ctx.payload.label })
return HttpApiSchema.NoContent.make()
}),
)
.handle(
"credential.remove",
Effect.fn(function* (ctx) {
yield* (yield* Integration.Service).connection.remove(ctx.params.credentialID)
const integration = yield* Integration.Service
yield* integration.connection.remove(ctx.params.credentialID)
return HttpApiSchema.NoContent.make()
}),
),

3
packages/server/src/handlers/fs.ts
View file

@ -11,7 +11,8 @@ export const FileSystemHandler = HttpApiBuilder.group(Api, "server.fs", (handler
return handlers
.handleRaw("fs.read", (ctx) =>
Effect.gen(function* () {
const file = yield* (yield* FileSystem.Service).read({
const fs = yield* FileSystem.Service
const file = yield* fs.read({
path: RelativePath.make(
decodeURIComponent(new URL(ctx.request.url, "http://localhost").pathname.slice(13)),
),

12
packages/server/src/handlers/permission.ts
View file

@ -17,7 +17,8 @@ export const PermissionHandler = HttpApiBuilder.group(Api, "server.permission",
.handle(
"permission.request.list",
Effect.fn(function* () {
return yield* response((yield* PermissionV2.Service).list())
const permission = yield* PermissionV2.Service
return yield* response(permission.list())
}),
)
.handle(
@ -59,7 +60,8 @@ export const PermissionHandler = HttpApiBuilder.group(Api, "server.permission",
.handle(
"session.permission.get",
Effect.fn(function* (ctx) {
const request = yield* (yield* PermissionV2.Service).get(ctx.params.requestID)
const permission = yield* PermissionV2.Service
const request = yield* permission.get(ctx.params.requestID)
if (!request || request.sessionID !== ctx.params.sessionID) return yield* missingRequest(ctx.params.requestID)
return { data: request }
}),
@ -80,8 +82,9 @@ export const PermissionHandler = HttpApiBuilder.group(Api, "server.permission",
"permission.saved.list",
Effect.fn(function* (ctx) {
const location = yield* Location.Service
const saved = yield* PermissionSaved.Service
return {
data: yield* (yield* PermissionSaved.Service).list({
data: yield* saved.list({
projectID: ctx.query.projectID ?? location.project.id,
}),
}
@ -90,7 +93,8 @@ export const PermissionHandler = HttpApiBuilder.group(Api, "server.permission",
.handle(
"permission.saved.remove",
Effect.fn(function* (ctx) {
yield* (yield* PermissionSaved.Service).remove(ctx.params.id)
const saved = yield* PermissionSaved.Service
yield* saved.remove(ctx.params.id)
return HttpApiSchema.NoContent.make()
}),
)

3
packages/server/src/handlers/pty.ts
View file

@ -32,7 +32,8 @@ export const PtyHandler = HttpApiBuilder.group(Api, "server.pty", (handlers) =>
.handle(
"pty.list",
Effect.fn(function* () {
return yield* response((yield* Pty.Service).list())
const pty = yield* Pty.Service
return yield* response(pty.list())
}),
)
.handle(

6
packages/server/src/handlers/question.ts
View file

@ -26,13 +26,15 @@ export const QuestionHandler = HttpApiBuilder.group(Api, "server.question", (han
.handle(
"question.request.list",
Effect.fn(function* () {
return yield* response((yield* QuestionV2.Service).list())
const question = yield* QuestionV2.Service
return yield* response(question.list())
}),
)
.handle(
"session.question.list",
Effect.fn(function* (ctx) {
const requests = yield* (yield* QuestionV2.Service).list()
const question = yield* QuestionV2.Service
const requests = yield* question.list()
return { data: requests.filter((request) => request.sessionID === ctx.params.sessionID) }
}),
)