ceos/ly
1
0
Fork 0
mirror of https://codeberg.org/fairyglade/ly.git synced 2026-08-25 23:14:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

Don't dupeZ() in main

Browse source 
Signed-off-by: AnErrupTion <anerruption@disroot.org>
This commit is contained in:
AnErrupTion 2025-08-30 01:09:12 +02:00
commit 0a9ceca822
No known key found for this signature in database
2 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/auth.zig
View file

@ -32,7 +32,7 @@ pub fn sessionSignalHandler(i: c_int) callconv(.c) void {
if (child_pid > 0) _ = std.c.kill(child_pid, i);
}
pub fn authenticate(allocator: std.mem.Allocator, log_writer: *std.Io.Writer, options: AuthOptions, current_environment: Environment, login: [:0]const u8, password: [:0]const u8) !void {
pub fn authenticate(allocator: std.mem.Allocator, log_writer: *std.Io.Writer, options: AuthOptions, current_environment: Environment, login: []const u8, password: []const u8) !void {
var tty_buffer: [3]u8 = undefined;
const tty_str = try std.fmt.bufPrint(&tty_buffer, "{d}", .{options.tty});
@ -43,7 +43,13 @@ pub fn authenticate(allocator: std.mem.Allocator, log_writer: *std.Io.Writer, op
try setXdgEnv(allocator, tty_str, current_environment);
// Open the PAM session
var credentials = [_:null]?[*:0]const u8{ login, password };
const login_z = try allocator.dupeZ(u8, login);
defer allocator.free(login_z);
const password_z = try allocator.dupeZ(u8, password);
defer allocator.free(password_z);
var credentials = [_:null]?[*:0]const u8{ login_z, password_z };
const conv = interop.pam.pam_conv{
.conv = loginConv,
@ -79,7 +85,7 @@ pub fn authenticate(allocator: std.mem.Allocator, log_writer: *std.Io.Writer, op
defer interop.closePasswordDatabase();
// Get password structure from username
user_entry = interop.getUsernameEntry(login) orelse return error.GetPasswordNameFailed;
user_entry = interop.getUsernameEntry(login_z) orelse return error.GetPasswordNameFailed;
}
// Set user shell if it hasn't already been set