From 9a3f7a19cbc8b5f272f798041f5f2917c3ccbb27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20M=C3=BCller?= <34514239+appgurueu@users.noreply.github.com> Date: Thu, 24 Aug 2023 18:52:15 +0200 Subject: [PATCH] fix: replace string concatenation in loop with string builder (#505) --- main.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/main.go b/main.go index 17d66e7..86a089c 100644 --- a/main.go +++ b/main.go @@ -284,15 +284,16 @@ func executeCLI(cmd *cobra.Command, src *source, w io.Writer) error { // trim lines lines := strings.Split(string(out), "\n") - var content string + var cb strings.Builder for i, s := range lines { - content += strings.TrimSpace(s) + cb.WriteString(strings.TrimSpace(s)) // don't add an artificial newline after the last split if i+1 < len(lines) { - content += "\n" + cb.WriteString("\n") } } + content := cb.String() // display if pager || cmd.Flags().Changed("pager") {