From 6aba7afb8b53a860464c5dc8fc0b711233a7e5da Mon Sep 17 00:00:00 2001 From: Christian Rocha Date: Tue, 25 Aug 2020 13:36:42 -0400 Subject: [PATCH] Remove some magic numbers to calm the linter down --- ui/pager.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ui/pager.go b/ui/pager.go index c15bdb1..3127640 100644 --- a/ui/pager.go +++ b/ui/pager.go @@ -360,6 +360,11 @@ func pagerView(m pagerModel) string { } func pagerStatusBarView(b *strings.Builder, m pagerModel) { + const ( + minPercent float64 = 0.0 + maxPercent float64 = 1.0 + percentToStringMagnitude float64 = 100.0 + ) var ( isStashed bool = m.currentDocument.markdownType == stashedMarkdown || m.currentDocument.markdownType == convertedMarkdown showStatusMessage bool = m.state == pagerStateStatusMessage @@ -369,8 +374,8 @@ func pagerStatusBarView(b *strings.Builder, m pagerModel) { logo := glowLogoView(" Glow ") // Scroll percent - percent := math.Max(0.0, math.Min(1.0, m.viewport.ScrollPercent())) - scrollPercent := fmt.Sprintf(" %3.f%% ", percent*100) + percent := math.Max(minPercent, math.Min(maxPercent, m.viewport.ScrollPercent())) + scrollPercent := fmt.Sprintf(" %3.f%% ", percent*percentToStringMagnitude) if showStatusMessage { scrollPercent = statusBarMessageScrollPosStyle(scrollPercent) } else {