mirror of
https://github.com/PrefectHQ/fastmcp.git
synced 2026-08-18 03:29:11 +02:00
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Jeremiah Lowin <jlowin@users.noreply.github.com> Co-authored-by: Marvin Context Protocol <41898282+Marvin Context Protocol@users.noreply.github.com> Co-authored-by: voidborne-d <voidborne-d@users.noreply.github.com> Co-authored-by: marvin-context-protocol[bot] <225465937+marvin-context-protocol[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: d 🔹 <258577966+voidborne-d@users.noreply.github.com> Co-authored-by: Jeremiah Lowin <153965+jlowin@users.noreply.github.com> Co-authored-by: nightcityblade <nightcityblade@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Bill Easton <strawgate@users.noreply.github.com> Co-authored-by: Sumanshu Nankana <sumanshunankana@gmail.com> Co-authored-by: Eric Robinson <ericrobinson@indeed.com> Co-authored-by: Martim Santos <martimfasantos@gmail.com> Co-authored-by: d 🔹 <liusway405@gmail.com> Co-authored-by: Matthieu B <66959271+mtthidoteu@users.noreply.github.com> Co-authored-by: Sascha Buehrle <47737812+saschabuehrle@users.noreply.github.com> Co-authored-by: Hakancan <142545736+hkc5@users.noreply.github.com> Co-authored-by: nightcityblade <jackchen@haloailabs.com> Co-authored-by: Matt Hallowell <17804673+mhallo@users.noreply.github.com> Co-authored-by: nate nowack <thrast36@gmail.com> Co-authored-by: Bill Easton <williamseaston@gmail.com> Co-authored-by: Marcus Shu <46469249+shulkx@users.noreply.github.com> Co-authored-by: Rushabh Doshi <radoshi@gmail.com> Co-authored-by: AIKAWA Shigechika <shige@aikawa.jp> Co-authored-by: Jeremy Simon <simonjer805@gmail.com> Co-authored-by: Miguel Miranda Dias <7780875+pandego@users.noreply.github.com> Co-authored-by: Anthony James Padavano <padavano.anthony@gmail.com> Co-authored-by: Mostafa Kamal <hiremostafa@gmail.com> Fix auto-close MRE script posting comment without closing (#3386) Fix WorkOS token scope verification bypass 🤖 Generated with Codex (#3407) Fix initialize McpError fallthrough 🤖 Generated with Codex (#3413) Fix transform arg collisions with passthrough params (#3431) Fix get_* returning None when latest version is disabled (#3439) Fix get_* returning None when latest version is disabled (#3421) Fix server lifespan overlap teardown (#3415) Fix $ref output schema object detection regression (#3420) resolved annotations (#3429) Fix async partial callables rejected by iscoroutinefunction (#3438) Fix async partial callables rejected by iscoroutinefunction (#3423) fix: add version to components (#3458) fix: use intent-based flag for OIDC scope patch in load_access_token (#3465) Fixes #3461 fix: normalize Google scope shorthands and surface valid_scopes (#3477) fix: resolve ty 0.0.23 type-checking errors and bump pin (#3481) fix: shield lifespan teardown from cancellation (#3480) fix: forward custom_route endpoints from mounted servers (#3462) fix updates _get_additional_http_routes() to traverse providers, Fixes #3457 fix: remove hardcoded version from CLI help text (#3456) fix: monty 0.0.8 compatibility, drop external_functions from constructor (#3468) fix: task test teardown hanging 5s per test (#3499) Closes #3498 fix: validate workspace path is a directory before cursor install (#3440) Fixes #3426 fix: handle re.error from malformed URI templates in build_regex (#3501) fix: reject empty/OIDC-only required_scopes in AzureProvider (#3503) fix: restrict $ref resolution to local refs only (SSRF/LFI) (#3502) fix warnings and timeouts (#3504) close upgrade check issue when build passes (#3505) Closes #3484 fix: URL-encode path params to prevent SSRF/path traversal (GHSA-vv7q-7jx5-f767) (#3507) fix: prevent path traversal in skill download (#3493) fix: prefer IdP-granted scopes over client-requested scopes in OAuthProxy (#3492) fix: remove unrelated transform and http.py changes from PR scope fix: remove forced follow_redirects from httpx_client_factory calls (#3496) fix: stop passing follow_redirects to httpx_client_factory fix: restore follow_redirects=True for custom httpx client factories Closes #3509 fix: CSRF double-submit cookie check in consent flow (#3519) fix: validate server names in install commands (#3522) fix: use raw strings for regex in pytest.raises match (#3523) fix: reject refresh tokens used as Bearer access tokens (#3524) fix: route ResourcesAsTools/PromptsAsTools through server middleware (#3495) fix: resolve Pyright "Module is not callable" on @tool, @resource, @prompt decorators (#3540) fix: filter warnings by message in KEY_PREFIX test (#3549) fix: suppress output schema for ToolResult subclass annotations (#3548) fix: increase sleep duration in proxy cache tests (#3567) fix: store absolute token expiry to prevent stale expires_in on reload (#3572) fix: preserve tool properties named 'title' during schema compression (#3582) Fix loopback redirect URI port matching per RFC 8252 §7.3 (#3589) Fix app tool routing: visibility check and middleware propagation (#3591) Fix query parameter serialization to respect OpenAPI explode/style settings (#3595) Fix dev apps form: union types, textarea support, JSON parsing (#3597) fix(google): replace deprecated /oauth2/v1/tokeninfo with /oauth2/v3/userinfo (#3603) fix: resolve EntraOBOToken dependency injection through MultiAuth (#3609) fix(docs): correct misleading stateless_http header (#3622) fix: filesystem provider import machinery (#3626) Closes #3625 (issues 2, 3, 6) fix: recover StdioTransport after subprocess exits (#3630) fix(server): preserve mounted tool task metadata (#3632) fix: scope deprecation warning filter to FastMCPDeprecationWarning (#3649) fix imports, add PrefabAppConfig (#3650) fix: resolve CurrentFastMCP/ctx.fastmcp to child server in mounted background tasks (#3651) Fix blocking docs issues: chart imports, Select API, Rx consistency (#3652) closed by default (#3657) Fix prompt caching middleware missing wrap/unwrap round-trip (#3666) fix: serialize object query params per OpenAPI style/explode rules (#3662) Fixes #2857 fix: HTTP request headers not accessible in background task workers (#3631) fix: restore HTTP headers in worker execution path for background tasks (#3681) fix: strip discriminator after dereferencing schemas (#3682) fix: remove stale ty:ignore directives for ty 0.0.26 (#3684) Fix docs gaps in app provider pages (#3690) fix: dev apps log panel UX improvements (#3698) fix dev server empty string args (#3700)
218 lines
7.6 KiB
Python
218 lines
7.6 KiB
Python
"""
|
|
Tests for task protocol methods.
|
|
|
|
Tests the tasks/get, tasks/result, and tasks/list JSON-RPC protocol methods.
|
|
"""
|
|
|
|
import asyncio
|
|
|
|
import pytest
|
|
from mcp.shared.exceptions import McpError
|
|
|
|
from fastmcp import FastMCP
|
|
from fastmcp.client import Client
|
|
|
|
|
|
@pytest.fixture
|
|
async def endpoint_server():
|
|
"""Create a server with background tasks and HTTP transport."""
|
|
mcp = FastMCP("endpoint-test-server")
|
|
|
|
@mcp.tool(task=True) # Enable background execution
|
|
async def quick_tool(value: int) -> int:
|
|
"""Returns the value immediately."""
|
|
return value * 2
|
|
|
|
@mcp.tool(task=True) # Enable background execution
|
|
async def error_tool() -> str:
|
|
"""Always raises an error."""
|
|
raise RuntimeError("Task failed!")
|
|
|
|
@mcp.tool(task=True) # Enable background execution
|
|
async def slow_tool() -> str:
|
|
"""A slow tool for testing cancellation."""
|
|
await asyncio.sleep(10)
|
|
return "done"
|
|
|
|
return mcp
|
|
|
|
|
|
async def test_tasks_get_endpoint_returns_status(endpoint_server):
|
|
"""POST /tasks/get returns task status."""
|
|
async with Client(endpoint_server) as client:
|
|
# Submit a task
|
|
task = await client.call_tool("quick_tool", {"value": 21}, task=True)
|
|
|
|
# Check status immediately - should be submitted or working
|
|
status = await task.status()
|
|
assert status.taskId == task.task_id
|
|
assert status.status in ["working", "completed"]
|
|
|
|
# Wait for completion
|
|
await task.wait(timeout=2.0)
|
|
|
|
# Check again - should be completed
|
|
status = await task.status()
|
|
assert status.status == "completed"
|
|
|
|
|
|
async def test_tasks_get_endpoint_includes_poll_interval(endpoint_server):
|
|
"""Task status includes pollFrequency hint."""
|
|
async with Client(endpoint_server) as client:
|
|
task = await client.call_tool("quick_tool", {"value": 42}, task=True)
|
|
|
|
status = await task.status()
|
|
assert status.pollInterval is not None
|
|
assert isinstance(status.pollInterval, int)
|
|
|
|
|
|
async def test_tasks_result_endpoint_returns_result_when_completed(endpoint_server):
|
|
"""POST /tasks/result returns the tool result when completed."""
|
|
async with Client(endpoint_server) as client:
|
|
task = await client.call_tool("quick_tool", {"value": 21}, task=True)
|
|
|
|
# Wait for completion and get result
|
|
result = await task.result()
|
|
assert result.data == 42 # 21 * 2
|
|
|
|
|
|
async def test_tasks_result_endpoint_errors_if_not_completed(endpoint_server):
|
|
"""POST /tasks/result returns error if task not completed yet."""
|
|
# Create a task that won't complete until signaled
|
|
completion_signal = asyncio.Event()
|
|
|
|
@endpoint_server.tool(task=True) # Enable background execution
|
|
async def blocked_tool() -> str:
|
|
await completion_signal.wait()
|
|
return "done"
|
|
|
|
async with Client(endpoint_server) as client:
|
|
task = await client.call_tool("blocked_tool", task=True)
|
|
|
|
# Try to get result immediately (task still running)
|
|
with pytest.raises(Exception): # Should raise or return error
|
|
await client.get_task_result(task.task_id)
|
|
|
|
# Cleanup - signal completion
|
|
completion_signal.set()
|
|
|
|
|
|
async def test_tasks_result_endpoint_errors_if_task_not_found(endpoint_server):
|
|
"""POST /tasks/result returns error for non-existent task."""
|
|
async with Client(endpoint_server) as client:
|
|
# Try to get result for non-existent task
|
|
with pytest.raises(Exception):
|
|
await client.get_task_result("non-existent-task-id")
|
|
|
|
|
|
async def test_tasks_result_endpoint_returns_error_for_failed_task(endpoint_server):
|
|
"""POST /tasks/result returns error information for failed tasks."""
|
|
async with Client(endpoint_server) as client:
|
|
task = await client.call_tool("error_tool", task=True)
|
|
|
|
# Wait for task to fail
|
|
await task.wait(state="failed", timeout=2.0)
|
|
|
|
# Getting result should raise or return error info
|
|
with pytest.raises(Exception) as exc_info:
|
|
await task.result()
|
|
|
|
assert (
|
|
"failed" in str(exc_info.value).lower()
|
|
or "error" in str(exc_info.value).lower()
|
|
)
|
|
|
|
|
|
async def test_tasks_list_endpoint_session_isolation(endpoint_server):
|
|
"""list_tasks returns only tasks submitted by this client."""
|
|
# Since client tracks tasks locally, this tests client-side tracking
|
|
async with Client(endpoint_server) as client:
|
|
# Submit multiple tasks (server generates IDs)
|
|
tasks = []
|
|
for i in range(3):
|
|
task = await client.call_tool("quick_tool", {"value": i}, task=True)
|
|
tasks.append(task)
|
|
|
|
# Wait for all to complete
|
|
for task in tasks:
|
|
await task.wait(timeout=2.0)
|
|
|
|
# List tasks - should see all 3
|
|
response = await client.list_tasks()
|
|
returned_ids = [t["taskId"] for t in response["tasks"]]
|
|
task_ids = [t.task_id for t in tasks]
|
|
assert len(returned_ids) == 3
|
|
assert all(tid in task_ids for tid in returned_ids)
|
|
|
|
|
|
async def test_get_status_nonexistent_task_raises_error(endpoint_server):
|
|
"""Getting status for nonexistent task raises MCP error (per SEP-1686 SDK behavior)."""
|
|
async with Client(endpoint_server) as client:
|
|
# Try to get status for task that was never created
|
|
# Per SDK implementation: raises ValueError which becomes JSON-RPC error
|
|
with pytest.raises(McpError, match="Task nonexistent-task-id not found"):
|
|
await client.get_task_status("nonexistent-task-id")
|
|
|
|
|
|
async def test_task_cancellation_workflow(endpoint_server):
|
|
"""Task can be cancelled, transitioning to cancelled state."""
|
|
async with Client(endpoint_server) as client:
|
|
# Submit slow task
|
|
task = await client.call_tool("slow_tool", {}, task=True)
|
|
|
|
# Give it a moment to start
|
|
await asyncio.sleep(0.1)
|
|
|
|
# Cancel the task
|
|
await task.cancel()
|
|
|
|
# Give cancellation a moment to process
|
|
await asyncio.sleep(0.1)
|
|
|
|
# Task should be in cancelled state
|
|
status = await task.status()
|
|
assert status.status == "cancelled"
|
|
|
|
|
|
@pytest.mark.timeout(10)
|
|
async def test_task_cancellation_interrupts_running_coroutine(endpoint_server):
|
|
"""Task cancellation actually interrupts the running coroutine.
|
|
|
|
This verifies that when a task is cancelled, the underlying asyncio
|
|
coroutine receives CancelledError rather than continuing to completion.
|
|
Requires pydocket >= 0.16.2.
|
|
|
|
See: https://github.com/PrefectHQ/fastmcp/issues/2679
|
|
"""
|
|
started = asyncio.Event()
|
|
was_interrupted = asyncio.Event()
|
|
completed_normally = asyncio.Event()
|
|
|
|
@endpoint_server.tool(task=True)
|
|
async def interruptible_tool() -> str:
|
|
started.set()
|
|
try:
|
|
await asyncio.sleep(60)
|
|
completed_normally.set()
|
|
return "completed"
|
|
except asyncio.CancelledError:
|
|
was_interrupted.set()
|
|
raise
|
|
|
|
async with Client(endpoint_server) as client:
|
|
task = await client.call_tool("interruptible_tool", {}, task=True)
|
|
|
|
# Wait for the tool to actually start executing
|
|
await asyncio.wait_for(started.wait(), timeout=5.0)
|
|
|
|
# Cancel the task
|
|
await task.cancel()
|
|
|
|
# Wait for cancellation to propagate
|
|
await asyncio.wait_for(was_interrupted.wait(), timeout=5.0)
|
|
|
|
# The coroutine should have been interrupted, not completed normally
|
|
assert was_interrupted.is_set(), "Task was not interrupted by cancellation"
|
|
assert not completed_normally.is_set(), (
|
|
"Task completed instead of being cancelled"
|
|
)
|