mirror of
https://github.com/PrefectHQ/fastmcp.git
synced 2026-08-18 03:29:11 +02:00
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Jeremiah Lowin <jlowin@users.noreply.github.com> Co-authored-by: Marvin Context Protocol <41898282+Marvin Context Protocol@users.noreply.github.com> Co-authored-by: voidborne-d <voidborne-d@users.noreply.github.com> Co-authored-by: marvin-context-protocol[bot] <225465937+marvin-context-protocol[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: d 🔹 <258577966+voidborne-d@users.noreply.github.com> Co-authored-by: Jeremiah Lowin <153965+jlowin@users.noreply.github.com> Co-authored-by: nightcityblade <nightcityblade@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Bill Easton <strawgate@users.noreply.github.com> Co-authored-by: Sumanshu Nankana <sumanshunankana@gmail.com> Co-authored-by: Eric Robinson <ericrobinson@indeed.com> Co-authored-by: Martim Santos <martimfasantos@gmail.com> Co-authored-by: d 🔹 <liusway405@gmail.com> Co-authored-by: Matthieu B <66959271+mtthidoteu@users.noreply.github.com> Co-authored-by: Sascha Buehrle <47737812+saschabuehrle@users.noreply.github.com> Co-authored-by: Hakancan <142545736+hkc5@users.noreply.github.com> Co-authored-by: nightcityblade <jackchen@haloailabs.com> Co-authored-by: Matt Hallowell <17804673+mhallo@users.noreply.github.com> Co-authored-by: nate nowack <thrast36@gmail.com> Co-authored-by: Bill Easton <williamseaston@gmail.com> Co-authored-by: Marcus Shu <46469249+shulkx@users.noreply.github.com> Co-authored-by: Rushabh Doshi <radoshi@gmail.com> Co-authored-by: AIKAWA Shigechika <shige@aikawa.jp> Co-authored-by: Jeremy Simon <simonjer805@gmail.com> Co-authored-by: Miguel Miranda Dias <7780875+pandego@users.noreply.github.com> Co-authored-by: Anthony James Padavano <padavano.anthony@gmail.com> Co-authored-by: Mostafa Kamal <hiremostafa@gmail.com> Fix auto-close MRE script posting comment without closing (#3386) Fix WorkOS token scope verification bypass 🤖 Generated with Codex (#3407) Fix initialize McpError fallthrough 🤖 Generated with Codex (#3413) Fix transform arg collisions with passthrough params (#3431) Fix get_* returning None when latest version is disabled (#3439) Fix get_* returning None when latest version is disabled (#3421) Fix server lifespan overlap teardown (#3415) Fix $ref output schema object detection regression (#3420) resolved annotations (#3429) Fix async partial callables rejected by iscoroutinefunction (#3438) Fix async partial callables rejected by iscoroutinefunction (#3423) fix: add version to components (#3458) fix: use intent-based flag for OIDC scope patch in load_access_token (#3465) Fixes #3461 fix: normalize Google scope shorthands and surface valid_scopes (#3477) fix: resolve ty 0.0.23 type-checking errors and bump pin (#3481) fix: shield lifespan teardown from cancellation (#3480) fix: forward custom_route endpoints from mounted servers (#3462) fix updates _get_additional_http_routes() to traverse providers, Fixes #3457 fix: remove hardcoded version from CLI help text (#3456) fix: monty 0.0.8 compatibility, drop external_functions from constructor (#3468) fix: task test teardown hanging 5s per test (#3499) Closes #3498 fix: validate workspace path is a directory before cursor install (#3440) Fixes #3426 fix: handle re.error from malformed URI templates in build_regex (#3501) fix: reject empty/OIDC-only required_scopes in AzureProvider (#3503) fix: restrict $ref resolution to local refs only (SSRF/LFI) (#3502) fix warnings and timeouts (#3504) close upgrade check issue when build passes (#3505) Closes #3484 fix: URL-encode path params to prevent SSRF/path traversal (GHSA-vv7q-7jx5-f767) (#3507) fix: prevent path traversal in skill download (#3493) fix: prefer IdP-granted scopes over client-requested scopes in OAuthProxy (#3492) fix: remove unrelated transform and http.py changes from PR scope fix: remove forced follow_redirects from httpx_client_factory calls (#3496) fix: stop passing follow_redirects to httpx_client_factory fix: restore follow_redirects=True for custom httpx client factories Closes #3509 fix: CSRF double-submit cookie check in consent flow (#3519) fix: validate server names in install commands (#3522) fix: use raw strings for regex in pytest.raises match (#3523) fix: reject refresh tokens used as Bearer access tokens (#3524) fix: route ResourcesAsTools/PromptsAsTools through server middleware (#3495) fix: resolve Pyright "Module is not callable" on @tool, @resource, @prompt decorators (#3540) fix: filter warnings by message in KEY_PREFIX test (#3549) fix: suppress output schema for ToolResult subclass annotations (#3548) fix: increase sleep duration in proxy cache tests (#3567) fix: store absolute token expiry to prevent stale expires_in on reload (#3572) fix: preserve tool properties named 'title' during schema compression (#3582) Fix loopback redirect URI port matching per RFC 8252 §7.3 (#3589) Fix app tool routing: visibility check and middleware propagation (#3591) Fix query parameter serialization to respect OpenAPI explode/style settings (#3595) Fix dev apps form: union types, textarea support, JSON parsing (#3597) fix(google): replace deprecated /oauth2/v1/tokeninfo with /oauth2/v3/userinfo (#3603) fix: resolve EntraOBOToken dependency injection through MultiAuth (#3609) fix(docs): correct misleading stateless_http header (#3622) fix: filesystem provider import machinery (#3626) Closes #3625 (issues 2, 3, 6) fix: recover StdioTransport after subprocess exits (#3630) fix(server): preserve mounted tool task metadata (#3632) fix: scope deprecation warning filter to FastMCPDeprecationWarning (#3649) fix imports, add PrefabAppConfig (#3650) fix: resolve CurrentFastMCP/ctx.fastmcp to child server in mounted background tasks (#3651) Fix blocking docs issues: chart imports, Select API, Rx consistency (#3652) closed by default (#3657) Fix prompt caching middleware missing wrap/unwrap round-trip (#3666) fix: serialize object query params per OpenAPI style/explode rules (#3662) Fixes #2857 fix: HTTP request headers not accessible in background task workers (#3631) fix: restore HTTP headers in worker execution path for background tasks (#3681) fix: strip discriminator after dereferencing schemas (#3682) fix: remove stale ty:ignore directives for ty 0.0.26 (#3684) Fix docs gaps in app provider pages (#3690) fix: dev apps log panel UX improvements (#3698) fix dev server empty string args (#3700)
287 lines
10 KiB
Python
287 lines
10 KiB
Python
"""
|
|
Tests for the explicit task_meta parameter on FastMCP.read_resource().
|
|
|
|
These tests verify that the task_meta parameter provides explicit control
|
|
over sync vs task execution for resources and resource templates.
|
|
"""
|
|
|
|
import pytest
|
|
from mcp.shared.exceptions import McpError
|
|
|
|
from fastmcp import FastMCP
|
|
from fastmcp.client import Client
|
|
from fastmcp.resources.base import Resource
|
|
from fastmcp.resources.template import ResourceTemplate
|
|
from fastmcp.server.tasks.config import TaskMeta
|
|
|
|
|
|
class TestResourceTaskMetaParameter:
|
|
"""Tests for task_meta parameter on FastMCP.read_resource()."""
|
|
|
|
async def test_task_meta_none_returns_resource_result(self):
|
|
"""With task_meta=None (default), read_resource returns ResourceResult."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://test")
|
|
async def simple_resource() -> str:
|
|
return "hello world"
|
|
|
|
result = await server.read_resource("data://test")
|
|
|
|
assert result.contents[0].content == "hello world"
|
|
|
|
async def test_task_meta_none_on_task_enabled_resource_still_returns_result(self):
|
|
"""Even for task=True resources, task_meta=None returns ResourceResult."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://test", task=True)
|
|
async def task_enabled_resource() -> str:
|
|
return "hello world"
|
|
|
|
# Without task_meta, should execute synchronously
|
|
result = await server.read_resource("data://test")
|
|
|
|
assert result.contents[0].content == "hello world"
|
|
|
|
async def test_task_meta_on_forbidden_resource_raises_error(self):
|
|
"""Providing task_meta to a task=False resource raises McpError."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://test", task=False)
|
|
async def sync_only_resource() -> str:
|
|
return "hello"
|
|
|
|
with pytest.raises(McpError) as exc_info:
|
|
await server.read_resource("data://test", task_meta=TaskMeta())
|
|
|
|
assert "does not support task-augmented execution" in str(exc_info.value)
|
|
|
|
async def test_task_meta_fn_key_enrichment_for_resource(self):
|
|
"""Verify that fn_key enrichment uses Resource.make_key()."""
|
|
resource_uri = "data://my-resource"
|
|
expected_key = Resource.make_key(resource_uri)
|
|
|
|
assert expected_key == "resource:data://my-resource"
|
|
|
|
async def test_task_meta_fn_key_enrichment_for_template(self):
|
|
"""Verify that fn_key enrichment uses ResourceTemplate.make_key()."""
|
|
template_pattern = "data://{id}"
|
|
expected_key = ResourceTemplate.make_key(template_pattern)
|
|
|
|
assert expected_key == "template:data://{id}"
|
|
|
|
|
|
class TestResourceTemplateTaslMeta:
|
|
"""Tests for task_meta with resource templates."""
|
|
|
|
async def test_template_task_meta_none_returns_resource_result(self):
|
|
"""With task_meta=None, template read returns ResourceResult."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("item://{id}")
|
|
async def get_item(id: str) -> str:
|
|
return f"Item {id}"
|
|
|
|
result = await server.read_resource("item://42")
|
|
|
|
assert result.contents[0].content == "Item 42"
|
|
|
|
async def test_template_task_meta_on_task_enabled_template_returns_result(self):
|
|
"""Even for task=True templates, task_meta=None returns ResourceResult."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("item://{id}", task=True)
|
|
async def get_item(id: str) -> str:
|
|
return f"Item {id}"
|
|
|
|
# Without task_meta, should execute synchronously
|
|
result = await server.read_resource("item://42")
|
|
|
|
assert result.contents[0].content == "Item 42"
|
|
|
|
async def test_template_task_meta_on_forbidden_template_raises_error(self):
|
|
"""Providing task_meta to a task=False template raises McpError."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("item://{id}", task=False)
|
|
async def sync_only_template(id: str) -> str:
|
|
return f"Item {id}"
|
|
|
|
with pytest.raises(McpError) as exc_info:
|
|
await server.read_resource("item://42", task_meta=TaskMeta())
|
|
|
|
assert "does not support task-augmented execution" in str(exc_info.value)
|
|
|
|
|
|
class TestResourceTaskMetaClientIntegration:
|
|
"""Tests that task_meta works correctly with the Client for resources."""
|
|
|
|
async def test_client_read_resource_without_task_gets_immediate_result(self):
|
|
"""Client without task=True gets immediate result."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://test", task=True)
|
|
async def immediate_resource() -> str:
|
|
return "hello"
|
|
|
|
async with Client(server) as client:
|
|
result = await client.read_resource("data://test")
|
|
|
|
# Should get ReadResourceResult directly
|
|
assert "hello" in str(result)
|
|
|
|
async def test_client_read_resource_with_task_creates_task(self):
|
|
"""Client with task=True creates a background task."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://test", task=True)
|
|
async def task_resource() -> str:
|
|
return "hello"
|
|
|
|
async with Client(server) as client:
|
|
from fastmcp.client.tasks import ResourceTask
|
|
|
|
task = await client.read_resource("data://test", task=True)
|
|
|
|
assert isinstance(task, ResourceTask)
|
|
|
|
# Wait for result
|
|
result = await task.result()
|
|
assert "hello" in str(result)
|
|
|
|
async def test_client_read_template_with_task_creates_task(self):
|
|
"""Client with task=True on template creates a background task."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("item://{id}", task=True)
|
|
async def get_item(id: str) -> str:
|
|
return f"Item {id}"
|
|
|
|
async with Client(server) as client:
|
|
from fastmcp.client.tasks import ResourceTask
|
|
|
|
task = await client.read_resource("item://42", task=True)
|
|
|
|
assert isinstance(task, ResourceTask)
|
|
|
|
# Wait for result
|
|
result = await task.result()
|
|
assert "Item 42" in str(result)
|
|
|
|
|
|
class TestResourceTaskMetaDirectServerCall:
|
|
"""Tests for direct server read_resource calls with task_meta."""
|
|
|
|
async def test_resource_can_read_another_resource_with_task(self):
|
|
"""A resource can read another resource as a background task."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://inner", task=True)
|
|
async def inner_resource() -> str:
|
|
return "inner data"
|
|
|
|
@server.tool
|
|
async def outer_tool() -> str:
|
|
# Read inner resource as background task
|
|
result = await server.read_resource("data://inner", task_meta=TaskMeta())
|
|
# Should get CreateTaskResult since we provided task_meta
|
|
return f"Created task: {result.task.taskId}"
|
|
|
|
async with Client(server) as client:
|
|
result = await client.call_tool("outer_tool", {})
|
|
assert "Created task:" in str(result)
|
|
|
|
async def test_resource_can_read_another_resource_synchronously(self):
|
|
"""A resource can read another resource synchronously (no task_meta)."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://inner", task=True)
|
|
async def inner_resource() -> str:
|
|
return "inner data"
|
|
|
|
@server.tool
|
|
async def outer_tool() -> str:
|
|
# Read inner resource synchronously (no task_meta)
|
|
result = await server.read_resource("data://inner")
|
|
# Should get ResourceResult directly
|
|
return f"Got result: {result.contents[0].content}"
|
|
|
|
async with Client(server) as client:
|
|
result = await client.call_tool("outer_tool", {})
|
|
assert "Got result: inner data" in str(result)
|
|
|
|
async def test_resource_can_read_template_with_task(self):
|
|
"""A tool can read a resource template as a background task."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("item://{id}", task=True)
|
|
async def get_item(id: str) -> str:
|
|
return f"Item {id}"
|
|
|
|
@server.tool
|
|
async def outer_tool() -> str:
|
|
result = await server.read_resource("item://99", task_meta=TaskMeta())
|
|
return f"Created task: {result.task.taskId}"
|
|
|
|
async with Client(server) as client:
|
|
result = await client.call_tool("outer_tool", {})
|
|
assert "Created task:" in str(result)
|
|
|
|
async def test_resource_can_read_with_custom_ttl(self):
|
|
"""A tool can read a resource as a background task with custom TTL."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://inner", task=True)
|
|
async def inner_resource() -> str:
|
|
return "inner data"
|
|
|
|
@server.tool
|
|
async def outer_tool() -> str:
|
|
custom_ttl = 45000 # 45 seconds
|
|
result = await server.read_resource(
|
|
"data://inner", task_meta=TaskMeta(ttl=custom_ttl)
|
|
)
|
|
return f"Task TTL: {result.task.ttl}"
|
|
|
|
async with Client(server) as client:
|
|
result = await client.call_tool("outer_tool", {})
|
|
assert "Task TTL: 45000" in str(result)
|
|
|
|
|
|
class TestResourceTaskMetaTypeNarrowing:
|
|
"""Tests for type narrowing based on task_meta parameter."""
|
|
|
|
async def test_read_resource_without_task_meta_type_is_resource_result(self):
|
|
"""Calling read_resource without task_meta returns ResourceResult type."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://test")
|
|
async def simple_resource() -> str:
|
|
return "hello"
|
|
|
|
# This should type-check as ResourceResult, not the union type
|
|
result = await server.read_resource("data://test")
|
|
|
|
# No isinstance check needed - type is narrowed by overload
|
|
content = result.contents[0].content
|
|
assert content == "hello"
|
|
|
|
async def test_read_resource_with_task_meta_type_is_create_task_result(self):
|
|
"""Calling read_resource with task_meta returns CreateTaskResult type."""
|
|
server = FastMCP("test")
|
|
|
|
@server.resource("data://test", task=True)
|
|
async def task_resource() -> str:
|
|
return "hello"
|
|
|
|
async with Client(server) as client:
|
|
# Need to use client to get full task infrastructure
|
|
from fastmcp.client.tasks import ResourceTask
|
|
|
|
task = await client.read_resource("data://test", task=True)
|
|
assert isinstance(task, ResourceTask)
|
|
|
|
# For direct server call, we need the Client context for Docket
|
|
# This test verifies the overload works via client integration
|
|
result = await task.result()
|
|
assert "hello" in str(result)
|