mirror of
https://github.com/PrefectHQ/fastmcp.git
synced 2026-08-19 20:14:17 +02:00
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Jeremiah Lowin <jlowin@users.noreply.github.com> Co-authored-by: Marvin Context Protocol <41898282+Marvin Context Protocol@users.noreply.github.com> Co-authored-by: voidborne-d <voidborne-d@users.noreply.github.com> Co-authored-by: marvin-context-protocol[bot] <225465937+marvin-context-protocol[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: d 🔹 <258577966+voidborne-d@users.noreply.github.com> Co-authored-by: Jeremiah Lowin <153965+jlowin@users.noreply.github.com> Co-authored-by: nightcityblade <nightcityblade@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Bill Easton <strawgate@users.noreply.github.com> Co-authored-by: Sumanshu Nankana <sumanshunankana@gmail.com> Co-authored-by: Eric Robinson <ericrobinson@indeed.com> Co-authored-by: Martim Santos <martimfasantos@gmail.com> Co-authored-by: d 🔹 <liusway405@gmail.com> Co-authored-by: Matthieu B <66959271+mtthidoteu@users.noreply.github.com> Co-authored-by: Sascha Buehrle <47737812+saschabuehrle@users.noreply.github.com> Co-authored-by: Hakancan <142545736+hkc5@users.noreply.github.com> Co-authored-by: nightcityblade <jackchen@haloailabs.com> Co-authored-by: Matt Hallowell <17804673+mhallo@users.noreply.github.com> Co-authored-by: nate nowack <thrast36@gmail.com> Co-authored-by: Bill Easton <williamseaston@gmail.com> Co-authored-by: Marcus Shu <46469249+shulkx@users.noreply.github.com> Co-authored-by: Rushabh Doshi <radoshi@gmail.com> Co-authored-by: AIKAWA Shigechika <shige@aikawa.jp> Co-authored-by: Jeremy Simon <simonjer805@gmail.com> Co-authored-by: Miguel Miranda Dias <7780875+pandego@users.noreply.github.com> Co-authored-by: Anthony James Padavano <padavano.anthony@gmail.com> Co-authored-by: Mostafa Kamal <hiremostafa@gmail.com> Fix auto-close MRE script posting comment without closing (#3386) Fix WorkOS token scope verification bypass 🤖 Generated with Codex (#3407) Fix initialize McpError fallthrough 🤖 Generated with Codex (#3413) Fix transform arg collisions with passthrough params (#3431) Fix get_* returning None when latest version is disabled (#3439) Fix get_* returning None when latest version is disabled (#3421) Fix server lifespan overlap teardown (#3415) Fix $ref output schema object detection regression (#3420) resolved annotations (#3429) Fix async partial callables rejected by iscoroutinefunction (#3438) Fix async partial callables rejected by iscoroutinefunction (#3423) fix: add version to components (#3458) fix: use intent-based flag for OIDC scope patch in load_access_token (#3465) Fixes #3461 fix: normalize Google scope shorthands and surface valid_scopes (#3477) fix: resolve ty 0.0.23 type-checking errors and bump pin (#3481) fix: shield lifespan teardown from cancellation (#3480) fix: forward custom_route endpoints from mounted servers (#3462) fix updates _get_additional_http_routes() to traverse providers, Fixes #3457 fix: remove hardcoded version from CLI help text (#3456) fix: monty 0.0.8 compatibility, drop external_functions from constructor (#3468) fix: task test teardown hanging 5s per test (#3499) Closes #3498 fix: validate workspace path is a directory before cursor install (#3440) Fixes #3426 fix: handle re.error from malformed URI templates in build_regex (#3501) fix: reject empty/OIDC-only required_scopes in AzureProvider (#3503) fix: restrict $ref resolution to local refs only (SSRF/LFI) (#3502) fix warnings and timeouts (#3504) close upgrade check issue when build passes (#3505) Closes #3484 fix: URL-encode path params to prevent SSRF/path traversal (GHSA-vv7q-7jx5-f767) (#3507) fix: prevent path traversal in skill download (#3493) fix: prefer IdP-granted scopes over client-requested scopes in OAuthProxy (#3492) fix: remove unrelated transform and http.py changes from PR scope fix: remove forced follow_redirects from httpx_client_factory calls (#3496) fix: stop passing follow_redirects to httpx_client_factory fix: restore follow_redirects=True for custom httpx client factories Closes #3509 fix: CSRF double-submit cookie check in consent flow (#3519) fix: validate server names in install commands (#3522) fix: use raw strings for regex in pytest.raises match (#3523) fix: reject refresh tokens used as Bearer access tokens (#3524) fix: route ResourcesAsTools/PromptsAsTools through server middleware (#3495) fix: resolve Pyright "Module is not callable" on @tool, @resource, @prompt decorators (#3540) fix: filter warnings by message in KEY_PREFIX test (#3549) fix: suppress output schema for ToolResult subclass annotations (#3548) fix: increase sleep duration in proxy cache tests (#3567) fix: store absolute token expiry to prevent stale expires_in on reload (#3572) fix: preserve tool properties named 'title' during schema compression (#3582) Fix loopback redirect URI port matching per RFC 8252 §7.3 (#3589) Fix app tool routing: visibility check and middleware propagation (#3591) Fix query parameter serialization to respect OpenAPI explode/style settings (#3595) Fix dev apps form: union types, textarea support, JSON parsing (#3597) fix(google): replace deprecated /oauth2/v1/tokeninfo with /oauth2/v3/userinfo (#3603) fix: resolve EntraOBOToken dependency injection through MultiAuth (#3609) fix(docs): correct misleading stateless_http header (#3622) fix: filesystem provider import machinery (#3626) Closes #3625 (issues 2, 3, 6) fix: recover StdioTransport after subprocess exits (#3630) fix(server): preserve mounted tool task metadata (#3632) fix: scope deprecation warning filter to FastMCPDeprecationWarning (#3649) fix imports, add PrefabAppConfig (#3650) fix: resolve CurrentFastMCP/ctx.fastmcp to child server in mounted background tasks (#3651) Fix blocking docs issues: chart imports, Select API, Rx consistency (#3652) closed by default (#3657) Fix prompt caching middleware missing wrap/unwrap round-trip (#3666) fix: serialize object query params per OpenAPI style/explode rules (#3662) Fixes #2857 fix: HTTP request headers not accessible in background task workers (#3631) fix: restore HTTP headers in worker execution path for background tasks (#3681) fix: strip discriminator after dereferencing schemas (#3682) fix: remove stale ty:ignore directives for ty 0.0.26 (#3684) Fix docs gaps in app provider pages (#3690) fix: dev apps log panel UX improvements (#3698) fix dev server empty string args (#3700)
184 lines
6.4 KiB
Python
184 lines
6.4 KiB
Python
"""Tests for custom component subclasses with task support.
|
|
|
|
Verifies that custom Tool, Resource, and Prompt subclasses can use
|
|
background task execution by setting task_config.
|
|
"""
|
|
|
|
import asyncio
|
|
from typing import Any
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from fastmcp import FastMCP
|
|
from fastmcp.client import Client
|
|
from fastmcp.server.tasks import TaskConfig
|
|
from fastmcp.tools.base import Tool, ToolResult
|
|
from fastmcp.utilities.components import FastMCPComponent
|
|
|
|
|
|
class CustomTool(Tool):
|
|
"""A custom tool subclass with task support."""
|
|
|
|
task_config: TaskConfig = TaskConfig(mode="optional")
|
|
parameters: dict[str, Any] = {"type": "object", "properties": {}}
|
|
|
|
async def run(self, arguments: dict[str, Any]) -> ToolResult:
|
|
return ToolResult(content=f"Custom tool executed with {arguments}")
|
|
|
|
|
|
class CustomToolWithLogic(Tool):
|
|
"""A custom tool with actual async work."""
|
|
|
|
task_config: TaskConfig = TaskConfig(mode="optional")
|
|
parameters: dict[str, Any] = {
|
|
"type": "object",
|
|
"properties": {"duration": {"type": "integer"}},
|
|
}
|
|
|
|
async def run(self, arguments: dict[str, Any]) -> ToolResult:
|
|
duration = arguments.get("duration", 0)
|
|
await asyncio.sleep(duration * 0.01) # Short sleep for testing
|
|
return ToolResult(content=f"Completed after {duration} units")
|
|
|
|
|
|
class CustomToolForbidden(Tool):
|
|
"""A custom tool with task_config forbidden (default)."""
|
|
|
|
parameters: dict[str, Any] = {"type": "object", "properties": {}}
|
|
|
|
async def run(self, arguments: dict[str, Any]) -> ToolResult:
|
|
return ToolResult(content="Sync only")
|
|
|
|
|
|
@pytest.fixture
|
|
def custom_tool_server():
|
|
"""Create a server with custom tool subclasses."""
|
|
mcp = FastMCP("custom-tool-server")
|
|
mcp.add_tool(CustomTool(name="custom_tool", description="A custom tool"))
|
|
mcp.add_tool(
|
|
CustomToolWithLogic(name="custom_logic", description="Custom tool with logic")
|
|
)
|
|
mcp.add_tool(
|
|
CustomToolForbidden(name="custom_forbidden", description="No task support")
|
|
)
|
|
return mcp
|
|
|
|
|
|
async def test_custom_tool_sync_execution(custom_tool_server):
|
|
"""Custom tool executes synchronously when no task metadata."""
|
|
async with Client(custom_tool_server) as client:
|
|
result = await client.call_tool("custom_tool", {})
|
|
assert "Custom tool executed" in str(result)
|
|
|
|
|
|
async def test_custom_tool_background_execution(custom_tool_server):
|
|
"""Custom tool executes as background task when task=True."""
|
|
async with Client(custom_tool_server) as client:
|
|
task = await client.call_tool("custom_tool", {}, task=True)
|
|
|
|
assert task is not None
|
|
assert not task.returned_immediately
|
|
assert task.task_id is not None
|
|
|
|
# Wait for result
|
|
result = await task.result()
|
|
assert "Custom tool executed" in str(result)
|
|
|
|
|
|
async def test_custom_tool_with_arguments(custom_tool_server):
|
|
"""Custom tool receives arguments correctly in background execution."""
|
|
async with Client(custom_tool_server) as client:
|
|
task = await client.call_tool("custom_logic", {"duration": 1}, task=True)
|
|
|
|
assert task is not None
|
|
result = await task.result()
|
|
assert "Completed after 1 units" in str(result)
|
|
|
|
|
|
async def test_custom_tool_forbidden_sync_only(custom_tool_server):
|
|
"""Custom tool with forbidden mode executes sync only."""
|
|
async with Client(custom_tool_server) as client:
|
|
# Sync execution works
|
|
result = await client.call_tool("custom_forbidden", {})
|
|
assert "Sync only" in str(result)
|
|
|
|
|
|
async def test_custom_tool_forbidden_rejects_task(custom_tool_server):
|
|
"""Custom tool with forbidden mode returns error for task request."""
|
|
async with Client(custom_tool_server) as client:
|
|
task = await client.call_tool("custom_forbidden", {}, task=True)
|
|
|
|
# Should return immediately with error
|
|
assert task.returned_immediately
|
|
|
|
|
|
async def test_custom_tool_registers_with_docket():
|
|
"""Verify custom tool's register_with_docket is called during server startup."""
|
|
from unittest.mock import MagicMock
|
|
|
|
tool = CustomTool(name="test", description="test")
|
|
mock_docket = MagicMock()
|
|
|
|
tool.register_with_docket(mock_docket)
|
|
|
|
# Should register self.run with docket using prefixed key
|
|
mock_docket.register.assert_called_once()
|
|
call_args = mock_docket.register.call_args
|
|
assert call_args[1]["names"] == ["tool:test@"]
|
|
|
|
|
|
async def test_custom_tool_forbidden_does_not_register():
|
|
"""Verify custom tool with forbidden mode doesn't register with docket."""
|
|
tool = CustomToolForbidden(name="test", description="test")
|
|
mock_docket = MagicMock()
|
|
|
|
tool.register_with_docket(mock_docket)
|
|
|
|
# Should NOT register
|
|
mock_docket.register.assert_not_called()
|
|
|
|
|
|
# ==============================================================================
|
|
# Base FastMCPComponent Tests
|
|
# ==============================================================================
|
|
|
|
|
|
class TestFastMCPComponentDocketMethods:
|
|
"""Tests for base FastMCPComponent docket integration."""
|
|
|
|
def test_default_task_config_is_forbidden(self):
|
|
"""Base component defaults to task_config mode='forbidden'."""
|
|
component = FastMCPComponent(name="test")
|
|
assert component.task_config.mode == "forbidden"
|
|
|
|
def test_register_with_docket_is_noop(self):
|
|
"""Base register_with_docket does nothing (subclasses override)."""
|
|
component = FastMCPComponent(name="test")
|
|
mock_docket = MagicMock()
|
|
|
|
# Should not raise, just no-op
|
|
component.register_with_docket(mock_docket)
|
|
|
|
# Should not have called any docket methods
|
|
mock_docket.register.assert_not_called()
|
|
|
|
async def test_add_to_docket_raises_when_forbidden(self):
|
|
"""Base add_to_docket raises RuntimeError when mode is 'forbidden'."""
|
|
component = FastMCPComponent(name="test")
|
|
mock_docket = MagicMock()
|
|
|
|
with pytest.raises(RuntimeError, match="task execution not supported"):
|
|
await component.add_to_docket(mock_docket)
|
|
|
|
async def test_add_to_docket_raises_not_implemented_when_allowed(self):
|
|
"""Base add_to_docket raises NotImplementedError when not forbidden."""
|
|
component = FastMCPComponent(
|
|
name="test", task_config=TaskConfig(mode="optional")
|
|
)
|
|
mock_docket = MagicMock()
|
|
|
|
with pytest.raises(
|
|
NotImplementedError, match="does not implement add_to_docket"
|
|
):
|
|
await component.add_to_docket(mock_docket)
|