mirror of
https://github.com/PrefectHQ/fastmcp.git
synced 2026-08-23 14:04:18 +02:00
2f9b74beb4
- Replace rpc.system/rpc.service/rpc.method with gen_ai.tool.name and gen_ai.prompt.name on server and client spans - Set error.type to exception class name and include str(e) in status description on error spans - Always set mcp.session.id when session_id is not None (was truthy check) - Move _parse_call_tool_result inside client_span so ToolError is captured - Pass tool_name/prompt_name through server_span and client_span calls - Add method attribute to delegate_span for mounted providers Closes #3886 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
80 lines
2.5 KiB
Python
80 lines
2.5 KiB
Python
"""Tests for mcp.method.name attribute on delegate spans."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter
|
|
|
|
from fastmcp import FastMCP
|
|
|
|
|
|
class TestDelegateSpanMethod:
|
|
"""Tests that delegate spans include mcp.method.name."""
|
|
|
|
async def test_mounted_tool_delegate_has_method(
|
|
self, trace_exporter: InMemorySpanExporter
|
|
):
|
|
child = FastMCP("child-server")
|
|
|
|
@child.tool()
|
|
def child_tool() -> str:
|
|
return "result"
|
|
|
|
parent = FastMCP("parent-server")
|
|
parent.mount(child, namespace="child")
|
|
|
|
await parent.call_tool("child_child_tool", {})
|
|
|
|
spans = trace_exporter.get_finished_spans()
|
|
delegate_span = next(
|
|
(s for s in spans if s.name == "delegate child_tool"), None
|
|
)
|
|
assert delegate_span is not None
|
|
assert delegate_span.attributes is not None
|
|
assert delegate_span.attributes["mcp.method.name"] == "tools/call"
|
|
|
|
async def test_mounted_resource_delegate_has_method(
|
|
self, trace_exporter: InMemorySpanExporter
|
|
):
|
|
child = FastMCP("child-server")
|
|
|
|
@child.resource("data://config")
|
|
def child_config() -> str:
|
|
return "config data"
|
|
|
|
parent = FastMCP("parent-server")
|
|
parent.mount(child, namespace="child")
|
|
|
|
await parent.read_resource("data://child/config")
|
|
|
|
spans = trace_exporter.get_finished_spans()
|
|
delegate_spans = [
|
|
s
|
|
for s in spans
|
|
if s.name.startswith("delegate") and "data://config" in s.name
|
|
]
|
|
assert len(delegate_spans) >= 1
|
|
span = delegate_spans[0]
|
|
assert span.attributes is not None
|
|
assert span.attributes["mcp.method.name"] == "resources/read"
|
|
|
|
async def test_mounted_prompt_delegate_has_method(
|
|
self, trace_exporter: InMemorySpanExporter
|
|
):
|
|
child = FastMCP("child-server")
|
|
|
|
@child.prompt()
|
|
def child_prompt() -> str:
|
|
return "Hello from child!"
|
|
|
|
parent = FastMCP("parent-server")
|
|
parent.mount(child, namespace="child")
|
|
|
|
await parent.render_prompt("child_child_prompt", {})
|
|
|
|
spans = trace_exporter.get_finished_spans()
|
|
delegate_span = next(
|
|
(s for s in spans if s.name == "delegate child_prompt"), None
|
|
)
|
|
assert delegate_span is not None
|
|
assert delegate_span.attributes is not None
|
|
assert delegate_span.attributes["mcp.method.name"] == "prompts/get"
|