mirror of
https://github.com/PrefectHQ/fastmcp.git
synced 2026-08-09 07:09:11 +02:00
8a13032419* Use standard traceparent/tracestate keys per OTel MCP semconv The OTel semantic conventions for MCP (https://opentelemetry.io/docs/specs/semconv/gen-ai/mcp/) put `traceparent` and `tracestate` directly in `params._meta` without a prefix. FastMCP was using `fastmcp.traceparent` / `fastmcp.tracestate`, which meant non-FastMCP clients sending the standard keys couldn't propagate traces. Switches injection to the bare keys and adds fallback extraction for the old prefixed keys so older FastMCP clients still work. 🤖 Generated with Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: Update SDK documentation * Drop legacy fastmcp.-prefixed trace key fallback 🤖 Generated with Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: Update SDK documentation --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: marvin-context-protocol[bot] <225465937+marvin-context-protocol[bot]@users.noreply.github.com>
83 lines
2.6 KiB
Python
83 lines
2.6 KiB
Python
"""Tests for the core telemetry module."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from opentelemetry import trace
|
|
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter
|
|
|
|
from fastmcp.server.telemetry import get_auth_span_attributes
|
|
from fastmcp.telemetry import (
|
|
INSTRUMENTATION_NAME,
|
|
TRACE_PARENT_KEY,
|
|
extract_trace_context,
|
|
get_tracer,
|
|
inject_trace_context,
|
|
)
|
|
|
|
|
|
class TestGetTracer:
|
|
def test_tracer_uses_instrumentation_name(
|
|
self, trace_exporter: InMemorySpanExporter
|
|
):
|
|
tracer = get_tracer()
|
|
with tracer.start_as_current_span("test-span"):
|
|
pass
|
|
|
|
spans = trace_exporter.get_finished_spans()
|
|
assert len(spans) == 1
|
|
scope = spans[0].instrumentation_scope
|
|
assert scope is not None
|
|
assert scope.name == INSTRUMENTATION_NAME
|
|
|
|
|
|
class TestGetAuthSpanAttributes:
|
|
def test_returns_empty_dict_when_no_context(self):
|
|
attrs = get_auth_span_attributes()
|
|
assert attrs == {}
|
|
|
|
|
|
VALID_TRACEPARENT = "00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01"
|
|
VALID_TRACESTATE = "congo=t61rcWkgMzE"
|
|
|
|
|
|
class TestInjectTraceContext:
|
|
def test_injects_bare_keys(self, trace_exporter: InMemorySpanExporter):
|
|
tracer = get_tracer()
|
|
with tracer.start_as_current_span("test"):
|
|
meta = inject_trace_context()
|
|
|
|
assert meta is not None
|
|
assert TRACE_PARENT_KEY in meta
|
|
assert meta[TRACE_PARENT_KEY].startswith("00-")
|
|
|
|
|
|
class TestExtractTraceContext:
|
|
def test_bare_traceparent(self, trace_exporter: InMemorySpanExporter):
|
|
ctx = extract_trace_context({"traceparent": VALID_TRACEPARENT})
|
|
span_ctx = trace.get_current_span(ctx).get_span_context()
|
|
assert span_ctx.is_valid
|
|
assert format(span_ctx.trace_id, "032x") == "0af7651916cd43dd8448eb211c80319c"
|
|
|
|
def test_bare_tracestate(self, trace_exporter: InMemorySpanExporter):
|
|
ctx = extract_trace_context(
|
|
{
|
|
"traceparent": VALID_TRACEPARENT,
|
|
"tracestate": VALID_TRACESTATE,
|
|
}
|
|
)
|
|
span_ctx = trace.get_current_span(ctx).get_span_context()
|
|
assert span_ctx.is_valid
|
|
assert span_ctx.trace_state.get("congo") == "t61rcWkgMzE"
|
|
|
|
def test_none_meta_returns_current_context(
|
|
self, trace_exporter: InMemorySpanExporter
|
|
):
|
|
ctx = extract_trace_context(None)
|
|
assert ctx is not None
|
|
|
|
def test_empty_meta_returns_current_context(
|
|
self, trace_exporter: InMemorySpanExporter
|
|
):
|
|
ctx = extract_trace_context({})
|
|
span_ctx = trace.get_current_span(ctx).get_span_context()
|
|
assert not span_ctx.is_valid
|