mirror of
https://github.com/PrefectHQ/fastmcp.git
synced 2026-09-01 20:13:19 +02:00
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Jeremiah Lowin <jlowin@users.noreply.github.com> Co-authored-by: Marvin Context Protocol <41898282+Marvin Context Protocol@users.noreply.github.com> Co-authored-by: voidborne-d <voidborne-d@users.noreply.github.com> Co-authored-by: marvin-context-protocol[bot] <225465937+marvin-context-protocol[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: d 🔹 <258577966+voidborne-d@users.noreply.github.com> Co-authored-by: Jeremiah Lowin <153965+jlowin@users.noreply.github.com> Co-authored-by: nightcityblade <nightcityblade@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Bill Easton <strawgate@users.noreply.github.com> Co-authored-by: Sumanshu Nankana <sumanshunankana@gmail.com> Co-authored-by: Eric Robinson <ericrobinson@indeed.com> Co-authored-by: Martim Santos <martimfasantos@gmail.com> Co-authored-by: d 🔹 <liusway405@gmail.com> Co-authored-by: Matthieu B <66959271+mtthidoteu@users.noreply.github.com> Co-authored-by: Sascha Buehrle <47737812+saschabuehrle@users.noreply.github.com> Co-authored-by: Hakancan <142545736+hkc5@users.noreply.github.com> Co-authored-by: nightcityblade <jackchen@haloailabs.com> Co-authored-by: Matt Hallowell <17804673+mhallo@users.noreply.github.com> Co-authored-by: nate nowack <thrast36@gmail.com> Co-authored-by: Bill Easton <williamseaston@gmail.com> Co-authored-by: Marcus Shu <46469249+shulkx@users.noreply.github.com> Co-authored-by: Rushabh Doshi <radoshi@gmail.com> Co-authored-by: AIKAWA Shigechika <shige@aikawa.jp> Co-authored-by: Jeremy Simon <simonjer805@gmail.com> Co-authored-by: Miguel Miranda Dias <7780875+pandego@users.noreply.github.com> Co-authored-by: Anthony James Padavano <padavano.anthony@gmail.com> Co-authored-by: Mostafa Kamal <hiremostafa@gmail.com> Fix auto-close MRE script posting comment without closing (#3386) Fix WorkOS token scope verification bypass 🤖 Generated with Codex (#3407) Fix initialize McpError fallthrough 🤖 Generated with Codex (#3413) Fix transform arg collisions with passthrough params (#3431) Fix get_* returning None when latest version is disabled (#3439) Fix get_* returning None when latest version is disabled (#3421) Fix server lifespan overlap teardown (#3415) Fix $ref output schema object detection regression (#3420) resolved annotations (#3429) Fix async partial callables rejected by iscoroutinefunction (#3438) Fix async partial callables rejected by iscoroutinefunction (#3423) fix: add version to components (#3458) fix: use intent-based flag for OIDC scope patch in load_access_token (#3465) Fixes #3461 fix: normalize Google scope shorthands and surface valid_scopes (#3477) fix: resolve ty 0.0.23 type-checking errors and bump pin (#3481) fix: shield lifespan teardown from cancellation (#3480) fix: forward custom_route endpoints from mounted servers (#3462) fix updates _get_additional_http_routes() to traverse providers, Fixes #3457 fix: remove hardcoded version from CLI help text (#3456) fix: monty 0.0.8 compatibility, drop external_functions from constructor (#3468) fix: task test teardown hanging 5s per test (#3499) Closes #3498 fix: validate workspace path is a directory before cursor install (#3440) Fixes #3426 fix: handle re.error from malformed URI templates in build_regex (#3501) fix: reject empty/OIDC-only required_scopes in AzureProvider (#3503) fix: restrict $ref resolution to local refs only (SSRF/LFI) (#3502) fix warnings and timeouts (#3504) close upgrade check issue when build passes (#3505) Closes #3484 fix: URL-encode path params to prevent SSRF/path traversal (GHSA-vv7q-7jx5-f767) (#3507) fix: prevent path traversal in skill download (#3493) fix: prefer IdP-granted scopes over client-requested scopes in OAuthProxy (#3492) fix: remove unrelated transform and http.py changes from PR scope fix: remove forced follow_redirects from httpx_client_factory calls (#3496) fix: stop passing follow_redirects to httpx_client_factory fix: restore follow_redirects=True for custom httpx client factories Closes #3509 fix: CSRF double-submit cookie check in consent flow (#3519) fix: validate server names in install commands (#3522) fix: use raw strings for regex in pytest.raises match (#3523) fix: reject refresh tokens used as Bearer access tokens (#3524) fix: route ResourcesAsTools/PromptsAsTools through server middleware (#3495) fix: resolve Pyright "Module is not callable" on @tool, @resource, @prompt decorators (#3540) fix: filter warnings by message in KEY_PREFIX test (#3549) fix: suppress output schema for ToolResult subclass annotations (#3548) fix: increase sleep duration in proxy cache tests (#3567) fix: store absolute token expiry to prevent stale expires_in on reload (#3572) fix: preserve tool properties named 'title' during schema compression (#3582) Fix loopback redirect URI port matching per RFC 8252 §7.3 (#3589) Fix app tool routing: visibility check and middleware propagation (#3591) Fix query parameter serialization to respect OpenAPI explode/style settings (#3595) Fix dev apps form: union types, textarea support, JSON parsing (#3597) fix(google): replace deprecated /oauth2/v1/tokeninfo with /oauth2/v3/userinfo (#3603) fix: resolve EntraOBOToken dependency injection through MultiAuth (#3609) fix(docs): correct misleading stateless_http header (#3622) fix: filesystem provider import machinery (#3626) Closes #3625 (issues 2, 3, 6) fix: recover StdioTransport after subprocess exits (#3630) fix(server): preserve mounted tool task metadata (#3632) fix: scope deprecation warning filter to FastMCPDeprecationWarning (#3649) fix imports, add PrefabAppConfig (#3650) fix: resolve CurrentFastMCP/ctx.fastmcp to child server in mounted background tasks (#3651) Fix blocking docs issues: chart imports, Select API, Rx consistency (#3652) closed by default (#3657) Fix prompt caching middleware missing wrap/unwrap round-trip (#3666) fix: serialize object query params per OpenAPI style/explode rules (#3662) Fixes #2857 fix: HTTP request headers not accessible in background task workers (#3631) fix: restore HTTP headers in worker execution path for background tasks (#3681) fix: strip discriminator after dereferencing schemas (#3682) fix: remove stale ty:ignore directives for ty 0.0.26 (#3684) Fix docs gaps in app provider pages (#3690) fix: dev apps log panel UX improvements (#3698) fix dev server empty string args (#3700)
263 lines
10 KiB
Python
263 lines
10 KiB
Python
import ssl
|
|
from ssl import VerifyMode
|
|
from typing import cast
|
|
|
|
import httpx
|
|
import pytest
|
|
from mcp.shared._httpx_utils import McpHttpClientFactory
|
|
|
|
from fastmcp import Client
|
|
from fastmcp.client.auth.oauth import OAuth
|
|
from fastmcp.client.transports import SSETransport, StreamableHttpTransport
|
|
|
|
|
|
async def test_oauth_uses_same_client_as_transport_streamable_http():
|
|
transport = StreamableHttpTransport(
|
|
"https://some.fake.url/",
|
|
httpx_client_factory=lambda *args, **kwargs: httpx.AsyncClient(
|
|
verify=False, *args, **kwargs
|
|
),
|
|
auth="oauth",
|
|
)
|
|
|
|
assert isinstance(transport.auth, OAuth)
|
|
async with transport.auth.httpx_client_factory() as httpx_client:
|
|
assert httpx_client._transport is not None
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode # type: ignore[attr-defined] # ty:ignore[unresolved-attribute]
|
|
== VerifyMode.CERT_NONE
|
|
)
|
|
|
|
|
|
async def test_oauth_uses_same_client_as_transport_sse():
|
|
transport = SSETransport(
|
|
"https://some.fake.url/",
|
|
httpx_client_factory=lambda *args, **kwargs: httpx.AsyncClient(
|
|
verify=False, *args, **kwargs
|
|
),
|
|
auth="oauth",
|
|
)
|
|
|
|
assert isinstance(transport.auth, OAuth)
|
|
async with transport.auth.httpx_client_factory() as httpx_client:
|
|
assert httpx_client._transport is not None
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode # type: ignore[attr-defined] # ty:ignore[unresolved-attribute]
|
|
== VerifyMode.CERT_NONE
|
|
)
|
|
|
|
|
|
class TestSSLVerify:
|
|
def test_streamable_http_transport_stores_verify_false(self):
|
|
transport = StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
verify=False,
|
|
)
|
|
assert transport.verify is False
|
|
|
|
def test_streamable_http_transport_stores_verify_ssl_context(self):
|
|
ctx = ssl.create_default_context()
|
|
transport = StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
verify=ctx,
|
|
)
|
|
assert transport.verify is ctx
|
|
|
|
def test_streamable_http_transport_stores_verify_cert_path(self):
|
|
transport = StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
verify="/path/to/cert.pem",
|
|
)
|
|
assert transport.verify == "/path/to/cert.pem"
|
|
|
|
def test_streamable_http_transport_verify_default_is_none(self):
|
|
transport = StreamableHttpTransport("https://example.com/mcp")
|
|
assert transport.verify is None
|
|
|
|
def test_sse_transport_stores_verify_false(self):
|
|
transport = SSETransport(
|
|
"https://example.com/sse",
|
|
verify=False,
|
|
)
|
|
assert transport.verify is False
|
|
|
|
def test_sse_transport_stores_verify_ssl_context(self):
|
|
ctx = ssl.create_default_context()
|
|
transport = SSETransport(
|
|
"https://example.com/sse",
|
|
verify=ctx,
|
|
)
|
|
assert transport.verify is ctx
|
|
|
|
def test_sse_transport_verify_default_is_none(self):
|
|
transport = SSETransport("https://example.com/sse")
|
|
assert transport.verify is None
|
|
|
|
def test_client_passes_verify_to_streamable_http_transport(self):
|
|
client = Client("https://example.com/mcp", verify=False)
|
|
assert isinstance(client.transport, StreamableHttpTransport)
|
|
assert client.transport.verify is False
|
|
|
|
def test_client_passes_verify_ssl_context_to_transport(self):
|
|
ctx = ssl.create_default_context()
|
|
client = Client("https://example.com/mcp", verify=ctx)
|
|
assert isinstance(client.transport, StreamableHttpTransport)
|
|
assert client.transport.verify is ctx
|
|
|
|
def test_client_passes_verify_cert_path_to_transport(self):
|
|
client = Client(
|
|
"https://example.com/mcp",
|
|
verify="/path/to/cert.pem",
|
|
)
|
|
assert isinstance(client.transport, StreamableHttpTransport)
|
|
assert client.transport.verify == "/path/to/cert.pem"
|
|
|
|
def test_client_verify_none_leaves_transport_default(self):
|
|
client = Client("https://example.com/mcp")
|
|
assert isinstance(client.transport, StreamableHttpTransport)
|
|
assert client.transport.verify is None
|
|
|
|
def test_client_verify_raises_for_non_http_transport(self):
|
|
from fastmcp import FastMCP
|
|
|
|
server = FastMCP("test")
|
|
with pytest.raises(
|
|
ValueError,
|
|
match="only supported for HTTP transports",
|
|
):
|
|
Client(server, verify=False)
|
|
|
|
def test_client_passes_verify_to_sse_transport(self):
|
|
client = Client("https://example.com/sse", verify=False)
|
|
assert isinstance(client.transport, SSETransport)
|
|
assert client.transport.verify is False
|
|
|
|
async def test_streamable_http_verify_propagates_to_oauth(self):
|
|
transport = StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
verify=False,
|
|
auth="oauth",
|
|
)
|
|
assert isinstance(transport.auth, OAuth)
|
|
async with transport.auth.httpx_client_factory() as httpx_client:
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode # type: ignore[attr-defined] # ty:ignore[unresolved-attribute]
|
|
== VerifyMode.CERT_NONE
|
|
)
|
|
|
|
async def test_sse_verify_propagates_to_oauth(self):
|
|
transport = SSETransport(
|
|
"https://example.com/sse",
|
|
verify=False,
|
|
auth="oauth",
|
|
)
|
|
assert isinstance(transport.auth, OAuth)
|
|
async with transport.auth.httpx_client_factory() as httpx_client:
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode # type: ignore[attr-defined] # ty:ignore[unresolved-attribute]
|
|
== VerifyMode.CERT_NONE
|
|
)
|
|
|
|
async def test_client_verify_propagates_to_oauth(self):
|
|
client = Client(
|
|
"https://example.com/mcp",
|
|
verify=False,
|
|
auth="oauth",
|
|
)
|
|
assert isinstance(client.transport, StreamableHttpTransport)
|
|
assert isinstance(client.transport.auth, OAuth)
|
|
async with client.transport.auth.httpx_client_factory() as httpx_client:
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode # type: ignore[attr-defined] # ty:ignore[unresolved-attribute]
|
|
== VerifyMode.CERT_NONE
|
|
)
|
|
|
|
async def test_verify_propagates_to_preconstructed_oauth_instance(self):
|
|
transport = StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
verify=False,
|
|
auth=OAuth(),
|
|
)
|
|
assert isinstance(transport.auth, OAuth)
|
|
async with transport.auth.httpx_client_factory() as httpx_client:
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode # type: ignore[attr-defined] # ty:ignore[unresolved-attribute]
|
|
== VerifyMode.CERT_NONE
|
|
)
|
|
|
|
async def test_client_verify_resyncs_existing_oauth_on_transport(self):
|
|
transport = StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
auth="oauth",
|
|
)
|
|
assert isinstance(transport.auth, OAuth)
|
|
# OAuth was created without verify — factory should be default
|
|
async with transport.auth.httpx_client_factory() as httpx_client:
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode # type: ignore[attr-defined] # ty:ignore[unresolved-attribute]
|
|
!= VerifyMode.CERT_NONE
|
|
)
|
|
|
|
# Now wrap in Client with verify=False — should resync OAuth
|
|
client = Client(transport, verify=False)
|
|
assert isinstance(client.transport.auth, OAuth)
|
|
async with client.transport.auth.httpx_client_factory() as httpx_client:
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode
|
|
== VerifyMode.CERT_NONE
|
|
)
|
|
|
|
async def test_client_verify_overrides_transport_verify_in_oauth(self):
|
|
transport = StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
verify=False,
|
|
auth="oauth",
|
|
)
|
|
assert isinstance(transport.auth, OAuth)
|
|
# OAuth should initially have verify=False
|
|
async with transport.auth.httpx_client_factory() as httpx_client:
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode # type: ignore[attr-defined] # ty:ignore[unresolved-attribute]
|
|
== VerifyMode.CERT_NONE
|
|
)
|
|
|
|
# Client overrides verify to True — OAuth should update
|
|
client = Client(transport, verify=True)
|
|
assert isinstance(client.transport.auth, OAuth)
|
|
async with client.transport.auth.httpx_client_factory() as httpx_client:
|
|
assert (
|
|
httpx_client._transport._pool._ssl_context.verify_mode
|
|
!= VerifyMode.CERT_NONE
|
|
)
|
|
|
|
async def test_oauth_custom_factory_preserved_with_verify(self):
|
|
custom_factory = cast(
|
|
McpHttpClientFactory,
|
|
lambda **kwargs: httpx.AsyncClient(verify=False, **kwargs),
|
|
)
|
|
auth = OAuth(httpx_client_factory=custom_factory)
|
|
transport = StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
verify=True,
|
|
auth=auth,
|
|
)
|
|
assert isinstance(transport.auth, OAuth)
|
|
assert transport.auth.httpx_client_factory is custom_factory
|
|
|
|
def test_warns_when_both_factory_and_verify_provided_streamable(self):
|
|
factory = cast(McpHttpClientFactory, httpx.AsyncClient)
|
|
with pytest.warns(UserWarning, match="httpx_client_factory.*takes precedence"):
|
|
StreamableHttpTransport(
|
|
"https://example.com/mcp",
|
|
httpx_client_factory=factory,
|
|
verify=False,
|
|
)
|
|
|
|
def test_warns_when_both_factory_and_verify_provided_sse(self):
|
|
factory = cast(McpHttpClientFactory, httpx.AsyncClient)
|
|
with pytest.warns(UserWarning, match="httpx_client_factory.*takes precedence"):
|
|
SSETransport(
|
|
"https://example.com/sse",
|
|
httpx_client_factory=factory,
|
|
verify=False,
|
|
)
|