mirror of
https://github.com/PrefectHQ/fastmcp.git
synced 2026-08-15 10:09:11 +02:00
05ac9457b8Allow traceback-related kwargs to override defaults by building a dict with defaults first, then updating with user-provided values. Fixes #2356 Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: William Easton <strawgate@users.noreply.github.com>
56 lines
2 KiB
Python
56 lines
2 KiB
Python
import logging
|
|
|
|
from fastmcp.utilities.logging import configure_logging, get_logger
|
|
|
|
|
|
def test_logging_doesnt_affect_other_loggers(caplog):
|
|
# set FastMCP loggers to CRITICAL and ensure other loggers still emit messages
|
|
original_level = logging.getLogger("fastmcp").getEffectiveLevel()
|
|
|
|
try:
|
|
logging.getLogger("fastmcp").setLevel(logging.CRITICAL)
|
|
|
|
root_logger = logging.getLogger()
|
|
app_logger = logging.getLogger("app")
|
|
fastmcp_logger = logging.getLogger("fastmcp")
|
|
fastmcp_server_logger = get_logger("server")
|
|
|
|
with caplog.at_level(logging.INFO):
|
|
root_logger.info("--ROOT--")
|
|
app_logger.info("--APP--")
|
|
fastmcp_logger.info("--FASTMCP--")
|
|
fastmcp_server_logger.info("--FASTMCP SERVER--")
|
|
|
|
assert "--ROOT--" in caplog.text
|
|
assert "--APP--" in caplog.text
|
|
assert "--FASTMCP--" not in caplog.text
|
|
assert "--FASTMCP SERVER--" not in caplog.text
|
|
|
|
finally:
|
|
logging.getLogger("fastmcp").setLevel(original_level)
|
|
|
|
|
|
def test_configure_logging_with_traceback_kwargs():
|
|
"""Test that traceback-related kwargs can be passed without causing duplicate argument errors."""
|
|
# This should not raise TypeError about duplicate keyword arguments
|
|
configure_logging(enable_rich_tracebacks=True, tracebacks_max_frames=20)
|
|
|
|
# Verify the logger was configured
|
|
logger = logging.getLogger("fastmcp")
|
|
assert logger.handlers
|
|
assert len(logger.handlers) == 2 # One for normal logs, one for tracebacks
|
|
|
|
|
|
def test_configure_logging_traceback_defaults_can_be_overridden():
|
|
"""Test that default traceback settings can be overridden by kwargs."""
|
|
configure_logging(
|
|
enable_rich_tracebacks=True,
|
|
tracebacks_max_frames=20,
|
|
show_path=True,
|
|
show_level=True,
|
|
)
|
|
|
|
logger = logging.getLogger("fastmcp")
|
|
assert logger.handlers
|
|
# The traceback handler should have been created with custom values
|
|
# We can't directly inspect RichHandler internals easily, but we verified no error was raised
|