From 177eeaee502cb00704f3127455b9cb1d9daecfeb Mon Sep 17 00:00:00 2001 From: William Easton Date: Thu, 4 Dec 2025 17:37:41 -0600 Subject: [PATCH 1/4] Less noise --- .github/workflows/martian-test-failure.yml | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.github/workflows/martian-test-failure.yml b/.github/workflows/martian-test-failure.yml index bd0df80a2..337b33f40 100644 --- a/.github/workflows/martian-test-failure.yml +++ b/.github/workflows/martian-test-failure.yml @@ -104,7 +104,9 @@ jobs: # Important Guidelines - - Be concise and actionable - developers want to quickly understand and fix the issue + - Be concise and actionable - developers want to quickly understand and fix the issue. Provide + additional context, references, etc in collapsible details blocks to ensure that the comment you're adding + is short and easy to read but additional information is a click away. - Focus on facts from the logs and code, not speculation - If you can't determine the root cause, say so clearly - Provide specific file names, line numbers, and code references when possible @@ -119,12 +121,19 @@ jobs: - Your previous analysis triggered CodeRabbit or another bot - This created a repeating cycle of bot comments - # CRITICAL: ANGRY USERS - **IMPORTANT**: If the user is angry with you, the triage bot, don't respond. Just exit immediately without further action. - If you detect such a loop (e.g., you see multiple similar bot comments or your own previous analysis comments): 1. **DO NOT** post another analysis comment 2. Exit immediately without further action + + # CRITICAL: ANGRY USERS + **IMPORTANT**: If the user is angry with you, the triage bot, don't respond. Just exit immediately without further action. + If at any point in the conversation the user has asked you to stop replying to the thread, just exit immediately. + + If you are posting the same suggestion as you have previously made, do not post the suggestion again. + + # IMPORTANT: EDIT YOUR COMMENT + Do not post a new comment every time you triage a failing workflow. If a previous comment has been posted by you (marvin) + in a previous triage, edit that comment do not add a new comment for each failure. # Problems Encountered If you encounter any problems during your analysis (e.g., unable to fetch logs, tools not working), document them clearly so the team knows what limitations you faced. From 8c2675447f1d6b9a8d6256704e59283b090a6812 Mon Sep 17 00:00:00 2001 From: William Easton Date: Thu, 4 Dec 2025 17:39:51 -0600 Subject: [PATCH 2/4] Update martian-test-failure.yml --- .github/workflows/martian-test-failure.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/martian-test-failure.yml b/.github/workflows/martian-test-failure.yml index 337b33f40..772f6384e 100644 --- a/.github/workflows/martian-test-failure.yml +++ b/.github/workflows/martian-test-failure.yml @@ -124,7 +124,7 @@ jobs: If you detect such a loop (e.g., you see multiple similar bot comments or your own previous analysis comments): 1. **DO NOT** post another analysis comment 2. Exit immediately without further action - + # CRITICAL: ANGRY USERS **IMPORTANT**: If the user is angry with you, the triage bot, don't respond. Just exit immediately without further action. If at any point in the conversation the user has asked you to stop replying to the thread, just exit immediately. From 5838e9010526b70214db3946413c35c09da7c367 Mon Sep 17 00:00:00 2001 From: William Easton Date: Thu, 4 Dec 2025 17:40:58 -0600 Subject: [PATCH 3/4] Purposefully fail the workflow --- .github/workflows/martian-test-failure.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/martian-test-failure.yml b/.github/workflows/martian-test-failure.yml index 772f6384e..19db05e08 100644 --- a/.github/workflows/martian-test-failure.yml +++ b/.github/workflows/martian-test-failure.yml @@ -114,7 +114,7 @@ jobs: - You can also run git commands (e.g., `git status`, `git log`, `git diff`) to inspect the repository - You can use WebSearch and WebFetch to research errors, stack traces, or related issues - For bash commands, you are limited to make and git commands only - + # CRITICAL: Loop Detection **IMPORTANT**: Before posting your analysis, check the PR comments to detect if there's a loop where: - CodeRabbit or another bot triggered this workflow From b130c0161e39455f9c7658d38189b4afe3dbe58b Mon Sep 17 00:00:00 2001 From: William Easton Date: Thu, 4 Dec 2025 17:57:08 -0600 Subject: [PATCH 4/4] Small additional changes --- .github/workflows/martian-test-failure.yml | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/.github/workflows/martian-test-failure.yml b/.github/workflows/martian-test-failure.yml index 19db05e08..927816cf2 100644 --- a/.github/workflows/martian-test-failure.yml +++ b/.github/workflows/martian-test-failure.yml @@ -109,21 +109,13 @@ jobs: is short and easy to read but additional information is a click away. - Focus on facts from the logs and code, not speculation - If you can't determine the root cause, say so clearly + - If your only suggestion is a bad suggestion (disable the test, change the timeout, etc), indicate that you've run out of ideas and + that they probably don't want to do that. - Provide specific file names, line numbers, and code references when possible - You can run make commands (e.g., `make lint`, `make typecheck`, `make sync`) to build, test, or lint the code - You can also run git commands (e.g., `git status`, `git log`, `git diff`) to inspect the repository - You can use WebSearch and WebFetch to research errors, stack traces, or related issues - For bash commands, you are limited to make and git commands only - - # CRITICAL: Loop Detection - **IMPORTANT**: Before posting your analysis, check the PR comments to detect if there's a loop where: - - CodeRabbit or another bot triggered this workflow - - Your previous analysis triggered CodeRabbit or another bot - - This created a repeating cycle of bot comments - - If you detect such a loop (e.g., you see multiple similar bot comments or your own previous analysis comments): - 1. **DO NOT** post another analysis comment - 2. Exit immediately without further action # CRITICAL: ANGRY USERS **IMPORTANT**: If the user is angry with you, the triage bot, don't respond. Just exit immediately without further action. @@ -133,7 +125,9 @@ jobs: # IMPORTANT: EDIT YOUR COMMENT Do not post a new comment every time you triage a failing workflow. If a previous comment has been posted by you (marvin) - in a previous triage, edit that comment do not add a new comment for each failure. + in a previous triage, edit that comment do not add a new comment for each failure. Be sure to include a note that you've edited + your comment to reflect the latest analysis. Don't worry about keeping the old content around, there's comment history for + that. # Problems Encountered If you encounter any problems during your analysis (e.g., unable to fetch logs, tools not working), document them clearly so the team knows what limitations you faced.