add server name to mounted server warnings (#1147)

This commit is contained in:
Aidan 2025-07-17 12:02:30 -07:00 committed by GitHub
commit ebe817601c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 10 additions and 7 deletions

View file

@ -78,7 +78,7 @@ class PromptManager:
except Exception as e:
# Skip failed mounts silently, matches existing behavior
logger.warning(
f"Failed to get prompts from mounted server '{mounted.prefix}': {e}"
f"Failed to get prompts from server: {mounted.server.name!r}, mounted at: {mounted.prefix!r}: {e}"
)
continue

View file

@ -109,7 +109,7 @@ class ResourceManager:
except Exception as e:
# Skip failed mounts silently, matches existing behavior
logger.warning(
f"Failed to get resources from mounted server '{mounted.prefix}': {e}"
f"Failed to get resources from server: {mounted.server.name!r}, mounted at: {mounted.prefix!r}: {e}"
)
continue
@ -157,7 +157,7 @@ class ResourceManager:
except Exception as e:
# Skip failed mounts silently, matches existing behavior
logger.warning(
f"Failed to get templates from mounted server '{mounted.prefix}': {e}"
f"Failed to get templates from server: {mounted.server.name!r}, mounted at: {mounted.prefix!r}: {e}"
)
continue

View file

@ -76,7 +76,7 @@ class ToolManager:
except Exception as e:
# Skip failed mounts silently, matches existing behavior
logger.warning(
f"Failed to get tools from mounted server '{mounted.prefix}': {e}"
f"Failed to get tools from server: {mounted.server.name!r}, mounted at: {mounted.prefix!r}: {e}"
)
continue

View file

@ -317,15 +317,18 @@ class TestMultipleServerMount:
record.message for record in caplog.records if record.levelname == "WARNING"
]
assert any(
"Failed to get tools from mounted server 'unreachable'" in msg
"Failed to get tools from server: 'FastMCP', mounted at: 'unreachable'"
in msg
for msg in warning_messages
)
assert any(
"Failed to get resources from mounted server 'unreachable'" in msg
"Failed to get resources from server: 'FastMCP', mounted at: 'unreachable'"
in msg
for msg in warning_messages
)
assert any(
"Failed to get prompts from mounted server 'unreachable'" in msg
"Failed to get prompts from server: 'FastMCP', mounted at: 'unreachable'"
in msg
for msg in warning_messages
)