From e3cacdf3aff6dfd9858fdc2a8f1d7ca85b9fe4e0 Mon Sep 17 00:00:00 2001 From: William Easton Date: Sun, 24 Aug 2025 13:45:13 -0500 Subject: [PATCH] PR Feedback --- src/fastmcp/server/proxy.py | 3 --- src/fastmcp/utilities/mcp_config.py | 5 ++--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/fastmcp/server/proxy.py b/src/fastmcp/server/proxy.py index 9de5da845..57ec5facf 100644 --- a/src/fastmcp/server/proxy.py +++ b/src/fastmcp/server/proxy.py @@ -482,9 +482,6 @@ class FastMCPProxy(FastMCP): super().__init__(**kwargs) - if "name" not in kwargs: - kwargs["name"] = self.generate_name() - # Handle client and client_factory parameters if client is not None and client_factory is not None: raise ValueError("Cannot specify both 'client' and 'client_factory'") diff --git a/src/fastmcp/utilities/mcp_config.py b/src/fastmcp/utilities/mcp_config.py index 42bab894a..ef4da8a78 100644 --- a/src/fastmcp/utilities/mcp_config.py +++ b/src/fastmcp/utilities/mcp_config.py @@ -10,7 +10,7 @@ from fastmcp.mcp_config import ( MCPConfig, MCPServerTypes, ) -from fastmcp.server.proxy import ProxyClient +from fastmcp.server.proxy import FastMCPProxy, ProxyClient from fastmcp.server.server import FastMCP @@ -29,7 +29,6 @@ def mcp_server_type_to_servers_and_transports( mcp_server: MCPServerTypes, ) -> tuple[str, FastMCP[Any], ClientTransport]: """A utility function to convert each entry of an MCP Config into a transport and server.""" - import secrets from fastmcp.mcp_config import ( TransformingRemoteMCPServer, @@ -40,7 +39,7 @@ def mcp_server_type_to_servers_and_transports( transport: ClientTransport client_name = ProxyClient.generate_name(f"MCP_{name}") - server_name = FastMCP.generate_name(f"MCP_{name}") + server_name = FastMCPProxy.generate_name(f"MCP_{name}") if isinstance(mcp_server, TransformingRemoteMCPServer | TransformingStdioMCPServer): server, transport = mcp_server._to_server_and_underlying_transport(