From 7b5ef3e5e5e0316b90ddabb25d3879908bbed75b Mon Sep 17 00:00:00 2001 From: Jeremiah Lowin <153965+jlowin@users.noreply.github.com> Date: Fri, 20 Jun 2025 11:50:16 -0400 Subject: [PATCH] Use specific ValidationError instead of broad Exception catch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Addresses PR feedback to use more specific exception handling for URL validation failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- src/fastmcp/server/auth/providers/bearer.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fastmcp/server/auth/providers/bearer.py b/src/fastmcp/server/auth/providers/bearer.py index e544802f9..a4f3a8e48 100644 --- a/src/fastmcp/server/auth/providers/bearer.py +++ b/src/fastmcp/server/auth/providers/bearer.py @@ -17,7 +17,7 @@ from mcp.shared.auth import ( OAuthClientInformationFull, OAuthToken, ) -from pydantic import AnyHttpUrl, SecretStr +from pydantic import AnyHttpUrl, SecretStr, ValidationError from fastmcp.server.auth.auth import ( ClientRegistrationOptions, @@ -183,7 +183,7 @@ class BearerAuthProvider(OAuthProvider): # This allows the issuer claim validation to work with string issuers per RFC 7519 try: issuer_url = AnyHttpUrl(issuer) if issuer else "https://fastmcp.example.com" - except Exception: + except ValidationError: # Issuer is not a valid URL, use default for parent class issuer_url = "https://fastmcp.example.com"