ceos/fastmcp
1
0
Fork 0
mirror of https://github.com/PrefectHQ/fastmcp.git synced 2026-08-09 07:09:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: preserve tool properties named 'title' during schema compression (#3582)

Browse source
This commit is contained in:
Jeremiah Lowin 2026-03-22 09:48:20 -04:00 • committed by GitHub
commit 718ed8b140
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 35 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/marvin-label-triage.yml vendored
View file

@ -97,10 +97,10 @@ jobs:
STATUS (apply if applicable):
- needs more info: Issue lacks reproduction steps, error messages, or clear description
- invalid: Spam, completely off-topic, or nonsensical (often LLM-generated)
- too-long: Issue/PR goes beyond what the contributor guidelines ask for. Typical signs: "Root cause" or "Fix" sections, proposed code changes, multi-step diagnostic writeups, speculative analysis, or structured reports that read like LLM output. The contributor guidelines ask for a short problem description and an MRE — anything beyond that (unless it reflects genuine, non-obvious investigation) is too much. This applies even when the extra content is accurate — unsolicited diagnosis transfers triage burden to maintainers. Apply this label and do not apply other triage labels. The author needs to condense before triage is worthwhile.
- too-long: Issue/PR goes beyond what the contributor guidelines ask for. The guidelines ask for a short problem description and an MRE — anything beyond that needs scrutiny. However, DO NOT apply this label if the extra content is a brief, specific root-cause analysis (1-3 sentences) that names concrete functions, files, or code paths in the codebase. That kind of analysis saves triage time and should be welcomed. DO apply this label when the extra content is: proposed code changes or patches, multi-step diagnostic writeups, speculative analysis that doesn't reference specific code, structured reports with multiple headed sections that read like LLM output, or verbose "Fix" sections. The key question: does the extra content demonstrate that the reporter actually read the relevant source code, or does it read like speculation? Short and specific = fine. Long and generic = too much. When applying, do not apply other triage labels. The author needs to condense before triage is worthwhile.
WHEN APPLYING too-long: After labeling, post a brief comment using mcp__github__add_issue_comment:
"Thanks for the report. This issue goes beyond what our contributor guidelines ask for — we just need a short problem description and an MRE. Please see [our pinned guidelines](https://github.com/PrefectHQ/fastmcp/issues/3506) and condense this issue. We'll triage it once it's trimmed down."
"Thanks for the report. This issue goes beyond what our contributor guidelines ask for — we just need a short problem description and an MRE. Please see our [contributing guidelines](https://github.com/PrefectHQ/fastmcp/blob/main/CONTRIBUTING.md) and condense this issue. We'll triage it once it's trimmed down."
Use this exact text (or very close to it). Do not editorialize or add details.
AREA LABELS (apply ONLY when thematically central to the issue):