From 6c51dad870a201813958905bf38875656a1ece93 Mon Sep 17 00:00:00 2001 From: Jeremiah Lowin <153965+jlowin@users.noreply.github.com> Date: Sat, 23 Aug 2025 09:43:01 -0400 Subject: [PATCH] Skip flaky windows test (#1596) --- .github/workflows/run-tests.yml | 6 +++--- tests/test_mcp_config.py | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 159e92778..f78ff55d2 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -48,10 +48,10 @@ jobs: run: uv sync --frozen - name: Run tests (excluding integration and client_process) - run: uv run pytest tests -m "not integration and not client_process" + run: uv run pytest -v tests -m "not integration and not client_process" - name: Run client process tests separately - run: uv run pytest tests -m "client_process" -x + run: uv run pytest -v tests -m "client_process" -x run_integration_tests: name: "Run integration tests" @@ -73,7 +73,7 @@ jobs: run: uv sync --frozen - name: Run integration tests - run: uv run pytest tests -m "integration" + run: uv run pytest -v tests -m "integration" env: FASTMCP_GITHUB_TOKEN: ${{ secrets.FASTMCP_GITHUB_TOKEN }} FASTMCP_TEST_AUTH_GITHUB_CLIENT_ID: ${{ secrets.FASTMCP_TEST_AUTH_GITHUB_CLIENT_ID }} diff --git a/tests/test_mcp_config.py b/tests/test_mcp_config.py index dc0b98af2..f8e396b4f 100644 --- a/tests/test_mcp_config.py +++ b/tests/test_mcp_config.py @@ -309,6 +309,10 @@ async def test_multi_client_lifespan(tmp_path: Path): await asyncio.sleep(0.1) +@pytest.mark.skipif( + sys.platform.startswith("win32"), + reason="Windows has process lifecycle issues", +) async def test_multi_client_force_close(tmp_path: Path): server_script = inspect.cleandoc(""" from fastmcp import FastMCP