Log tool name on transform validation error (#1238)

This commit is contained in:
William Easton 2025-07-23 08:56:17 -05:00 committed by GitHub
commit 653fe0f89f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions

View file

@ -445,7 +445,7 @@ class TransformedTool(Tool):
if unknown_args:
raise ValueError(
f"Unknown arguments in transform_args: {', '.join(sorted(unknown_args))}. "
f"Parent tool has: {', '.join(sorted(parent_params))}"
f"Parent tool `{tool.name}` has: {', '.join(sorted(parent_params))}"
)
# Always create the forwarding transform

View file

@ -404,11 +404,13 @@ def test_transform_args_validation_unknown_arg(add_tool):
"""Test that transform_args with unknown arguments raises ValueError."""
with pytest.raises(
ValueError, match="Unknown arguments in transform_args: unknown_param"
):
) as exc_info:
Tool.from_tool(
add_tool, transform_args={"unknown_param": ArgTransform(name="new_name")}
)
assert "`add`" in str(exc_info.value)
def test_transform_args_creates_duplicate_names(add_tool):
"""Test that transform_args creating duplicate parameter names raises ValueError."""