ceos/fastmcp
1
0
Fork 0
mirror of https://github.com/PrefectHQ/fastmcp.git synced 2026-08-09 07:09:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Write downloaded skill text as UTF-8 (#4715)

Browse source
This commit is contained in:
nate nowack 2026-08-02 08:33:32 -05:00 • committed by GitHub
commit 40c3e122e8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 48 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
fastmcp_slim/fastmcp/utilities/skills.py
View file

@ -205,7 +205,7 @@ async def download_skill(
# Write content
if isinstance(content, mcp_types.TextResourceContents):
file_path.write_text(content.text)
file_path.write_text(content.text, encoding="utf-8")
elif isinstance(content, mcp_types.BlobResourceContents):
file_path.write_bytes(base64.b64decode(content.blob))
else:

47
tests/utilities/test_skills.py
View file

@ -269,6 +269,53 @@ class TestDownloadSkill:
downloaded = (result / "SKILL.md").read_text()
assert downloaded == original
async def test_writes_text_resources_as_utf8(
self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
):
content = "Use the tool — then stop."
manifest = {
"skill": "unicode",
"files": [
{
"path": "SKILL.md",
"size": len(content.encode("utf-8")),
"hash": "sha256:unicode",
}
],
}
client = FakeResourceReader(
{
"skill://unicode/_manifest": [
text_resource("skill://unicode/_manifest", json.dumps(manifest))
],
"skill://unicode/SKILL.md": [
text_resource("skill://unicode/SKILL.md", content)
],
}
)
original_write_text = Path.write_text
def locale_sensitive_write_text(
path: Path,
data: str,
encoding: str | None = None,
errors: str | None = None,
newline: str | None = None,
) -> int:
return original_write_text(
path,
data,
encoding=encoding or "ascii",
errors=errors,
newline=newline,
)
monkeypatch.setattr(Path, "write_text", locale_sensitive_write_text)
result = await download_skill(cast(Client, client), "unicode", tmp_path)
assert (result / "SKILL.md").read_text(encoding="utf-8") == content
async def test_raises_if_exists_without_overwrite(
self, skills_server: FastMCP, tmp_path: Path
):