From 98dc10374915c087c3a7368ccdb28bbb3df701b6 Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Mon, 15 Aug 2022 23:48:26 +0200 Subject: [PATCH] queue_process_entry: Avoid leaving error uninitialized CMD_PAUSE was not actually setting error to EE_OK, and the default case, even if it is not supposed to happen, should set error to something sane. --- src/espeak.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/espeak.c b/src/espeak.c index b4b58ca..73876b4 100644 --- a/src/espeak.c +++ b/src/espeak.c @@ -377,12 +377,18 @@ static void queue_process_entry(struct synth_t *s) break; case CMD_PAUSE: if (!paused_espeak) { - espeak_Cancel(); - espeak_Terminate(); - paused_espeak = 1; + error = espeak_Cancel(); + if (error == EE_OK) + error = espeak_Terminate(); + if (error == EE_OK) + paused_espeak = 1; + } else { + error = EE_OK; } break; default: + /* Uh? */ + error = EE_OK; break; }